u-boot/arch/arm/lib/reset.c

/*
 * (C) Copyright 2002
 * Sysgo Real-Time Solutions, GmbH <www.elinos.com>
 * Marius Groeger <mgroeger@sysgo.de>
 *
 * (C) Copyright 2002
 * Sysgo Real-Time Solutions, GmbH <www.elinos.com>
 * Alex Zuepke <azu@sysgo.de>
 *
 * (C) Copyright 2002
 * Gary Jennejohn, DENX Software Engineering, <garyj@denx.de>
 *
 * (C) Copyright 2004
 * DAVE Srl
 * http://www.dave-tech.it
 * http://www.wawnet.biz
 * mailto:info@wawnet.biz
 *
 * (C) Copyright 2004 Texas Insturments
 *
 * SPDX-License-Identifier:	GPL-2.0+
 */

#include <common.h>

int do_reset(cmd_tbl_t *cmdtp, int flag, int argc, char * const argv[])
{
	puts ("resetting ...\n");

	udelay (50000);				/* wait 50 ms */

	disable_interrupts();
	reset_cpu(0);

	/*NOTREACHED*/
	return 0;
}
arm: unify reset command Signed-off-by: Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com> 2009-04-05 11:08:03 +00:00			`/*`
			`* (C) Copyright 2002`
			`* Sysgo Real-Time Solutions, GmbH <www.elinos.com>`
			`* Marius Groeger <mgroeger@sysgo.de>`
			`*`
			`* (C) Copyright 2002`
			`* Sysgo Real-Time Solutions, GmbH <www.elinos.com>`
			`* Alex Zuepke <azu@sysgo.de>`
			`*`
			`* (C) Copyright 2002`
Fix e-mail address of Gary Jennejohn. Signed-off-by: Detlev Zundel <dzu@denx.de> 2009-05-13 08:54:10 +00:00			`* Gary Jennejohn, DENX Software Engineering, <garyj@denx.de>`
arm: unify reset command Signed-off-by: Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com> 2009-04-05 11:08:03 +00:00			`*`
			`* (C) Copyright 2004`
			`* DAVE Srl`
			`* http://www.dave-tech.it`
			`* http://www.wawnet.biz`
			`* mailto:info@wawnet.biz`
			`*`
			`* (C) Copyright 2004 Texas Insturments`
			`*`
Add GPL-2.0+ SPDX-License-Identifier to source files Signed-off-by: Wolfgang Denk <wd@denx.de> [trini: Fixup common/cmd_io.c] Signed-off-by: Tom Rini <trini@ti.com> 2013-07-08 07:37:19 +00:00			`* SPDX-License-Identifier: GPL-2.0+`
arm: unify reset command Signed-off-by: Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com> 2009-04-05 11:08:03 +00:00			`*/`

			`#include <common.h>`

Make sure that argv[] argument pointers are not modified. The hush shell dynamically allocates (and re-allocates) memory for the argument strings in the "char argv[]" argument vector passed to commands. Any code that modifies these pointers will cause serious corruption of the malloc data structures and crash U-Boot, so make sure the compiler can check that no such modifications are being done by changing the code into "char const argv[]". This modification is the result of debugging a strange crash caused after adding a new command, which used the following argument processing code which has been working perfectly fine in all Unix systems since version 6 - but not so in U-Boot: int main (int argc, char argv) { while (--argc > 0 && ++argv == '-') { /* ====> / while (++argv) { switch (argv) { case 'd': debug++; break; ... default: usage (); } } } ... } The line marked "====>" will corrupt the malloc data structures and usually cause U-Boot to crash when the next command gets executed by the shell. With the modification, the compiler will prevent this with an error: increment of read-only location 'argv' N.B.: The code above can be trivially rewritten like this: while (--argc > 0 && *++argv == '-') { char arg = argv; while (++arg) { switch (*arg) { ... Signed-off-by: Wolfgang Denk <wd@denx.de> Acked-by: Mike Frysinger <vapier@gentoo.org> 2010-06-28 20:00:46 +00:00			`int do_reset(cmd_tbl_t cmdtp, int flag, int argc, char const argv[])`
arm: unify reset command Signed-off-by: Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com> 2009-04-05 11:08:03 +00:00			`{`
			`puts ("resetting ...\n");`

			`udelay (50000); /* wait 50 ms */`

			`disable_interrupts();`
			`reset_cpu(0);`

			`/NOTREACHED/`
			`return 0;`
			`}`