u-boot/common/spl/spl_imx_container.c

156 lines
3.4 KiB
C
Raw Normal View History

// SPDX-License-Identifier: GPL-2.0+
/*
* Copyright 2018-2021 NXP
*/
#define LOG_CATEGORY LOGC_ARCH
#include <common.h>
#include <stdlib.h>
#include <errno.h>
arm: imx: Check header before calling spl_load_imx_container Make sure we have an IMX header before calling spl_load_imx_container, since if we don't it will fail with -ENOENT. This allows us to fall back to legacy/raw images if they are also enabled. This is a functional change, one which likely should have been in place from the start, but a functional change nonetheless. Previously, all non-IMX8 images (except FITs without FIT_FULL) would be optimized out if the only image load method enabled supported IMX8 images. With this change, support for other image types now has an effect. There are seven boards with SPL_LOAD_IMX_CONTAINER enabled: three with SPL_BOOTROM_SUPPORT: imx93_11x11_evk_ld imx93_11x11_evk imx8ulp_evk and four with SPL_MMC: deneb imx8qxp_mek giedi imx8qm_mek All of these boards also have SPL_RAW_IMAGE_SUPPORT and SPL_LEGACY_IMAGE_FORMAT enabled as well. However, none have FIT support enabled. Of the six load methods affected by this patch, only SPL_MMC and SPL_BOOTROM_SUPPORT are enabled with SPL_LOAD_IMX_CONTAINER. spl_romapi_load_image_seekable does not support legacy or raw images, so there is no growth. However, mmc_load_image_raw_sector does support loading legacy/raw images. Since these images could not have been booted before, I have disabled support for legacy/raw images on these four boards. This reduces bloat from around 800 bytes to around 200. There are no in-tree boards with SPL_LOAD_IMX_CONTAINER and AHAB_BOOT both enabled, so we do not need to worry about potentially falling back to legacy images in a secure boot scenario. Future work could include merging imx_container.h with imx8image.h, since they appear to define mostly the same structures. Signed-off-by: Sean Anderson <seanga2@gmail.com>
2023-10-14 20:47:44 +00:00
#include <imx_container.h>
#include <log.h>
#include <mapmem.h>
#include <spl.h>
#ifdef CONFIG_AHAB_BOOT
#include <asm/mach-imx/ahab.h>
#endif
static struct boot_img_t *read_auth_image(struct spl_image_info *spl_image,
struct spl_load_info *info,
struct container_hdr *container,
int image_index,
ulong container_offset)
{
struct boot_img_t *images;
ulong offset, overhead, size;
if (image_index > container->num_images) {
debug("Invalid image number\n");
return NULL;
}
images = (struct boot_img_t *)((u8 *)container +
sizeof(struct container_hdr));
if (!IS_ALIGNED(images[image_index].offset, info->bl_len)) {
printf("%s: image%d offset not aligned to %u\n",
__func__, image_index, info->bl_len);
return NULL;
}
size = ALIGN(images[image_index].size, info->bl_len);
offset = images[image_index].offset + container_offset;
debug("%s: container: %p offset: %lu size: %lu\n", __func__,
container, offset, size);
if (info->read(info, offset, size,
map_sysmem(images[image_index].dst - overhead,
images[image_index].size)) <
images[image_index].size) {
printf("%s wrong\n", __func__);
return NULL;
}
#ifdef CONFIG_AHAB_BOOT
if (ahab_verify_cntr_image(&images[image_index], image_index))
return NULL;
#endif
return &images[image_index];
}
static int read_auth_container(struct spl_image_info *spl_image,
struct spl_load_info *info, ulong offset)
{
struct container_hdr *container = NULL;
u16 length;
int i, size, ret = 0;
size = ALIGN(CONTAINER_HDR_ALIGNMENT, info->bl_len);
/*
* It will not override the ATF code, so safe to use it here,
* no need malloc
*/
container = malloc(size);
if (!container)
return -ENOMEM;
debug("%s: container: %p offset: %lu size: %u\n", __func__,
container, offset, size);
if (info->read(info, offset, size, container) <
CONTAINER_HDR_ALIGNMENT) {
ret = -EIO;
goto end;
}
if (!valid_container_hdr(container)) {
log_err("Wrong container header\n");
ret = -ENOENT;
goto end;
}
if (!container->num_images) {
log_err("Wrong container, no image found\n");
ret = -ENOENT;
goto end;
}
length = container->length_lsb + (container->length_msb << 8);
debug("Container length %u\n", length);
if (length > CONTAINER_HDR_ALIGNMENT) {
size = ALIGN(length, info->bl_len);
free(container);
container = malloc(size);
if (!container)
return -ENOMEM;
debug("%s: container: %p offset: %lu size: %u\n",
__func__, container, offset, size);
if (info->read(info, offset, size, container) < length) {
ret = -EIO;
goto end;
}
}
#ifdef CONFIG_AHAB_BOOT
ret = ahab_auth_cntr_hdr(container, length);
if (ret)
goto end_auth;
#endif
for (i = 0; i < container->num_images; i++) {
struct boot_img_t *image = read_auth_image(spl_image, info,
container, i,
offset);
if (!image) {
ret = -EINVAL;
goto end_auth;
}
if (i == 0) {
spl_image->load_addr = image->dst;
spl_image->entry_point = image->entry;
}
}
end_auth:
#ifdef CONFIG_AHAB_BOOT
ahab_auth_release();
#endif
end:
free(container);
return ret;
}
int spl_load_imx_container(struct spl_image_info *spl_image,
struct spl_load_info *info, ulong offset)
{
return read_auth_container(spl_image, info, offset);
}