2021-03-08 00:34:47 +00:00
|
|
|
// SPDX-License-Identifier: GPL-2.0+
|
|
|
|
/*
|
|
|
|
* Copyright 2021 Google LLC
|
|
|
|
* Written by Simon Glass <sjg@chromium.org>
|
|
|
|
*/
|
|
|
|
|
|
|
|
#include <common.h>
|
2022-10-30 01:47:08 +00:00
|
|
|
#include <blk.h>
|
2021-03-08 00:34:47 +00:00
|
|
|
#include <console.h>
|
2022-09-02 11:57:54 +00:00
|
|
|
#include <cyclic.h>
|
2021-03-08 00:34:50 +00:00
|
|
|
#include <dm.h>
|
2022-03-04 15:43:01 +00:00
|
|
|
#include <event.h>
|
2022-09-07 02:27:11 +00:00
|
|
|
#include <of_live.h>
|
test: Make a copy of the device tree before running a test
When the flat device tree changes it can mess up the live tree since that
uses the flat tree for its strings. This affects only a few sandbox tests
which modify the device tree, but the number will grow as ofnode support
for writing improves.
While the control FDT is not intended to change while U-Boot is running,
some tests do so. For example, the ofnode interface only supports
modifying properties in the control FDT, so tests must use that.
To solve this problem, keep a copy of the FDT and restore it as needed
when the test is finished. The copy only happens on sandbox (except SPL
builds), to reduce memory usage and because these tests are not useful on
other boards. For other boards, a checksum is taken to ensure that nothing
changes.
It would be possible to always checksum the FDT on sandbox and only
restore it if needed, but this is slightly slower than restoring it every
time, at least with crc8.
Move the code which checks for success to the very end, for clarity.
Signed-off-by: Simon Glass <sjg@chromium.org>
2022-09-07 02:27:05 +00:00
|
|
|
#include <os.h>
|
2022-09-07 02:27:19 +00:00
|
|
|
#include <dm/ofnode.h>
|
2021-03-08 00:34:50 +00:00
|
|
|
#include <dm/root.h>
|
2021-03-08 00:34:58 +00:00
|
|
|
#include <dm/test.h>
|
2021-03-08 00:34:59 +00:00
|
|
|
#include <dm/uclass-internal.h>
|
2021-03-08 00:34:47 +00:00
|
|
|
#include <test/test.h>
|
2021-03-08 00:34:50 +00:00
|
|
|
#include <test/ut.h>
|
test: Make a copy of the device tree before running a test
When the flat device tree changes it can mess up the live tree since that
uses the flat tree for its strings. This affects only a few sandbox tests
which modify the device tree, but the number will grow as ofnode support
for writing improves.
While the control FDT is not intended to change while U-Boot is running,
some tests do so. For example, the ofnode interface only supports
modifying properties in the control FDT, so tests must use that.
To solve this problem, keep a copy of the FDT and restore it as needed
when the test is finished. The copy only happens on sandbox (except SPL
builds), to reduce memory usage and because these tests are not useful on
other boards. For other boards, a checksum is taken to ensure that nothing
changes.
It would be possible to always checksum the FDT on sandbox and only
restore it if needed, but this is slightly slower than restoring it every
time, at least with crc8.
Move the code which checks for success to the very end, for clarity.
Signed-off-by: Simon Glass <sjg@chromium.org>
2022-09-07 02:27:05 +00:00
|
|
|
#include <u-boot/crc.h>
|
2021-03-08 00:34:47 +00:00
|
|
|
|
2021-03-08 00:34:49 +00:00
|
|
|
DECLARE_GLOBAL_DATA_PTR;
|
|
|
|
|
test: Make a copy of the device tree before running a test
When the flat device tree changes it can mess up the live tree since that
uses the flat tree for its strings. This affects only a few sandbox tests
which modify the device tree, but the number will grow as ofnode support
for writing improves.
While the control FDT is not intended to change while U-Boot is running,
some tests do so. For example, the ofnode interface only supports
modifying properties in the control FDT, so tests must use that.
To solve this problem, keep a copy of the FDT and restore it as needed
when the test is finished. The copy only happens on sandbox (except SPL
builds), to reduce memory usage and because these tests are not useful on
other boards. For other boards, a checksum is taken to ensure that nothing
changes.
It would be possible to always checksum the FDT on sandbox and only
restore it if needed, but this is slightly slower than restoring it every
time, at least with crc8.
Move the code which checks for success to the very end, for clarity.
Signed-off-by: Simon Glass <sjg@chromium.org>
2022-09-07 02:27:05 +00:00
|
|
|
/**
|
|
|
|
* enum fdtchk_t - what to do with the device tree (gd->fdt_blob)
|
|
|
|
*
|
|
|
|
* This affects what happens with the device tree before and after a test
|
|
|
|
*
|
|
|
|
* @FDTCHK_NONE: Do nothing
|
|
|
|
* @FDTCHK_CHECKSUM: Take a checksum of the FDT before the test runs and
|
|
|
|
* compare it afterwards to detect any changes
|
|
|
|
* @FDTCHK_COPY: Make a copy of the FDT and restore it afterwards
|
|
|
|
*/
|
|
|
|
enum fdtchk_t {
|
|
|
|
FDTCHK_NONE,
|
|
|
|
FDTCHK_CHECKSUM,
|
|
|
|
FDTCHK_COPY,
|
|
|
|
};
|
|
|
|
|
|
|
|
/**
|
|
|
|
* fdt_action() - get the required action for the FDT
|
|
|
|
*
|
|
|
|
* @return the action that should be taken for this build
|
|
|
|
*/
|
|
|
|
static enum fdtchk_t fdt_action(void)
|
|
|
|
{
|
|
|
|
/* Do a copy for sandbox (but only the U-Boot build, not SPL) */
|
|
|
|
if (CONFIG_IS_ENABLED(SANDBOX))
|
|
|
|
return FDTCHK_COPY;
|
|
|
|
|
|
|
|
/* For sandbox SPL builds, do nothing */
|
|
|
|
if (IS_ENABLED(CONFIG_SANDBOX))
|
|
|
|
return FDTCHK_NONE;
|
|
|
|
|
|
|
|
/* For all other boards, do a checksum */
|
|
|
|
return FDTCHK_CHECKSUM;
|
|
|
|
}
|
|
|
|
|
2021-03-08 00:35:04 +00:00
|
|
|
/* This is valid when a test is running, NULL otherwise */
|
|
|
|
static struct unit_test_state *cur_test_state;
|
|
|
|
|
|
|
|
struct unit_test_state *test_get_state(void)
|
|
|
|
{
|
|
|
|
return cur_test_state;
|
|
|
|
}
|
|
|
|
|
|
|
|
void test_set_state(struct unit_test_state *uts)
|
|
|
|
{
|
|
|
|
cur_test_state = uts;
|
|
|
|
}
|
|
|
|
|
2021-03-08 00:34:58 +00:00
|
|
|
/**
|
|
|
|
* dm_test_pre_run() - Get ready to run a driver model test
|
|
|
|
*
|
|
|
|
* This clears out the driver model data structures. For sandbox it resets the
|
|
|
|
* state structure
|
|
|
|
*
|
|
|
|
* @uts: Test state
|
|
|
|
*/
|
|
|
|
static int dm_test_pre_run(struct unit_test_state *uts)
|
|
|
|
{
|
|
|
|
bool of_live = uts->of_live;
|
|
|
|
|
2022-09-07 02:27:06 +00:00
|
|
|
if (of_live && (gd->flags & GD_FLG_FDT_CHANGED)) {
|
|
|
|
printf("Cannot run live tree test as device tree changed\n");
|
|
|
|
return -EFAULT;
|
|
|
|
}
|
2021-03-08 00:34:58 +00:00
|
|
|
uts->root = NULL;
|
|
|
|
uts->testdev = NULL;
|
|
|
|
uts->force_fail_alloc = false;
|
|
|
|
uts->skip_post_probe = false;
|
test: Make a copy of the device tree before running a test
When the flat device tree changes it can mess up the live tree since that
uses the flat tree for its strings. This affects only a few sandbox tests
which modify the device tree, but the number will grow as ofnode support
for writing improves.
While the control FDT is not intended to change while U-Boot is running,
some tests do so. For example, the ofnode interface only supports
modifying properties in the control FDT, so tests must use that.
To solve this problem, keep a copy of the FDT and restore it as needed
when the test is finished. The copy only happens on sandbox (except SPL
builds), to reduce memory usage and because these tests are not useful on
other boards. For other boards, a checksum is taken to ensure that nothing
changes.
It would be possible to always checksum the FDT on sandbox and only
restore it if needed, but this is slightly slower than restoring it every
time, at least with crc8.
Move the code which checks for success to the very end, for clarity.
Signed-off-by: Simon Glass <sjg@chromium.org>
2022-09-07 02:27:05 +00:00
|
|
|
if (fdt_action() == FDTCHK_CHECKSUM)
|
|
|
|
uts->fdt_chksum = crc8(0, gd->fdt_blob,
|
|
|
|
fdt_totalsize(gd->fdt_blob));
|
2021-03-08 00:34:58 +00:00
|
|
|
gd->dm_root = NULL;
|
2022-09-07 02:27:00 +00:00
|
|
|
malloc_disable_testing();
|
2021-07-05 22:32:43 +00:00
|
|
|
if (CONFIG_IS_ENABLED(UT_DM) && !CONFIG_IS_ENABLED(OF_PLATDATA))
|
2021-03-08 00:34:58 +00:00
|
|
|
memset(dm_testdrv_op_count, '\0', sizeof(dm_testdrv_op_count));
|
2021-03-24 21:44:33 +00:00
|
|
|
arch_reset_for_test();
|
2021-03-08 00:34:58 +00:00
|
|
|
|
|
|
|
/* Determine whether to make the live tree available */
|
|
|
|
gd_set_of_root(of_live ? uts->of_root : NULL);
|
2022-09-07 02:27:19 +00:00
|
|
|
oftree_reset();
|
2021-03-08 00:34:58 +00:00
|
|
|
ut_assertok(dm_init(of_live));
|
|
|
|
uts->root = dm_root();
|
|
|
|
|
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
|
2021-03-08 00:34:59 +00:00
|
|
|
static int dm_test_post_run(struct unit_test_state *uts)
|
|
|
|
{
|
|
|
|
int id;
|
|
|
|
|
test: Make a copy of the device tree before running a test
When the flat device tree changes it can mess up the live tree since that
uses the flat tree for its strings. This affects only a few sandbox tests
which modify the device tree, but the number will grow as ofnode support
for writing improves.
While the control FDT is not intended to change while U-Boot is running,
some tests do so. For example, the ofnode interface only supports
modifying properties in the control FDT, so tests must use that.
To solve this problem, keep a copy of the FDT and restore it as needed
when the test is finished. The copy only happens on sandbox (except SPL
builds), to reduce memory usage and because these tests are not useful on
other boards. For other boards, a checksum is taken to ensure that nothing
changes.
It would be possible to always checksum the FDT on sandbox and only
restore it if needed, but this is slightly slower than restoring it every
time, at least with crc8.
Move the code which checks for success to the very end, for clarity.
Signed-off-by: Simon Glass <sjg@chromium.org>
2022-09-07 02:27:05 +00:00
|
|
|
if (gd->fdt_blob) {
|
|
|
|
switch (fdt_action()) {
|
|
|
|
case FDTCHK_COPY:
|
|
|
|
memcpy((void *)gd->fdt_blob, uts->fdt_copy, uts->fdt_size);
|
|
|
|
break;
|
|
|
|
case FDTCHK_CHECKSUM: {
|
|
|
|
uint chksum;
|
|
|
|
|
|
|
|
chksum = crc8(0, gd->fdt_blob, fdt_totalsize(gd->fdt_blob));
|
2022-09-07 02:27:06 +00:00
|
|
|
if (chksum != uts->fdt_chksum) {
|
|
|
|
/*
|
|
|
|
* We cannot run any more tests that need the
|
|
|
|
* live tree, since its strings point into the
|
|
|
|
* flat tree, which has changed. This likely
|
|
|
|
* means that at least some of the pointers from
|
|
|
|
* the live tree point to different things
|
|
|
|
*/
|
test: Make a copy of the device tree before running a test
When the flat device tree changes it can mess up the live tree since that
uses the flat tree for its strings. This affects only a few sandbox tests
which modify the device tree, but the number will grow as ofnode support
for writing improves.
While the control FDT is not intended to change while U-Boot is running,
some tests do so. For example, the ofnode interface only supports
modifying properties in the control FDT, so tests must use that.
To solve this problem, keep a copy of the FDT and restore it as needed
when the test is finished. The copy only happens on sandbox (except SPL
builds), to reduce memory usage and because these tests are not useful on
other boards. For other boards, a checksum is taken to ensure that nothing
changes.
It would be possible to always checksum the FDT on sandbox and only
restore it if needed, but this is slightly slower than restoring it every
time, at least with crc8.
Move the code which checks for success to the very end, for clarity.
Signed-off-by: Simon Glass <sjg@chromium.org>
2022-09-07 02:27:05 +00:00
|
|
|
printf("Device tree changed: cannot run live tree tests\n");
|
2022-09-07 02:27:06 +00:00
|
|
|
gd->flags |= GD_FLG_FDT_CHANGED;
|
|
|
|
}
|
test: Make a copy of the device tree before running a test
When the flat device tree changes it can mess up the live tree since that
uses the flat tree for its strings. This affects only a few sandbox tests
which modify the device tree, but the number will grow as ofnode support
for writing improves.
While the control FDT is not intended to change while U-Boot is running,
some tests do so. For example, the ofnode interface only supports
modifying properties in the control FDT, so tests must use that.
To solve this problem, keep a copy of the FDT and restore it as needed
when the test is finished. The copy only happens on sandbox (except SPL
builds), to reduce memory usage and because these tests are not useful on
other boards. For other boards, a checksum is taken to ensure that nothing
changes.
It would be possible to always checksum the FDT on sandbox and only
restore it if needed, but this is slightly slower than restoring it every
time, at least with crc8.
Move the code which checks for success to the very end, for clarity.
Signed-off-by: Simon Glass <sjg@chromium.org>
2022-09-07 02:27:05 +00:00
|
|
|
break;
|
|
|
|
}
|
|
|
|
case FDTCHK_NONE:
|
|
|
|
break;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2021-03-15 04:25:21 +00:00
|
|
|
/*
|
|
|
|
* With of-platdata-inst the uclasses are created at build time. If we
|
|
|
|
* destroy them we cannot get them back since uclass_add() is not
|
|
|
|
* supported. So skip this.
|
|
|
|
*/
|
|
|
|
if (!CONFIG_IS_ENABLED(OF_PLATDATA_INST)) {
|
|
|
|
for (id = 0; id < UCLASS_COUNT; id++) {
|
|
|
|
struct uclass *uc;
|
2021-03-08 00:34:59 +00:00
|
|
|
|
2021-03-15 04:25:21 +00:00
|
|
|
/*
|
|
|
|
* If the uclass doesn't exist we don't want to create
|
|
|
|
* it. So check that here before we call
|
|
|
|
* uclass_find_device().
|
|
|
|
*/
|
|
|
|
uc = uclass_find(id);
|
|
|
|
if (!uc)
|
|
|
|
continue;
|
|
|
|
ut_assertok(uclass_destroy(uc));
|
|
|
|
}
|
2021-03-08 00:34:59 +00:00
|
|
|
}
|
|
|
|
|
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
|
2021-03-08 00:34:51 +00:00
|
|
|
/* Ensure all the test devices are probed */
|
|
|
|
static int do_autoprobe(struct unit_test_state *uts)
|
|
|
|
{
|
2022-10-12 19:57:51 +00:00
|
|
|
return uclass_probe_all(UCLASS_TEST);
|
2021-03-08 00:34:51 +00:00
|
|
|
}
|
|
|
|
|
2021-03-08 00:35:03 +00:00
|
|
|
/*
|
|
|
|
* ut_test_run_on_flattree() - Check if we should run a test with flat DT
|
|
|
|
*
|
|
|
|
* This skips long/slow tests where there is not much value in running a flat
|
|
|
|
* DT test in addition to a live DT test.
|
|
|
|
*
|
2022-01-19 17:05:50 +00:00
|
|
|
* Return: true to run the given test on the flat device tree
|
2021-03-08 00:35:03 +00:00
|
|
|
*/
|
|
|
|
static bool ut_test_run_on_flattree(struct unit_test *test)
|
|
|
|
{
|
|
|
|
const char *fname = strrchr(test->file, '/') + 1;
|
|
|
|
|
|
|
|
if (!(test->flags & UT_TESTF_DM))
|
|
|
|
return false;
|
|
|
|
|
|
|
|
return !strstr(fname, "video") || strstr(test->name, "video_base");
|
|
|
|
}
|
|
|
|
|
2021-03-08 00:35:05 +00:00
|
|
|
/**
|
|
|
|
* test_matches() - Check if a test should be run
|
|
|
|
*
|
|
|
|
* This checks if the a test should be run. In the normal case of running all
|
|
|
|
* tests, @select_name is NULL.
|
|
|
|
*
|
|
|
|
* @prefix: String prefix for the tests. Any tests that have this prefix will be
|
|
|
|
* printed without the prefix, so that it is easier to see the unique part
|
2021-03-08 00:35:12 +00:00
|
|
|
* of the test name. If NULL, any suite name (xxx_test) is considered to be
|
|
|
|
* a prefix.
|
2021-03-08 00:35:05 +00:00
|
|
|
* @test_name: Name of current test
|
|
|
|
* @select_name: Name of test to run (or NULL for all)
|
2022-01-19 17:05:50 +00:00
|
|
|
* Return: true to run this test, false to skip it
|
2021-03-08 00:35:05 +00:00
|
|
|
*/
|
|
|
|
static bool test_matches(const char *prefix, const char *test_name,
|
|
|
|
const char *select_name)
|
|
|
|
{
|
2021-02-11 14:40:10 +00:00
|
|
|
size_t len;
|
|
|
|
|
2021-03-08 00:35:05 +00:00
|
|
|
if (!select_name)
|
|
|
|
return true;
|
|
|
|
|
2021-02-11 14:40:10 +00:00
|
|
|
/* Allow glob expansion in the test name */
|
|
|
|
len = select_name[strlen(select_name) - 1] == '*' ? strlen(select_name) : 0;
|
|
|
|
if (len-- == 1)
|
|
|
|
return true;
|
|
|
|
|
|
|
|
if (!strncmp(test_name, select_name, len))
|
2021-03-08 00:35:05 +00:00
|
|
|
return true;
|
|
|
|
|
2021-02-11 14:40:11 +00:00
|
|
|
if (prefix) {
|
|
|
|
/* All tests have this prefix */
|
|
|
|
if (!strncmp(test_name, prefix, strlen(prefix)))
|
|
|
|
test_name += strlen(prefix);
|
|
|
|
} else {
|
2021-03-08 00:35:12 +00:00
|
|
|
const char *p = strstr(test_name, "_test_");
|
|
|
|
|
|
|
|
/* convert xxx_test_yyy to yyy, i.e. remove the suite name */
|
|
|
|
if (p)
|
2021-02-11 14:40:11 +00:00
|
|
|
test_name = p + strlen("_test_");
|
2021-03-08 00:35:12 +00:00
|
|
|
}
|
2021-03-08 00:35:05 +00:00
|
|
|
|
2021-02-11 14:40:10 +00:00
|
|
|
if (!strncmp(test_name, select_name, len))
|
2021-03-08 00:35:05 +00:00
|
|
|
return true;
|
|
|
|
|
|
|
|
return false;
|
|
|
|
}
|
|
|
|
|
2021-03-08 00:35:08 +00:00
|
|
|
/**
|
2021-03-08 00:35:07 +00:00
|
|
|
* ut_list_has_dm_tests() - Check if a list of tests has driver model ones
|
|
|
|
*
|
|
|
|
* @tests: List of tests to run
|
|
|
|
* @count: Number of tests to ru
|
2022-01-19 17:05:50 +00:00
|
|
|
* Return: true if any of the tests have the UT_TESTF_DM flag
|
2021-03-08 00:35:07 +00:00
|
|
|
*/
|
|
|
|
static bool ut_list_has_dm_tests(struct unit_test *tests, int count)
|
|
|
|
{
|
|
|
|
struct unit_test *test;
|
|
|
|
|
|
|
|
for (test = tests; test < tests + count; test++) {
|
|
|
|
if (test->flags & UT_TESTF_DM)
|
|
|
|
return true;
|
|
|
|
}
|
|
|
|
|
|
|
|
return false;
|
|
|
|
}
|
|
|
|
|
2021-03-08 00:35:08 +00:00
|
|
|
/**
|
|
|
|
* dm_test_restore() Put things back to normal so sandbox works as expected
|
|
|
|
*
|
|
|
|
* @of_root: Value to set for of_root
|
2022-01-19 17:05:50 +00:00
|
|
|
* Return: 0 if OK, -ve on error
|
2021-03-08 00:35:08 +00:00
|
|
|
*/
|
|
|
|
static int dm_test_restore(struct device_node *of_root)
|
|
|
|
{
|
|
|
|
int ret;
|
|
|
|
|
|
|
|
gd_set_of_root(of_root);
|
|
|
|
gd->dm_root = NULL;
|
|
|
|
ret = dm_init(CONFIG_IS_ENABLED(OF_LIVE));
|
|
|
|
if (ret)
|
|
|
|
return ret;
|
|
|
|
dm_scan_plat(false);
|
|
|
|
if (!CONFIG_IS_ENABLED(OF_PLATDATA))
|
|
|
|
dm_scan_fdt(false);
|
|
|
|
|
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
|
2021-03-08 00:35:01 +00:00
|
|
|
/**
|
|
|
|
* test_pre_run() - Handle any preparation needed to run a test
|
|
|
|
*
|
|
|
|
* @uts: Test state
|
|
|
|
* @test: Test to prepare for
|
2022-01-19 17:05:50 +00:00
|
|
|
* Return: 0 if OK, -EAGAIN to skip this test since some required feature is not
|
2021-03-08 00:35:01 +00:00
|
|
|
* available, other -ve on error (meaning that testing cannot likely
|
|
|
|
* continue)
|
|
|
|
*/
|
|
|
|
static int test_pre_run(struct unit_test_state *uts, struct unit_test *test)
|
2021-03-08 00:34:48 +00:00
|
|
|
{
|
2022-03-04 15:43:01 +00:00
|
|
|
ut_assertok(event_init());
|
|
|
|
|
2021-03-08 00:34:56 +00:00
|
|
|
if (test->flags & UT_TESTF_DM)
|
2021-03-08 00:34:58 +00:00
|
|
|
ut_assertok(dm_test_pre_run(uts));
|
2021-03-08 00:34:56 +00:00
|
|
|
|
2021-03-08 00:34:55 +00:00
|
|
|
ut_set_skip_delays(uts, false);
|
|
|
|
|
2021-03-08 00:34:53 +00:00
|
|
|
uts->start = mallinfo();
|
2021-03-08 00:34:48 +00:00
|
|
|
|
2022-07-30 21:52:26 +00:00
|
|
|
if (test->flags & UT_TESTF_SCAN_PDATA) {
|
2021-03-08 00:34:52 +00:00
|
|
|
ut_assertok(dm_scan_plat(false));
|
2022-07-30 21:52:26 +00:00
|
|
|
ut_assertok(dm_scan_other(false));
|
|
|
|
}
|
2021-03-08 00:34:52 +00:00
|
|
|
|
2021-03-08 00:34:51 +00:00
|
|
|
if (test->flags & UT_TESTF_PROBE_TEST)
|
|
|
|
ut_assertok(do_autoprobe(uts));
|
|
|
|
|
2021-03-08 00:34:50 +00:00
|
|
|
if (!CONFIG_IS_ENABLED(OF_PLATDATA) &&
|
|
|
|
(test->flags & UT_TESTF_SCAN_FDT))
|
|
|
|
ut_assertok(dm_extended_scan(false));
|
|
|
|
|
2022-09-07 02:27:11 +00:00
|
|
|
if (IS_ENABLED(CONFIG_SANDBOX) && (test->flags & UT_TESTF_OTHER_FDT)) {
|
|
|
|
/* make sure the other FDT is available */
|
|
|
|
ut_assertok(test_load_other_fdt(uts));
|
|
|
|
|
|
|
|
/*
|
|
|
|
* create a new live tree with it for every test, in case a
|
|
|
|
* test modifies the tree
|
|
|
|
*/
|
|
|
|
if (of_live_active()) {
|
|
|
|
ut_assertok(unflatten_device_tree(uts->other_fdt,
|
|
|
|
&uts->of_other));
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2021-03-08 00:34:48 +00:00
|
|
|
if (test->flags & UT_TESTF_CONSOLE_REC) {
|
|
|
|
int ret = console_record_reset_enable();
|
|
|
|
|
|
|
|
if (ret) {
|
|
|
|
printf("Skipping: Console recording disabled\n");
|
|
|
|
return -EAGAIN;
|
|
|
|
}
|
|
|
|
}
|
2021-03-08 00:34:54 +00:00
|
|
|
ut_silence_console(uts);
|
2021-03-08 00:34:48 +00:00
|
|
|
|
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
|
2021-03-08 00:35:01 +00:00
|
|
|
/**
|
|
|
|
* test_post_run() - Handle cleaning up after a test
|
|
|
|
*
|
|
|
|
* @uts: Test state
|
|
|
|
* @test: Test to clean up after
|
2022-01-19 17:05:50 +00:00
|
|
|
* Return: 0 if OK, -ve on error (meaning that testing cannot likely continue)
|
2021-03-08 00:35:01 +00:00
|
|
|
*/
|
|
|
|
static int test_post_run(struct unit_test_state *uts, struct unit_test *test)
|
2021-03-08 00:34:48 +00:00
|
|
|
{
|
2021-03-08 00:34:54 +00:00
|
|
|
ut_unsilence_console(uts);
|
2021-03-08 00:34:59 +00:00
|
|
|
if (test->flags & UT_TESTF_DM)
|
|
|
|
ut_assertok(dm_test_post_run(uts));
|
cyclic: get rid of cyclic_init()
Currently, we must call cyclic_init() at some point before
cyclic_register() becomes possible. That turns out to be somewhat
awkward, especially with SPL, and has resulted in a watchdog callback
not being registered, thus causing the board to prematurely reset.
We already rely on gd->cyclic reliably being set to NULL by the asm
code that clears all of gd. Now that the cyclic list is a hlist, and
thus an empty list is represented by a NULL head pointer, and struct
cyclic_drv has no other members, we can just as well drop a level of
indirection and put the hlist_head directly in struct
global_data. This doesn't increase the size of struct global_data,
gets rid of an early malloc(), and generates slightly smaller code.
But primarily, this avoids having to call cyclic_init() early; the cyclic
infrastructure is simply ready to register callbacks as soon as we
enter C code.
We can still end up with schedule() being called from asm very early,
so we still need to check that gd itself has been properly initialized
[*], but once it has, gd->cyclic_list is perfectly fine to access, and
will just be an empty list.
As for cyclic_uninit(), it was never really the opposite of
cyclic_init() since it didn't free the struct cyclic_drv nor set
gd->cyclic to NULL. Rename it to cyclic_unregister_all() and use that
in test/, and also insert a call at the end of the board_init_f
sequence so that gd->cyclic_list is a fresh empty list before we enter
board_init_r().
A small piece of ugliness is that I had to add a cast in
cyclic_get_list() to silence a "discards 'volatile' qualifier"
warning, but that is completely equivalent to the existing handling of
the uclass_root_s list_head member.
[*] I'm not really sure where we guarantee that the register used for
gd contains 0 until it gets explicitly initialized, but that must be
the case, otherwise testing gd for being NULL would not make much sense.
Signed-off-by: Rasmus Villemoes <rasmus.villemoes@prevas.dk>
Reviewed-by: Stefan Roese <sr@denx.de>
Tested-by: Stefan Roese <sr@denx.de>
Tested-by: Tim Harvey <tharvey@gateworks.com> # imx8mm-venice-*
2022-10-28 11:50:54 +00:00
|
|
|
ut_assertok(cyclic_unregister_all());
|
2022-03-04 15:43:01 +00:00
|
|
|
ut_assertok(event_uninit());
|
2021-03-08 00:34:49 +00:00
|
|
|
|
2022-09-07 02:27:11 +00:00
|
|
|
free(uts->of_other);
|
|
|
|
uts->of_other = NULL;
|
|
|
|
|
2022-10-30 01:47:08 +00:00
|
|
|
blkcache_free();
|
|
|
|
|
2021-03-08 00:34:48 +00:00
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
|
2022-10-21 00:22:48 +00:00
|
|
|
/**
|
|
|
|
* skip_test() - Handle skipping a test
|
|
|
|
*
|
|
|
|
* @uts: Test state to update
|
|
|
|
* @return -EAGAIN (always)
|
|
|
|
*/
|
|
|
|
static int skip_test(struct unit_test_state *uts)
|
|
|
|
{
|
|
|
|
uts->skip_count++;
|
|
|
|
|
|
|
|
return -EAGAIN;
|
|
|
|
}
|
|
|
|
|
2021-03-08 00:35:03 +00:00
|
|
|
/**
|
|
|
|
* ut_run_test() - Run a single test
|
|
|
|
*
|
|
|
|
* This runs the test, handling any preparation and clean-up needed. It prints
|
|
|
|
* the name of each test before running it.
|
|
|
|
*
|
|
|
|
* @uts: Test state to update. The caller should ensure that this is zeroed for
|
|
|
|
* the first call to this function. On exit, @uts->fail_count is
|
|
|
|
* incremented by the number of failures (0, one hopes)
|
|
|
|
* @test_name: Test to run
|
|
|
|
* @name: Name of test, possibly skipping a prefix that should not be displayed
|
2022-01-19 17:05:50 +00:00
|
|
|
* Return: 0 if all tests passed, -EAGAIN if the test should be skipped, -1 if
|
2021-03-08 00:35:03 +00:00
|
|
|
* any failed
|
|
|
|
*/
|
|
|
|
static int ut_run_test(struct unit_test_state *uts, struct unit_test *test,
|
|
|
|
const char *test_name)
|
2021-03-08 00:35:00 +00:00
|
|
|
{
|
2021-03-08 00:35:01 +00:00
|
|
|
const char *fname = strrchr(test->file, '/') + 1;
|
|
|
|
const char *note = "";
|
2021-03-08 00:35:00 +00:00
|
|
|
int ret;
|
|
|
|
|
2021-03-08 00:35:01 +00:00
|
|
|
if ((test->flags & UT_TESTF_DM) && !uts->of_live)
|
|
|
|
note = " (flat tree)";
|
|
|
|
printf("Test: %s: %s%s\n", test_name, fname, note);
|
2021-03-08 00:35:00 +00:00
|
|
|
|
2021-03-08 00:35:04 +00:00
|
|
|
/* Allow access to test state from drivers */
|
|
|
|
test_set_state(uts);
|
|
|
|
|
2021-03-08 00:35:00 +00:00
|
|
|
ret = test_pre_run(uts, test);
|
|
|
|
if (ret == -EAGAIN)
|
2022-10-21 00:22:48 +00:00
|
|
|
return skip_test(uts);
|
2021-03-08 00:35:00 +00:00
|
|
|
if (ret)
|
|
|
|
return ret;
|
|
|
|
|
2022-10-21 00:22:48 +00:00
|
|
|
ret = test->func(uts);
|
|
|
|
if (ret == -EAGAIN)
|
|
|
|
skip_test(uts);
|
2021-03-08 00:35:00 +00:00
|
|
|
|
|
|
|
ret = test_post_run(uts, test);
|
|
|
|
if (ret)
|
|
|
|
return ret;
|
|
|
|
|
2021-03-08 00:35:04 +00:00
|
|
|
test_set_state( NULL);
|
|
|
|
|
2021-03-08 00:35:00 +00:00
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
|
2021-03-08 00:35:05 +00:00
|
|
|
/**
|
|
|
|
* ut_run_test_live_flat() - Run a test with both live and flat tree
|
|
|
|
*
|
|
|
|
* This calls ut_run_test() with livetree enabled, which is the standard setup
|
|
|
|
* for runnig tests. Then, for driver model test, it calls it again with
|
|
|
|
* livetree disabled. This allows checking of flattree being used when OF_LIVE
|
|
|
|
* is enabled, as is the case in U-Boot proper before relocation, as well as in
|
|
|
|
* SPL.
|
|
|
|
*
|
|
|
|
* @uts: Test state to update. The caller should ensure that this is zeroed for
|
|
|
|
* the first call to this function. On exit, @uts->fail_count is
|
|
|
|
* incremented by the number of failures (0, one hopes)
|
|
|
|
* @test: Test to run
|
2022-01-19 17:05:50 +00:00
|
|
|
* Return: 0 if all tests passed, -EAGAIN if the test should be skipped, -1 if
|
2021-03-08 00:35:05 +00:00
|
|
|
* any failed
|
|
|
|
*/
|
|
|
|
static int ut_run_test_live_flat(struct unit_test_state *uts,
|
2022-10-30 01:47:09 +00:00
|
|
|
struct unit_test *test)
|
2021-03-08 00:35:03 +00:00
|
|
|
{
|
|
|
|
int runs;
|
|
|
|
|
2022-09-07 02:27:11 +00:00
|
|
|
if ((test->flags & UT_TESTF_OTHER_FDT) && !IS_ENABLED(CONFIG_SANDBOX))
|
2022-10-21 00:22:48 +00:00
|
|
|
return skip_test(uts);
|
2022-09-07 02:27:11 +00:00
|
|
|
|
2021-03-08 00:35:03 +00:00
|
|
|
/* Run with the live tree if possible */
|
|
|
|
runs = 0;
|
|
|
|
if (CONFIG_IS_ENABLED(OF_LIVE)) {
|
2022-09-07 02:26:59 +00:00
|
|
|
if (!(test->flags & UT_TESTF_FLAT_TREE)) {
|
2021-03-08 00:35:03 +00:00
|
|
|
uts->of_live = true;
|
|
|
|
ut_assertok(ut_run_test(uts, test, test->name));
|
|
|
|
runs++;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
/*
|
2022-09-07 02:27:11 +00:00
|
|
|
* Run with the flat tree if:
|
|
|
|
* - it is not marked for live tree only
|
|
|
|
* - it doesn't require the 'other' FDT when OFNODE_MULTI_TREE_MAX is
|
|
|
|
* not enabled (since flat tree can only support a single FDT in that
|
|
|
|
* case
|
|
|
|
* - we couldn't run it with live tree,
|
|
|
|
* - it is a core test (dm tests except video)
|
|
|
|
* - the FDT is still valid and has not been updated by an earlier test
|
|
|
|
* (for sandbox we handle this by copying the tree, but not for other
|
|
|
|
* boards)
|
2021-03-08 00:35:03 +00:00
|
|
|
*/
|
|
|
|
if (!(test->flags & UT_TESTF_LIVE_TREE) &&
|
2022-09-07 02:27:11 +00:00
|
|
|
(CONFIG_IS_ENABLED(OFNODE_MULTI_TREE) ||
|
|
|
|
!(test->flags & UT_TESTF_OTHER_FDT)) &&
|
2022-09-07 02:27:06 +00:00
|
|
|
(!runs || ut_test_run_on_flattree(test)) &&
|
|
|
|
!(gd->flags & GD_FLG_FDT_CHANGED)) {
|
2021-03-08 00:35:03 +00:00
|
|
|
uts->of_live = false;
|
|
|
|
ut_assertok(ut_run_test(uts, test, test->name));
|
|
|
|
runs++;
|
|
|
|
}
|
|
|
|
|
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
|
2021-03-08 00:35:05 +00:00
|
|
|
/**
|
|
|
|
* ut_run_tests() - Run a set of tests
|
|
|
|
*
|
|
|
|
* This runs the tests, handling any preparation and clean-up needed. It prints
|
|
|
|
* the name of each test before running it.
|
|
|
|
*
|
|
|
|
* @uts: Test state to update. The caller should ensure that this is zeroed for
|
|
|
|
* the first call to this function. On exit, @uts->fail_count is
|
|
|
|
* incremented by the number of failures (0, one hopes)
|
|
|
|
* @prefix: String prefix for the tests. Any tests that have this prefix will be
|
|
|
|
* printed without the prefix, so that it is easier to see the unique part
|
|
|
|
* of the test name. If NULL, no prefix processing is done
|
|
|
|
* @tests: List of tests to run
|
|
|
|
* @count: Number of tests to run
|
|
|
|
* @select_name: Name of a single test to run (from the list provided). If NULL
|
|
|
|
* then all tests are run
|
2022-01-19 17:05:50 +00:00
|
|
|
* Return: 0 if all tests passed, -ENOENT if test @select_name was not found,
|
2021-03-08 00:35:05 +00:00
|
|
|
* -EBADF if any failed
|
|
|
|
*/
|
|
|
|
static int ut_run_tests(struct unit_test_state *uts, const char *prefix,
|
|
|
|
struct unit_test *tests, int count,
|
2022-10-30 01:47:13 +00:00
|
|
|
const char *select_name, const char *test_insert)
|
2021-03-08 00:34:47 +00:00
|
|
|
{
|
2022-10-30 01:47:13 +00:00
|
|
|
struct unit_test *test, *one;
|
2021-03-08 00:34:47 +00:00
|
|
|
int found = 0;
|
2022-10-30 01:47:13 +00:00
|
|
|
int pos = 0;
|
|
|
|
int upto;
|
2021-03-08 00:34:47 +00:00
|
|
|
|
2022-10-30 01:47:13 +00:00
|
|
|
one = NULL;
|
|
|
|
if (test_insert) {
|
|
|
|
char *p;
|
|
|
|
|
|
|
|
pos = dectoul(test_insert, NULL);
|
|
|
|
p = strchr(test_insert, ':');
|
|
|
|
if (p)
|
|
|
|
p++;
|
|
|
|
|
|
|
|
for (test = tests; test < tests + count; test++) {
|
|
|
|
if (!strcmp(p, test->name))
|
|
|
|
one = test;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
for (upto = 0, test = tests; test < tests + count; test++, upto++) {
|
2021-03-08 00:34:47 +00:00
|
|
|
const char *test_name = test->name;
|
2022-08-01 13:58:45 +00:00
|
|
|
int ret, i, old_fail_count;
|
2021-03-08 00:34:47 +00:00
|
|
|
|
2021-03-08 00:35:05 +00:00
|
|
|
if (!test_matches(prefix, test_name, select_name))
|
2021-03-08 00:34:47 +00:00
|
|
|
continue;
|
2022-10-21 00:22:50 +00:00
|
|
|
|
|
|
|
if (test->flags & UT_TESTF_MANUAL) {
|
|
|
|
int len;
|
|
|
|
|
|
|
|
/*
|
|
|
|
* manual tests must have a name ending "_norun" as this
|
|
|
|
* is how pytest knows to skip them. See
|
|
|
|
* generate_ut_subtest() for this check.
|
|
|
|
*/
|
|
|
|
len = strlen(test_name);
|
|
|
|
if (len < 6 || strcmp(test_name + len - 6, "_norun")) {
|
|
|
|
printf("Test %s is manual so must have a name ending in _norun\n",
|
|
|
|
test_name);
|
|
|
|
uts->fail_count++;
|
|
|
|
return -EBADF;
|
|
|
|
}
|
|
|
|
if (!uts->force_run) {
|
|
|
|
if (select_name) {
|
|
|
|
printf("Test %s skipped as it is manual (use -f to run it)\n",
|
|
|
|
test_name);
|
|
|
|
}
|
|
|
|
continue;
|
|
|
|
}
|
|
|
|
}
|
2022-08-01 13:58:45 +00:00
|
|
|
old_fail_count = uts->fail_count;
|
2022-10-30 01:47:13 +00:00
|
|
|
|
|
|
|
if (one && upto == pos) {
|
|
|
|
ret = ut_run_test_live_flat(uts, one);
|
|
|
|
if (uts->fail_count != old_fail_count) {
|
|
|
|
printf("Test %s failed %d times (position %d)\n",
|
|
|
|
one->name,
|
|
|
|
uts->fail_count - old_fail_count, pos);
|
|
|
|
}
|
|
|
|
return -EBADF;
|
|
|
|
}
|
|
|
|
|
2022-08-01 13:58:45 +00:00
|
|
|
for (i = 0; i < uts->runs_per_test; i++)
|
2022-10-30 01:47:09 +00:00
|
|
|
ret = ut_run_test_live_flat(uts, test);
|
2022-08-01 13:58:45 +00:00
|
|
|
if (uts->fail_count != old_fail_count) {
|
|
|
|
printf("Test %s failed %d times\n", select_name,
|
|
|
|
uts->fail_count - old_fail_count);
|
|
|
|
}
|
2021-03-08 00:34:47 +00:00
|
|
|
found++;
|
2021-03-08 00:34:48 +00:00
|
|
|
if (ret == -EAGAIN)
|
|
|
|
continue;
|
|
|
|
if (ret)
|
|
|
|
return ret;
|
2021-03-08 00:34:47 +00:00
|
|
|
}
|
|
|
|
if (select_name && !found)
|
|
|
|
return -ENOENT;
|
|
|
|
|
|
|
|
return uts->fail_count ? -EBADF : 0;
|
|
|
|
}
|
|
|
|
|
|
|
|
int ut_run_list(const char *category, const char *prefix,
|
2022-08-01 13:58:45 +00:00
|
|
|
struct unit_test *tests, int count, const char *select_name,
|
2022-10-30 01:47:13 +00:00
|
|
|
int runs_per_test, bool force_run, const char *test_insert)
|
2021-03-08 00:34:47 +00:00
|
|
|
{
|
|
|
|
struct unit_test_state uts = { .fail_count = 0 };
|
2021-03-08 00:35:08 +00:00
|
|
|
bool has_dm_tests = false;
|
2021-03-08 00:34:47 +00:00
|
|
|
int ret;
|
|
|
|
|
2021-03-08 00:35:07 +00:00
|
|
|
if (!CONFIG_IS_ENABLED(OF_PLATDATA) &&
|
|
|
|
ut_list_has_dm_tests(tests, count)) {
|
2021-03-08 00:35:08 +00:00
|
|
|
has_dm_tests = true;
|
2021-03-08 00:35:07 +00:00
|
|
|
/*
|
|
|
|
* If we have no device tree, or it only has a root node, then
|
|
|
|
* these * tests clearly aren't going to work...
|
|
|
|
*/
|
|
|
|
if (!gd->fdt_blob || fdt_next_node(gd->fdt_blob, 0, NULL) < 0) {
|
|
|
|
puts("Please run with test device tree:\n"
|
|
|
|
" ./u-boot -d arch/sandbox/dts/test.dtb\n");
|
|
|
|
return CMD_RET_FAILURE;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2021-03-08 00:34:47 +00:00
|
|
|
if (!select_name)
|
|
|
|
printf("Running %d %s tests\n", count, category);
|
|
|
|
|
2021-03-08 00:35:05 +00:00
|
|
|
uts.of_root = gd_of_root();
|
2022-08-01 13:58:45 +00:00
|
|
|
uts.runs_per_test = runs_per_test;
|
test: Make a copy of the device tree before running a test
When the flat device tree changes it can mess up the live tree since that
uses the flat tree for its strings. This affects only a few sandbox tests
which modify the device tree, but the number will grow as ofnode support
for writing improves.
While the control FDT is not intended to change while U-Boot is running,
some tests do so. For example, the ofnode interface only supports
modifying properties in the control FDT, so tests must use that.
To solve this problem, keep a copy of the FDT and restore it as needed
when the test is finished. The copy only happens on sandbox (except SPL
builds), to reduce memory usage and because these tests are not useful on
other boards. For other boards, a checksum is taken to ensure that nothing
changes.
It would be possible to always checksum the FDT on sandbox and only
restore it if needed, but this is slightly slower than restoring it every
time, at least with crc8.
Move the code which checks for success to the very end, for clarity.
Signed-off-by: Simon Glass <sjg@chromium.org>
2022-09-07 02:27:05 +00:00
|
|
|
if (fdt_action() == FDTCHK_COPY && gd->fdt_blob) {
|
|
|
|
uts.fdt_size = fdt_totalsize(gd->fdt_blob);
|
|
|
|
uts.fdt_copy = os_malloc(uts.fdt_size);
|
|
|
|
if (!uts.fdt_copy) {
|
|
|
|
printf("Out of memory for device tree copy\n");
|
|
|
|
return -ENOMEM;
|
|
|
|
}
|
|
|
|
memcpy(uts.fdt_copy, gd->fdt_blob, uts.fdt_size);
|
|
|
|
}
|
2022-10-21 00:22:50 +00:00
|
|
|
uts.force_run = force_run;
|
2022-10-30 01:47:13 +00:00
|
|
|
ret = ut_run_tests(&uts, prefix, tests, count, select_name,
|
|
|
|
test_insert);
|
2021-03-08 00:34:47 +00:00
|
|
|
|
test: Make a copy of the device tree before running a test
When the flat device tree changes it can mess up the live tree since that
uses the flat tree for its strings. This affects only a few sandbox tests
which modify the device tree, but the number will grow as ofnode support
for writing improves.
While the control FDT is not intended to change while U-Boot is running,
some tests do so. For example, the ofnode interface only supports
modifying properties in the control FDT, so tests must use that.
To solve this problem, keep a copy of the FDT and restore it as needed
when the test is finished. The copy only happens on sandbox (except SPL
builds), to reduce memory usage and because these tests are not useful on
other boards. For other boards, a checksum is taken to ensure that nothing
changes.
It would be possible to always checksum the FDT on sandbox and only
restore it if needed, but this is slightly slower than restoring it every
time, at least with crc8.
Move the code which checks for success to the very end, for clarity.
Signed-off-by: Simon Glass <sjg@chromium.org>
2022-09-07 02:27:05 +00:00
|
|
|
/* Best efforts only...ignore errors */
|
|
|
|
if (has_dm_tests)
|
|
|
|
dm_test_restore(uts.of_root);
|
2022-09-07 02:27:11 +00:00
|
|
|
if (IS_ENABLED(CONFIG_SANDBOX)) {
|
test: Make a copy of the device tree before running a test
When the flat device tree changes it can mess up the live tree since that
uses the flat tree for its strings. This affects only a few sandbox tests
which modify the device tree, but the number will grow as ofnode support
for writing improves.
While the control FDT is not intended to change while U-Boot is running,
some tests do so. For example, the ofnode interface only supports
modifying properties in the control FDT, so tests must use that.
To solve this problem, keep a copy of the FDT and restore it as needed
when the test is finished. The copy only happens on sandbox (except SPL
builds), to reduce memory usage and because these tests are not useful on
other boards. For other boards, a checksum is taken to ensure that nothing
changes.
It would be possible to always checksum the FDT on sandbox and only
restore it if needed, but this is slightly slower than restoring it every
time, at least with crc8.
Move the code which checks for success to the very end, for clarity.
Signed-off-by: Simon Glass <sjg@chromium.org>
2022-09-07 02:27:05 +00:00
|
|
|
os_free(uts.fdt_copy);
|
2022-09-07 02:27:11 +00:00
|
|
|
os_free(uts.other_fdt);
|
|
|
|
}
|
test: Make a copy of the device tree before running a test
When the flat device tree changes it can mess up the live tree since that
uses the flat tree for its strings. This affects only a few sandbox tests
which modify the device tree, but the number will grow as ofnode support
for writing improves.
While the control FDT is not intended to change while U-Boot is running,
some tests do so. For example, the ofnode interface only supports
modifying properties in the control FDT, so tests must use that.
To solve this problem, keep a copy of the FDT and restore it as needed
when the test is finished. The copy only happens on sandbox (except SPL
builds), to reduce memory usage and because these tests are not useful on
other boards. For other boards, a checksum is taken to ensure that nothing
changes.
It would be possible to always checksum the FDT on sandbox and only
restore it if needed, but this is slightly slower than restoring it every
time, at least with crc8.
Move the code which checks for success to the very end, for clarity.
Signed-off-by: Simon Glass <sjg@chromium.org>
2022-09-07 02:27:05 +00:00
|
|
|
|
2022-10-21 00:22:48 +00:00
|
|
|
if (uts.skip_count)
|
|
|
|
printf("Skipped: %d, ", uts.skip_count);
|
2021-03-08 00:34:47 +00:00
|
|
|
if (ret == -ENOENT)
|
|
|
|
printf("Test '%s' not found\n", select_name);
|
|
|
|
else
|
|
|
|
printf("Failures: %d\n", uts.fail_count);
|
|
|
|
|
2021-03-08 00:35:08 +00:00
|
|
|
/* Best efforts only...ignore errors */
|
|
|
|
if (has_dm_tests)
|
|
|
|
dm_test_restore(uts.of_root);
|
|
|
|
|
2021-03-08 00:34:47 +00:00
|
|
|
return ret;
|
|
|
|
}
|