2021-01-25 12:23:55 +00:00
|
|
|
// SPDX-License-Identifier: GPL-2.0+ OR BSD-3-Clause
|
|
|
|
/*
|
|
|
|
* Felix (VSC9959) Ethernet switch driver
|
2021-09-17 11:27:13 +00:00
|
|
|
* Copyright 2018-2021 NXP
|
2021-01-25 12:23:55 +00:00
|
|
|
*/
|
|
|
|
|
|
|
|
/*
|
|
|
|
* This driver is used for the Ethernet switch integrated into NXP LS1028A.
|
|
|
|
* Felix switch is derived from Microsemi Ocelot but there are several NXP
|
|
|
|
* adaptations that makes the two U-Boot drivers largely incompatible.
|
|
|
|
*
|
|
|
|
* Felix on LS1028A has 4 front panel ports and two internal ports, connected
|
|
|
|
* to ENETC interfaces. We're using one of the ENETC interfaces to push traffic
|
|
|
|
* into the switch. Injection/extraction headers are used to identify
|
|
|
|
* egress/ingress ports in the switch for Tx/Rx.
|
|
|
|
*/
|
|
|
|
|
|
|
|
#include <dm/device_compat.h>
|
|
|
|
#include <linux/delay.h>
|
|
|
|
#include <net/dsa.h>
|
|
|
|
#include <asm/io.h>
|
|
|
|
#include <miiphy.h>
|
|
|
|
#include <pci.h>
|
|
|
|
|
|
|
|
/* defines especially around PCS are reused from enetc */
|
|
|
|
#include "../fsl_enetc.h"
|
|
|
|
|
|
|
|
#define PCI_DEVICE_ID_FELIX_ETHSW 0xEEF0
|
|
|
|
|
|
|
|
/* Felix has in fact 6 ports, but we don't use the last internal one */
|
|
|
|
#define FELIX_PORT_COUNT 5
|
|
|
|
/* Front panel port mask */
|
|
|
|
#define FELIX_FP_PORT_MASK 0xf
|
|
|
|
|
|
|
|
/* Register map for BAR4 */
|
|
|
|
#define FELIX_SYS 0x010000
|
|
|
|
#define FELIX_ES0 0x040000
|
|
|
|
#define FELIX_IS1 0x050000
|
|
|
|
#define FELIX_IS2 0x060000
|
|
|
|
#define FELIX_GMII(port) (0x100000 + (port) * 0x10000)
|
|
|
|
#define FELIX_QSYS 0x200000
|
|
|
|
|
|
|
|
#define FELIX_SYS_SYSTEM (FELIX_SYS + 0x00000E00)
|
|
|
|
#define FELIX_SYS_SYSTEM_EN BIT(0)
|
|
|
|
#define FELIX_SYS_RAM_CTRL (FELIX_SYS + 0x00000F24)
|
|
|
|
#define FELIX_SYS_RAM_CTRL_INIT BIT(1)
|
|
|
|
#define FELIX_SYS_SYSTEM_PORT_MODE(a) (FELIX_SYS_SYSTEM + 0xC + (a) * 4)
|
|
|
|
#define FELIX_SYS_SYSTEM_PORT_MODE_CPU 0x0000001e
|
|
|
|
|
|
|
|
#define FELIX_ES0_TCAM_CTRL (FELIX_ES0 + 0x000003C0)
|
|
|
|
#define FELIX_ES0_TCAM_CTRL_EN BIT(0)
|
|
|
|
#define FELIX_IS1_TCAM_CTRL (FELIX_IS1 + 0x000003C0)
|
|
|
|
#define FELIX_IS1_TCAM_CTRL_EN BIT(0)
|
|
|
|
#define FELIX_IS2_TCAM_CTRL (FELIX_IS2 + 0x000003C0)
|
|
|
|
#define FELIX_IS2_TCAM_CTRL_EN BIT(0)
|
|
|
|
|
|
|
|
#define FELIX_GMII_CLOCK_CFG(port) (FELIX_GMII(port) + 0x00000000)
|
|
|
|
#define FELIX_GMII_CLOCK_CFG_LINK_1G 1
|
|
|
|
#define FELIX_GMII_CLOCK_CFG_LINK_100M 2
|
|
|
|
#define FELIX_GMII_CLOCK_CFG_LINK_10M 3
|
|
|
|
#define FELIX_GMII_MAC_ENA_CFG(port) (FELIX_GMII(port) + 0x0000001C)
|
|
|
|
#define FELIX_GMII_MAX_ENA_CFG_TX BIT(0)
|
|
|
|
#define FELIX_GMII_MAX_ENA_CFG_RX BIT(4)
|
|
|
|
#define FELIX_GMII_MAC_IFG_CFG(port) (FELIX_GMII(port) + 0x0000001C + 0x14)
|
|
|
|
#define FELIX_GMII_MAC_IFG_CFG_DEF 0x515
|
|
|
|
|
|
|
|
#define FELIX_QSYS_SYSTEM (FELIX_QSYS + 0x0000F460)
|
|
|
|
#define FELIX_QSYS_SYSTEM_SW_PORT_MODE(a) \
|
|
|
|
(FELIX_QSYS_SYSTEM + 0x20 + (a) * 4)
|
|
|
|
#define FELIX_QSYS_SYSTEM_SW_PORT_ENA BIT(14)
|
|
|
|
#define FELIX_QSYS_SYSTEM_SW_PORT_LOSSY BIT(9)
|
|
|
|
#define FELIX_QSYS_SYSTEM_SW_PORT_SCH(a) (((a) & 0x3800) << 11)
|
|
|
|
#define FELIX_QSYS_SYSTEM_EXT_CPU_CFG (FELIX_QSYS_SYSTEM + 0x80)
|
|
|
|
#define FELIX_QSYS_SYSTEM_EXT_CPU_PORT(a) (((a) & 0xf) << 8 | 0xff)
|
|
|
|
|
|
|
|
/* internal MDIO in BAR0 */
|
|
|
|
#define FELIX_PM_IMDIO_BASE 0x8030
|
|
|
|
|
|
|
|
/* Serdes block on LS1028A */
|
|
|
|
#define FELIX_SERDES_BASE 0x1ea0000L
|
|
|
|
#define FELIX_SERDES_LNATECR0(lane) (FELIX_SERDES_BASE + 0x818 + \
|
|
|
|
(lane) * 0x40)
|
|
|
|
#define FELIX_SERDES_LNATECR0_ADPT_EQ 0x00003000
|
|
|
|
#define FELIX_SERDES_SGMIICR1(lane) (FELIX_SERDES_BASE + 0x1804 + \
|
|
|
|
(lane) * 0x10)
|
|
|
|
#define FELIX_SERDES_SGMIICR1_SGPCS BIT(11)
|
|
|
|
#define FELIX_SERDES_SGMIICR1_MDEV(a) (((a) & 0x1f) << 27)
|
|
|
|
|
|
|
|
#define FELIX_PCS_CTRL 0
|
|
|
|
#define FELIX_PCS_CTRL_RST BIT(15)
|
|
|
|
|
|
|
|
/*
|
|
|
|
* The long prefix format used here contains two dummy MAC addresses, a magic
|
|
|
|
* value in place of a VLAN tag followed by the extraction/injection header and
|
|
|
|
* the original L2 frame. Out of all this we only use the port ID.
|
|
|
|
*/
|
|
|
|
#define FELIX_DSA_TAG_LEN sizeof(struct felix_dsa_tag)
|
|
|
|
#define FELIX_DSA_TAG_MAGIC 0x0a008088
|
|
|
|
#define FELIX_DSA_TAG_INJ_PORT 7
|
|
|
|
#define FELIX_DSA_TAG_INJ_PORT_SET(a) (0x1 << ((a) & FELIX_FP_PORT_MASK))
|
|
|
|
#define FELIX_DSA_TAG_EXT_PORT 10
|
|
|
|
#define FELIX_DSA_TAG_EXT_PORT_GET(a) ((a) >> 3)
|
|
|
|
|
|
|
|
struct felix_dsa_tag {
|
|
|
|
uchar d_mac[6];
|
|
|
|
uchar s_mac[6];
|
|
|
|
u32 magic;
|
|
|
|
uchar meta[16];
|
|
|
|
};
|
|
|
|
|
|
|
|
struct felix_priv {
|
|
|
|
void *regs_base;
|
|
|
|
void *imdio_base;
|
|
|
|
struct mii_dev imdio;
|
|
|
|
};
|
|
|
|
|
|
|
|
/* MDIO wrappers, we're using these to drive internal MDIO to get to serdes */
|
|
|
|
static int felix_mdio_read(struct mii_dev *bus, int addr, int devad, int reg)
|
|
|
|
{
|
|
|
|
struct enetc_mdio_priv priv;
|
|
|
|
|
|
|
|
priv.regs_base = bus->priv;
|
|
|
|
return enetc_mdio_read_priv(&priv, addr, devad, reg);
|
|
|
|
}
|
|
|
|
|
|
|
|
static int felix_mdio_write(struct mii_dev *bus, int addr, int devad, int reg,
|
|
|
|
u16 val)
|
|
|
|
{
|
|
|
|
struct enetc_mdio_priv priv;
|
|
|
|
|
|
|
|
priv.regs_base = bus->priv;
|
|
|
|
return enetc_mdio_write_priv(&priv, addr, devad, reg, val);
|
|
|
|
}
|
|
|
|
|
|
|
|
/* set up serdes for SGMII */
|
|
|
|
static void felix_init_sgmii(struct mii_dev *imdio, int pidx, bool an)
|
|
|
|
{
|
|
|
|
u16 reg;
|
|
|
|
|
|
|
|
/* set up PCS lane address */
|
|
|
|
out_le32(FELIX_SERDES_SGMIICR1(pidx), FELIX_SERDES_SGMIICR1_SGPCS |
|
|
|
|
FELIX_SERDES_SGMIICR1_MDEV(pidx));
|
|
|
|
|
|
|
|
/*
|
|
|
|
* Set to SGMII mode, for 1Gbps enable AN, for 2.5Gbps set fixed speed.
|
|
|
|
* Although fixed speed is 1Gbps, we could be running at 2.5Gbps based
|
|
|
|
* on PLL configuration. Setting 1G for 2.5G here is counter intuitive
|
|
|
|
* but intentional.
|
|
|
|
*/
|
|
|
|
reg = ENETC_PCS_IF_MODE_SGMII;
|
|
|
|
reg |= an ? ENETC_PCS_IF_MODE_SGMII_AN : ENETC_PCS_IF_MODE_SPEED_1G;
|
|
|
|
felix_mdio_write(imdio, pidx, MDIO_DEVAD_NONE,
|
|
|
|
ENETC_PCS_IF_MODE, reg);
|
|
|
|
|
|
|
|
/* Dev ability - SGMII */
|
|
|
|
felix_mdio_write(imdio, pidx, MDIO_DEVAD_NONE,
|
|
|
|
ENETC_PCS_DEV_ABILITY, ENETC_PCS_DEV_ABILITY_SGMII);
|
|
|
|
|
|
|
|
/* Adjust link timer for SGMII */
|
|
|
|
felix_mdio_write(imdio, pidx, MDIO_DEVAD_NONE,
|
|
|
|
ENETC_PCS_LINK_TIMER1, ENETC_PCS_LINK_TIMER1_VAL);
|
|
|
|
felix_mdio_write(imdio, pidx, MDIO_DEVAD_NONE,
|
|
|
|
ENETC_PCS_LINK_TIMER2, ENETC_PCS_LINK_TIMER2_VAL);
|
|
|
|
|
|
|
|
reg = ENETC_PCS_CR_DEF_VAL;
|
|
|
|
reg |= an ? ENETC_PCS_CR_RESET_AN : ENETC_PCS_CR_RST;
|
|
|
|
/* restart PCS AN */
|
|
|
|
felix_mdio_write(imdio, pidx, MDIO_DEVAD_NONE,
|
|
|
|
ENETC_PCS_CR, reg);
|
|
|
|
}
|
|
|
|
|
|
|
|
/* set up MAC and serdes for (Q)SXGMII */
|
|
|
|
static int felix_init_sxgmii(struct mii_dev *imdio, int pidx)
|
|
|
|
{
|
|
|
|
int timeout = 1000;
|
|
|
|
|
|
|
|
/* set up transit equalization control on serdes lane */
|
|
|
|
out_le32(FELIX_SERDES_LNATECR0(1), FELIX_SERDES_LNATECR0_ADPT_EQ);
|
|
|
|
|
|
|
|
/*reset lane */
|
|
|
|
felix_mdio_write(imdio, pidx, MDIO_MMD_PCS, FELIX_PCS_CTRL,
|
|
|
|
FELIX_PCS_CTRL_RST);
|
|
|
|
while (felix_mdio_read(imdio, pidx, MDIO_MMD_PCS,
|
|
|
|
FELIX_PCS_CTRL) & FELIX_PCS_CTRL_RST &&
|
|
|
|
--timeout) {
|
|
|
|
mdelay(10);
|
|
|
|
}
|
|
|
|
if (felix_mdio_read(imdio, pidx, MDIO_MMD_PCS,
|
|
|
|
FELIX_PCS_CTRL) & FELIX_PCS_CTRL_RST)
|
|
|
|
return -ETIME;
|
|
|
|
|
|
|
|
/* Dev ability - SXGMII */
|
|
|
|
felix_mdio_write(imdio, pidx, ENETC_PCS_DEVAD_REPL,
|
|
|
|
ENETC_PCS_DEV_ABILITY, ENETC_PCS_DEV_ABILITY_SXGMII);
|
|
|
|
|
|
|
|
/* Restart PCS AN */
|
|
|
|
felix_mdio_write(imdio, pidx, ENETC_PCS_DEVAD_REPL, ENETC_PCS_CR,
|
|
|
|
ENETC_PCS_CR_RST | ENETC_PCS_CR_RESET_AN);
|
|
|
|
felix_mdio_write(imdio, pidx, ENETC_PCS_DEVAD_REPL,
|
|
|
|
ENETC_PCS_REPL_LINK_TIMER_1,
|
|
|
|
ENETC_PCS_REPL_LINK_TIMER_1_DEF);
|
|
|
|
felix_mdio_write(imdio, pidx, ENETC_PCS_DEVAD_REPL,
|
|
|
|
ENETC_PCS_REPL_LINK_TIMER_2,
|
|
|
|
ENETC_PCS_REPL_LINK_TIMER_2_DEF);
|
|
|
|
|
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
|
|
|
|
/* Apply protocol specific configuration to MAC, serdes as needed */
|
|
|
|
static void felix_start_pcs(struct udevice *dev, int port,
|
|
|
|
struct phy_device *phy, struct mii_dev *imdio)
|
|
|
|
{
|
|
|
|
bool autoneg = true;
|
|
|
|
|
|
|
|
if (phy->phy_id == PHY_FIXED_ID ||
|
net: freescale: replace usage of phy-mode = "sgmii-2500" with "2500base-x"
After the discussion here:
https://lore.kernel.org/netdev/20210603143453.if7hgifupx5k433b@pali/
which resulted in this patch:
https://patchwork.kernel.org/project/netdevbpf/patch/20210704134325.24842-1-pali@kernel.org/
and many other discussions before it, notably:
https://patchwork.kernel.org/project/linux-arm-kernel/patch/1512016235-15909-1-git-send-email-Bhaskar.Upadhaya@nxp.com/
it became apparent that nobody really knows what "SGMII 2500" is.
Certainly, Freescale/NXP hardware engineers name this protocol
"SGMII 2500" in the reference manuals, but the PCS devices do not
support any "SGMII" specific features when operating at the speed of
2500 Mbps, no in-band autoneg and no speed change via symbol replication
. So that leaves a fixed speed of 2500 Mbps using a coding of 8b/10b
with a SERDES lane frequency of 3.125 GHz. In fact, "SGMII 2500 without
in-band autoneg and at a fixed speed" is indistinguishable from
"2500base-x without in-band autoneg", which is precisely what these NXP
devices support.
So it just appears that "SGMII 2500" is an unclear name with no clear
definition that stuck.
As such, in the Linux kernel, the drivers which use this SERDES protocol
use the 2500base-x phy-mode.
This patch converts U-Boot to use 2500base-x too, or at least, as much
as it can.
Note that I would have really liked to delete PHY_INTERFACE_MODE_SGMII_2500
completely, but the mvpp2 driver seems to even distinguish between SGMII
2500 and 2500base-X. Namely, it enables in-band autoneg for one but not
the other, and forces flow control for one but not the other. This goes
back to the idea that maybe 2500base-X is a fiber protocol and SGMII-2500
is an MII protocol (connects a MAC to a PHY such as Aquantia), but the
two are practically indistinguishable through everything except use case.
NXP devices can support both use cases through an identical configuration,
for example RX flow control can be unconditionally enabled in order to
support rate adaptation performed by an Aquantia PHY. At least I can
find no indication in online documents published by Cisco which would
point towards "SGMII-2500" being an actual standard with an actual
definition, so I cannot say "yes, NXP devices support it".
Signed-off-by: Vladimir Oltean <vladimir.oltean@nxp.com>
Reviewed-by: Ramon Fried <rfried.dev@gmail.com>
2021-09-18 12:32:35 +00:00
|
|
|
phy->interface == PHY_INTERFACE_MODE_2500BASEX)
|
2021-01-25 12:23:55 +00:00
|
|
|
autoneg = false;
|
|
|
|
|
|
|
|
switch (phy->interface) {
|
|
|
|
case PHY_INTERFACE_MODE_SGMII:
|
net: freescale: replace usage of phy-mode = "sgmii-2500" with "2500base-x"
After the discussion here:
https://lore.kernel.org/netdev/20210603143453.if7hgifupx5k433b@pali/
which resulted in this patch:
https://patchwork.kernel.org/project/netdevbpf/patch/20210704134325.24842-1-pali@kernel.org/
and many other discussions before it, notably:
https://patchwork.kernel.org/project/linux-arm-kernel/patch/1512016235-15909-1-git-send-email-Bhaskar.Upadhaya@nxp.com/
it became apparent that nobody really knows what "SGMII 2500" is.
Certainly, Freescale/NXP hardware engineers name this protocol
"SGMII 2500" in the reference manuals, but the PCS devices do not
support any "SGMII" specific features when operating at the speed of
2500 Mbps, no in-band autoneg and no speed change via symbol replication
. So that leaves a fixed speed of 2500 Mbps using a coding of 8b/10b
with a SERDES lane frequency of 3.125 GHz. In fact, "SGMII 2500 without
in-band autoneg and at a fixed speed" is indistinguishable from
"2500base-x without in-band autoneg", which is precisely what these NXP
devices support.
So it just appears that "SGMII 2500" is an unclear name with no clear
definition that stuck.
As such, in the Linux kernel, the drivers which use this SERDES protocol
use the 2500base-x phy-mode.
This patch converts U-Boot to use 2500base-x too, or at least, as much
as it can.
Note that I would have really liked to delete PHY_INTERFACE_MODE_SGMII_2500
completely, but the mvpp2 driver seems to even distinguish between SGMII
2500 and 2500base-X. Namely, it enables in-band autoneg for one but not
the other, and forces flow control for one but not the other. This goes
back to the idea that maybe 2500base-X is a fiber protocol and SGMII-2500
is an MII protocol (connects a MAC to a PHY such as Aquantia), but the
two are practically indistinguishable through everything except use case.
NXP devices can support both use cases through an identical configuration,
for example RX flow control can be unconditionally enabled in order to
support rate adaptation performed by an Aquantia PHY. At least I can
find no indication in online documents published by Cisco which would
point towards "SGMII-2500" being an actual standard with an actual
definition, so I cannot say "yes, NXP devices support it".
Signed-off-by: Vladimir Oltean <vladimir.oltean@nxp.com>
Reviewed-by: Ramon Fried <rfried.dev@gmail.com>
2021-09-18 12:32:35 +00:00
|
|
|
case PHY_INTERFACE_MODE_2500BASEX:
|
2021-01-25 12:23:55 +00:00
|
|
|
case PHY_INTERFACE_MODE_QSGMII:
|
|
|
|
felix_init_sgmii(imdio, port, autoneg);
|
|
|
|
break;
|
2021-09-18 12:32:34 +00:00
|
|
|
case PHY_INTERFACE_MODE_10GBASER:
|
2021-01-25 12:23:55 +00:00
|
|
|
case PHY_INTERFACE_MODE_USXGMII:
|
|
|
|
if (felix_init_sxgmii(imdio, port))
|
|
|
|
dev_err(dev, "PCS reset timeout on port %d\n", port);
|
|
|
|
break;
|
|
|
|
default:
|
|
|
|
break;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2021-08-24 12:00:38 +00:00
|
|
|
static void felix_init(struct udevice *dev)
|
2021-01-25 12:23:55 +00:00
|
|
|
{
|
|
|
|
struct dsa_pdata *pdata = dev_get_uclass_plat(dev);
|
|
|
|
struct felix_priv *priv = dev_get_priv(dev);
|
|
|
|
void *base = priv->regs_base;
|
|
|
|
int timeout = 100;
|
|
|
|
|
|
|
|
/* Init core memories */
|
|
|
|
out_le32(base + FELIX_SYS_RAM_CTRL, FELIX_SYS_RAM_CTRL_INIT);
|
|
|
|
while (in_le32(base + FELIX_SYS_RAM_CTRL) & FELIX_SYS_RAM_CTRL_INIT &&
|
|
|
|
--timeout)
|
|
|
|
udelay(10);
|
|
|
|
if (in_le32(base + FELIX_SYS_RAM_CTRL) & FELIX_SYS_RAM_CTRL_INIT)
|
|
|
|
dev_err(dev, "Timeout waiting for switch memories\n");
|
|
|
|
|
|
|
|
/* Start switch core, set up ES0, IS1, IS2 */
|
|
|
|
out_le32(base + FELIX_SYS_SYSTEM, FELIX_SYS_SYSTEM_EN);
|
|
|
|
out_le32(base + FELIX_ES0_TCAM_CTRL, FELIX_ES0_TCAM_CTRL_EN);
|
|
|
|
out_le32(base + FELIX_IS1_TCAM_CTRL, FELIX_IS1_TCAM_CTRL_EN);
|
|
|
|
out_le32(base + FELIX_IS2_TCAM_CTRL, FELIX_IS2_TCAM_CTRL_EN);
|
|
|
|
udelay(20);
|
|
|
|
|
|
|
|
priv->imdio.read = felix_mdio_read;
|
|
|
|
priv->imdio.write = felix_mdio_write;
|
|
|
|
priv->imdio.priv = priv->imdio_base + FELIX_PM_IMDIO_BASE;
|
2021-09-27 11:21:54 +00:00
|
|
|
strlcpy(priv->imdio.name, dev->name, MDIO_NAME_LEN);
|
2021-01-25 12:23:55 +00:00
|
|
|
|
|
|
|
/* set up CPU port */
|
|
|
|
out_le32(base + FELIX_QSYS_SYSTEM_EXT_CPU_CFG,
|
|
|
|
FELIX_QSYS_SYSTEM_EXT_CPU_PORT(pdata->cpu_port));
|
|
|
|
out_le32(base + FELIX_SYS_SYSTEM_PORT_MODE(pdata->cpu_port),
|
|
|
|
FELIX_SYS_SYSTEM_PORT_MODE_CPU);
|
|
|
|
}
|
|
|
|
|
|
|
|
/*
|
|
|
|
* Probe Felix:
|
|
|
|
* - enable the PCI function
|
|
|
|
* - map BAR 4
|
|
|
|
* - init switch core and port registers
|
|
|
|
*/
|
|
|
|
static int felix_probe(struct udevice *dev)
|
|
|
|
{
|
|
|
|
struct felix_priv *priv = dev_get_priv(dev);
|
2021-09-27 11:22:02 +00:00
|
|
|
int err;
|
2021-01-25 12:23:55 +00:00
|
|
|
|
|
|
|
if (ofnode_valid(dev_ofnode(dev)) &&
|
|
|
|
!ofnode_is_available(dev_ofnode(dev))) {
|
|
|
|
dev_dbg(dev, "switch disabled\n");
|
|
|
|
return -ENODEV;
|
|
|
|
}
|
|
|
|
|
|
|
|
priv->imdio_base = dm_pci_map_bar(dev, PCI_BASE_ADDRESS_0, 0);
|
|
|
|
if (!priv->imdio_base) {
|
|
|
|
dev_err(dev, "failed to map BAR0\n");
|
|
|
|
return -EINVAL;
|
|
|
|
}
|
|
|
|
|
|
|
|
priv->regs_base = dm_pci_map_bar(dev, PCI_BASE_ADDRESS_4, 0);
|
|
|
|
if (!priv->regs_base) {
|
|
|
|
dev_err(dev, "failed to map BAR4\n");
|
|
|
|
return -EINVAL;
|
|
|
|
}
|
|
|
|
|
|
|
|
/* register internal MDIO for debug */
|
|
|
|
if (!miiphy_get_dev_by_name(dev->name)) {
|
|
|
|
struct mii_dev *mii_bus;
|
|
|
|
|
|
|
|
mii_bus = mdio_alloc();
|
2021-09-27 11:22:02 +00:00
|
|
|
if (!mii_bus)
|
|
|
|
return -ENOMEM;
|
|
|
|
|
2021-01-25 12:23:55 +00:00
|
|
|
mii_bus->read = felix_mdio_read;
|
|
|
|
mii_bus->write = felix_mdio_write;
|
|
|
|
mii_bus->priv = priv->imdio_base + FELIX_PM_IMDIO_BASE;
|
2021-09-27 11:21:54 +00:00
|
|
|
strlcpy(mii_bus->name, dev->name, MDIO_NAME_LEN);
|
2021-09-27 11:22:02 +00:00
|
|
|
err = mdio_register(mii_bus);
|
|
|
|
if (err) {
|
|
|
|
mdio_free(mii_bus);
|
|
|
|
return err;
|
|
|
|
}
|
2021-01-25 12:23:55 +00:00
|
|
|
}
|
|
|
|
|
|
|
|
dm_pci_clrset_config16(dev, PCI_COMMAND, 0, PCI_COMMAND_MEMORY);
|
|
|
|
|
|
|
|
dsa_set_tagging(dev, FELIX_DSA_TAG_LEN, 0);
|
|
|
|
|
|
|
|
/* set up registers */
|
|
|
|
felix_init(dev);
|
|
|
|
|
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
|
net: dsa: felix: call phy_config at .port_probe() time
It is an unfortunate reality that some PHY settings done by U-Boot
persist even after the PHY is reset and taken over by Linux, and even
more unfortunate that Linux has come to depend on things being set in a
certain way.
For example, on the NXP LS1028A-RDB, the felix switch ports are
connected to a VSC8514 QSGMII PHY. Between the switch port PCS and the
PHY, the U-Boot drivers enable in-band auto-negotiation which makes the
copper-side negotiated speed and duplex be transmitted from the PHY to
the MAC automatically.
The PHY driver portion that does this is in vsc8514_config():
/* Enable Serdes Auto-negotiation */
phy_write(phydev, MDIO_DEVAD_NONE, PHY_EXT_PAGE_ACCESS,
PHY_EXT_PAGE_ACCESS_EXTENDED3);
val = phy_read(phydev, MDIO_DEVAD_NONE, MIIM_VSC8514_MAC_SERDES_CON);
val = val | MIIM_VSC8574_MAC_SERDES_ANEG;
phy_write(phydev, MDIO_DEVAD_NONE, MIIM_VSC8514_MAC_SERDES_CON, val);
The point is that in-band autoneg should be turned on in both the PHY
and the MAC, or off in both the PHY and the MAC, otherwise the QSGMII
link will be broken.
And because phy_config() is currently called at .port_enable() time, the
result is that ports on which traffic has been sent in U-Boot will have
in-band autoneg enabled, and the rest won't.
It can be argued that the Linux kernel should not assume one way or
another and just reinitialize everything according to what it expects,
and that is completely fair. In fact, I've already started an attempt to
remove this dependency, although admittedly I am making slow progress at
it:
https://patchwork.kernel.org/project/netdevbpf/cover/20210212172341.3489046-1-olteanv@gmail.com/
Nonetheless, the sad reality is that NXP also has, apart from kernel
drivers, some user space networking (DPDK), and for some reason, the
expectation there is that somebody else initializes the PHYs. The kernel
can't do it because the device ownership doesn't belong to the kernel,
so what remains is for the bootloader to do it (especially since other
drivers generally call phy_config() at probe time). This is a really
weak guarantee that might break at any time, but apparently that is
enough for some.
Since initializing the ports and PHYs at probe time does not break
anything, we can just do that.
Signed-off-by: Vladimir Oltean <vladimir.oltean@nxp.com>
Reviewed-by: Ramon Fried <rfried.dev@gmail.com>
Tested-by: Michael Walle <michael@walle.cc>
2021-08-24 12:00:42 +00:00
|
|
|
static int felix_port_probe(struct udevice *dev, int port,
|
|
|
|
struct phy_device *phy)
|
|
|
|
{
|
|
|
|
int supported = PHY_GBIT_FEATURES | SUPPORTED_2500baseX_Full;
|
|
|
|
struct felix_priv *priv = dev_get_priv(dev);
|
|
|
|
|
|
|
|
phy->supported &= supported;
|
|
|
|
phy->advertising &= supported;
|
|
|
|
|
|
|
|
felix_start_pcs(dev, port, phy, &priv->imdio);
|
|
|
|
|
|
|
|
return phy_config(phy);
|
|
|
|
}
|
|
|
|
|
2021-01-25 12:23:55 +00:00
|
|
|
static int felix_port_enable(struct udevice *dev, int port,
|
|
|
|
struct phy_device *phy)
|
|
|
|
{
|
|
|
|
struct felix_priv *priv = dev_get_priv(dev);
|
|
|
|
void *base = priv->regs_base;
|
|
|
|
|
|
|
|
/* Set up MAC registers */
|
|
|
|
out_le32(base + FELIX_GMII_CLOCK_CFG(port),
|
|
|
|
FELIX_GMII_CLOCK_CFG_LINK_1G);
|
|
|
|
|
|
|
|
out_le32(base + FELIX_GMII_MAC_IFG_CFG(port),
|
|
|
|
FELIX_GMII_MAC_IFG_CFG_DEF);
|
|
|
|
|
|
|
|
out_le32(base + FELIX_GMII_MAC_ENA_CFG(port),
|
|
|
|
FELIX_GMII_MAX_ENA_CFG_TX | FELIX_GMII_MAX_ENA_CFG_RX);
|
|
|
|
|
|
|
|
out_le32(base + FELIX_QSYS_SYSTEM_SW_PORT_MODE(port),
|
|
|
|
FELIX_QSYS_SYSTEM_SW_PORT_ENA |
|
|
|
|
FELIX_QSYS_SYSTEM_SW_PORT_LOSSY |
|
|
|
|
FELIX_QSYS_SYSTEM_SW_PORT_SCH(1));
|
|
|
|
|
2021-08-24 12:00:43 +00:00
|
|
|
return phy_startup(phy);
|
2021-01-25 12:23:55 +00:00
|
|
|
}
|
|
|
|
|
|
|
|
static void felix_port_disable(struct udevice *dev, int pidx,
|
|
|
|
struct phy_device *phy)
|
|
|
|
{
|
|
|
|
struct felix_priv *priv = dev_get_priv(dev);
|
|
|
|
void *base = priv->regs_base;
|
|
|
|
|
|
|
|
out_le32(base + FELIX_GMII_MAC_ENA_CFG(pidx), 0);
|
|
|
|
|
|
|
|
out_le32(base + FELIX_QSYS_SYSTEM_SW_PORT_MODE(pidx),
|
|
|
|
FELIX_QSYS_SYSTEM_SW_PORT_LOSSY |
|
|
|
|
FELIX_QSYS_SYSTEM_SW_PORT_SCH(1));
|
|
|
|
|
|
|
|
/*
|
|
|
|
* we don't call phy_shutdown here to avoid waiting next time we use
|
|
|
|
* the port, but the downside is that remote side will think we're
|
|
|
|
* actively processing traffic although we are not.
|
|
|
|
*/
|
|
|
|
}
|
|
|
|
|
|
|
|
static int felix_xmit(struct udevice *dev, int pidx, void *packet, int length)
|
|
|
|
{
|
|
|
|
struct felix_dsa_tag *tag = packet;
|
|
|
|
|
|
|
|
tag->magic = FELIX_DSA_TAG_MAGIC;
|
|
|
|
tag->meta[FELIX_DSA_TAG_INJ_PORT] = FELIX_DSA_TAG_INJ_PORT_SET(pidx);
|
|
|
|
|
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
|
|
|
|
static int felix_rcv(struct udevice *dev, int *pidx, void *packet, int length)
|
|
|
|
{
|
|
|
|
struct felix_dsa_tag *tag = packet;
|
|
|
|
|
|
|
|
if (tag->magic != FELIX_DSA_TAG_MAGIC)
|
|
|
|
return -EINVAL;
|
|
|
|
|
|
|
|
*pidx = FELIX_DSA_TAG_EXT_PORT_GET(tag->meta[FELIX_DSA_TAG_EXT_PORT]);
|
|
|
|
|
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
|
|
|
|
static const struct dsa_ops felix_dsa_ops = {
|
net: dsa: felix: call phy_config at .port_probe() time
It is an unfortunate reality that some PHY settings done by U-Boot
persist even after the PHY is reset and taken over by Linux, and even
more unfortunate that Linux has come to depend on things being set in a
certain way.
For example, on the NXP LS1028A-RDB, the felix switch ports are
connected to a VSC8514 QSGMII PHY. Between the switch port PCS and the
PHY, the U-Boot drivers enable in-band auto-negotiation which makes the
copper-side negotiated speed and duplex be transmitted from the PHY to
the MAC automatically.
The PHY driver portion that does this is in vsc8514_config():
/* Enable Serdes Auto-negotiation */
phy_write(phydev, MDIO_DEVAD_NONE, PHY_EXT_PAGE_ACCESS,
PHY_EXT_PAGE_ACCESS_EXTENDED3);
val = phy_read(phydev, MDIO_DEVAD_NONE, MIIM_VSC8514_MAC_SERDES_CON);
val = val | MIIM_VSC8574_MAC_SERDES_ANEG;
phy_write(phydev, MDIO_DEVAD_NONE, MIIM_VSC8514_MAC_SERDES_CON, val);
The point is that in-band autoneg should be turned on in both the PHY
and the MAC, or off in both the PHY and the MAC, otherwise the QSGMII
link will be broken.
And because phy_config() is currently called at .port_enable() time, the
result is that ports on which traffic has been sent in U-Boot will have
in-band autoneg enabled, and the rest won't.
It can be argued that the Linux kernel should not assume one way or
another and just reinitialize everything according to what it expects,
and that is completely fair. In fact, I've already started an attempt to
remove this dependency, although admittedly I am making slow progress at
it:
https://patchwork.kernel.org/project/netdevbpf/cover/20210212172341.3489046-1-olteanv@gmail.com/
Nonetheless, the sad reality is that NXP also has, apart from kernel
drivers, some user space networking (DPDK), and for some reason, the
expectation there is that somebody else initializes the PHYs. The kernel
can't do it because the device ownership doesn't belong to the kernel,
so what remains is for the bootloader to do it (especially since other
drivers generally call phy_config() at probe time). This is a really
weak guarantee that might break at any time, but apparently that is
enough for some.
Since initializing the ports and PHYs at probe time does not break
anything, we can just do that.
Signed-off-by: Vladimir Oltean <vladimir.oltean@nxp.com>
Reviewed-by: Ramon Fried <rfried.dev@gmail.com>
Tested-by: Michael Walle <michael@walle.cc>
2021-08-24 12:00:42 +00:00
|
|
|
.port_probe = felix_port_probe,
|
2021-01-25 12:23:55 +00:00
|
|
|
.port_enable = felix_port_enable,
|
|
|
|
.port_disable = felix_port_disable,
|
|
|
|
.xmit = felix_xmit,
|
|
|
|
.rcv = felix_rcv,
|
|
|
|
};
|
|
|
|
|
|
|
|
U_BOOT_DRIVER(felix_ethsw) = {
|
|
|
|
.name = "felix-switch",
|
|
|
|
.id = UCLASS_DSA,
|
|
|
|
.probe = felix_probe,
|
|
|
|
.ops = &felix_dsa_ops,
|
|
|
|
.priv_auto = sizeof(struct felix_priv),
|
|
|
|
};
|
|
|
|
|
|
|
|
static struct pci_device_id felix_ethsw_ids[] = {
|
|
|
|
{ PCI_DEVICE(PCI_VENDOR_ID_FREESCALE, PCI_DEVICE_ID_FELIX_ETHSW) },
|
|
|
|
{}
|
|
|
|
};
|
|
|
|
|
|
|
|
U_BOOT_PCI_DEVICE(felix_ethsw, felix_ethsw_ids);
|