2018-05-06 21:58:06 +00:00
|
|
|
// SPDX-License-Identifier: GPL-2.0+
|
2011-11-08 23:18:14 +00:00
|
|
|
/*
|
|
|
|
* Freescale i.MX28 SPI driver
|
|
|
|
*
|
|
|
|
* Copyright (C) 2011 Marek Vasut <marek.vasut@gmail.com>
|
|
|
|
* on behalf of DENX Software Engineering GmbH
|
|
|
|
*
|
|
|
|
* NOTE: This driver only supports the SPI-controller chipselects,
|
|
|
|
* GPIO driven chipselects are not supported.
|
|
|
|
*/
|
|
|
|
|
|
|
|
#include <common.h>
|
|
|
|
#include <malloc.h>
|
2015-09-02 23:24:58 +00:00
|
|
|
#include <memalign.h>
|
2011-11-08 23:18:14 +00:00
|
|
|
#include <spi.h>
|
2016-09-21 02:28:55 +00:00
|
|
|
#include <linux/errno.h>
|
2011-11-08 23:18:14 +00:00
|
|
|
#include <asm/io.h>
|
|
|
|
#include <asm/arch/clock.h>
|
|
|
|
#include <asm/arch/imx-regs.h>
|
|
|
|
#include <asm/arch/sys_proto.h>
|
2017-06-29 08:16:06 +00:00
|
|
|
#include <asm/mach-imx/dma.h>
|
2011-11-08 23:18:14 +00:00
|
|
|
|
|
|
|
#define MXS_SPI_MAX_TIMEOUT 1000000
|
|
|
|
#define MXS_SPI_PORT_OFFSET 0x2000
|
2012-04-23 08:30:50 +00:00
|
|
|
#define MXS_SSP_CHIPSELECT_MASK 0x00300000
|
|
|
|
#define MXS_SSP_CHIPSELECT_SHIFT 20
|
2011-11-08 23:18:14 +00:00
|
|
|
|
2012-07-09 00:48:33 +00:00
|
|
|
#define MXSSSP_SMALL_TRANSFER 512
|
|
|
|
|
2011-11-08 23:18:14 +00:00
|
|
|
struct mxs_spi_slave {
|
|
|
|
struct spi_slave slave;
|
|
|
|
uint32_t max_khz;
|
|
|
|
uint32_t mode;
|
2012-08-05 09:05:31 +00:00
|
|
|
struct mxs_ssp_regs *regs;
|
2011-11-08 23:18:14 +00:00
|
|
|
};
|
|
|
|
|
|
|
|
static inline struct mxs_spi_slave *to_mxs_slave(struct spi_slave *slave)
|
|
|
|
{
|
|
|
|
return container_of(slave, struct mxs_spi_slave, slave);
|
|
|
|
}
|
|
|
|
|
2012-04-23 08:30:49 +00:00
|
|
|
int spi_cs_is_valid(unsigned int bus, unsigned int cs)
|
|
|
|
{
|
|
|
|
/* MXS SPI: 4 ports and 3 chip selects maximum */
|
mxs: mmc: spi: dma: Better wrap the MXS differences
This patch streamlines the differences between the MX23 and MX28 by
implementing a few helper functions to handle different DMA channel
mapping, different clock domain for SSP block and fixes a few minor
bugs.
First of all, the DMA channel mapping is now fixed in dma.h by defining
the actual channel map for both MX23 and MX28. Thus, MX23 now does no
longer use MX28 channel map which was wrong. Also, there is a fix for
MX28 DMA channel map, where the last four channels were incorrect.
Next, because correct DMA channel map is in place, the mxs_dma_init_channel()
call now bases the channel ID starting from SSP port #0. This removes the
need for DMA channel offset being added and cleans up the code. For the
same reason, the SSP0 offset can now be used in mxs_dma_desc_append(), thus
no need to adjust dma channel number in the driver either.
Lastly, the SSP clock ID is now retrieved by calling mxs_ssp_clock_by_bus()
which handles the fact that MX23 has shared SSP clock for both ports, while
MX28 has per-port SSP clock.
Finally, the mxs_ssp_bus_id_valid() pulls out two implementations of the
same functionality from MMC and SPI driver into common code.
Signed-off-by: Marek Vasut <marex@denx.de>
Cc: Fabio Estevam <fabio.estevam@freescale.com>
Cc: Otavio Salvador <otavio@ossystems.com.br>
Cc: Stefano Babic <sbabic@denx.de>
2013-02-23 02:42:58 +00:00
|
|
|
if (!mxs_ssp_bus_id_valid(bus) || cs > 2)
|
2012-04-23 08:30:49 +00:00
|
|
|
return 0;
|
|
|
|
else
|
|
|
|
return 1;
|
|
|
|
}
|
|
|
|
|
2011-11-08 23:18:14 +00:00
|
|
|
struct spi_slave *spi_setup_slave(unsigned int bus, unsigned int cs,
|
|
|
|
unsigned int max_hz, unsigned int mode)
|
|
|
|
{
|
|
|
|
struct mxs_spi_slave *mxs_slave;
|
|
|
|
|
2012-04-23 08:30:49 +00:00
|
|
|
if (!spi_cs_is_valid(bus, cs)) {
|
|
|
|
printf("mxs_spi: invalid bus %d / chip select %d\n", bus, cs);
|
2011-11-08 23:18:14 +00:00
|
|
|
return NULL;
|
|
|
|
}
|
|
|
|
|
2013-03-18 19:23:40 +00:00
|
|
|
mxs_slave = spi_alloc_slave(struct mxs_spi_slave, bus, cs);
|
2011-11-08 23:18:14 +00:00
|
|
|
if (!mxs_slave)
|
|
|
|
return NULL;
|
|
|
|
|
mxs: mmc: spi: dma: Better wrap the MXS differences
This patch streamlines the differences between the MX23 and MX28 by
implementing a few helper functions to handle different DMA channel
mapping, different clock domain for SSP block and fixes a few minor
bugs.
First of all, the DMA channel mapping is now fixed in dma.h by defining
the actual channel map for both MX23 and MX28. Thus, MX23 now does no
longer use MX28 channel map which was wrong. Also, there is a fix for
MX28 DMA channel map, where the last four channels were incorrect.
Next, because correct DMA channel map is in place, the mxs_dma_init_channel()
call now bases the channel ID starting from SSP port #0. This removes the
need for DMA channel offset being added and cleans up the code. For the
same reason, the SSP0 offset can now be used in mxs_dma_desc_append(), thus
no need to adjust dma channel number in the driver either.
Lastly, the SSP clock ID is now retrieved by calling mxs_ssp_clock_by_bus()
which handles the fact that MX23 has shared SSP clock for both ports, while
MX28 has per-port SSP clock.
Finally, the mxs_ssp_bus_id_valid() pulls out two implementations of the
same functionality from MMC and SPI driver into common code.
Signed-off-by: Marek Vasut <marex@denx.de>
Cc: Fabio Estevam <fabio.estevam@freescale.com>
Cc: Otavio Salvador <otavio@ossystems.com.br>
Cc: Stefano Babic <sbabic@denx.de>
2013-02-23 02:42:58 +00:00
|
|
|
if (mxs_dma_init_channel(MXS_DMA_CHANNEL_AHB_APBH_SSP0 + bus))
|
2012-07-09 00:48:33 +00:00
|
|
|
goto err_init;
|
|
|
|
|
2011-11-08 23:18:14 +00:00
|
|
|
mxs_slave->max_khz = max_hz / 1000;
|
|
|
|
mxs_slave->mode = mode;
|
2013-01-11 03:19:02 +00:00
|
|
|
mxs_slave->regs = mxs_ssp_regs_by_bus(bus);
|
2011-11-08 23:18:14 +00:00
|
|
|
|
|
|
|
return &mxs_slave->slave;
|
2012-07-09 00:48:33 +00:00
|
|
|
|
|
|
|
err_init:
|
|
|
|
free(mxs_slave);
|
|
|
|
return NULL;
|
2011-11-08 23:18:14 +00:00
|
|
|
}
|
|
|
|
|
|
|
|
void spi_free_slave(struct spi_slave *slave)
|
|
|
|
{
|
|
|
|
struct mxs_spi_slave *mxs_slave = to_mxs_slave(slave);
|
|
|
|
free(mxs_slave);
|
|
|
|
}
|
|
|
|
|
|
|
|
int spi_claim_bus(struct spi_slave *slave)
|
|
|
|
{
|
|
|
|
struct mxs_spi_slave *mxs_slave = to_mxs_slave(slave);
|
2012-08-05 09:05:31 +00:00
|
|
|
struct mxs_ssp_regs *ssp_regs = mxs_slave->regs;
|
2011-11-08 23:18:14 +00:00
|
|
|
uint32_t reg = 0;
|
|
|
|
|
2012-08-13 09:53:12 +00:00
|
|
|
mxs_reset_block(&ssp_regs->hw_ssp_ctrl0_reg);
|
2011-11-08 23:18:14 +00:00
|
|
|
|
2013-08-26 15:45:23 +00:00
|
|
|
writel((slave->cs << MXS_SSP_CHIPSELECT_SHIFT) |
|
|
|
|
SSP_CTRL0_BUS_WIDTH_ONE_BIT,
|
|
|
|
&ssp_regs->hw_ssp_ctrl0);
|
2011-11-08 23:18:14 +00:00
|
|
|
|
|
|
|
reg = SSP_CTRL1_SSP_MODE_SPI | SSP_CTRL1_WORD_LENGTH_EIGHT_BITS;
|
|
|
|
reg |= (mxs_slave->mode & SPI_CPOL) ? SSP_CTRL1_POLARITY : 0;
|
|
|
|
reg |= (mxs_slave->mode & SPI_CPHA) ? SSP_CTRL1_PHASE : 0;
|
|
|
|
writel(reg, &ssp_regs->hw_ssp_ctrl1);
|
|
|
|
|
|
|
|
writel(0, &ssp_regs->hw_ssp_cmd0);
|
|
|
|
|
2013-01-11 03:19:03 +00:00
|
|
|
mxs_set_ssp_busclock(slave->bus, mxs_slave->max_khz);
|
2011-11-08 23:18:14 +00:00
|
|
|
|
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
|
|
|
|
void spi_release_bus(struct spi_slave *slave)
|
|
|
|
{
|
|
|
|
}
|
|
|
|
|
2012-08-05 09:05:31 +00:00
|
|
|
static void mxs_spi_start_xfer(struct mxs_ssp_regs *ssp_regs)
|
2011-11-08 23:18:14 +00:00
|
|
|
{
|
|
|
|
writel(SSP_CTRL0_LOCK_CS, &ssp_regs->hw_ssp_ctrl0_set);
|
|
|
|
writel(SSP_CTRL0_IGNORE_CRC, &ssp_regs->hw_ssp_ctrl0_clr);
|
|
|
|
}
|
|
|
|
|
2012-08-05 09:05:31 +00:00
|
|
|
static void mxs_spi_end_xfer(struct mxs_ssp_regs *ssp_regs)
|
2011-11-08 23:18:14 +00:00
|
|
|
{
|
|
|
|
writel(SSP_CTRL0_LOCK_CS, &ssp_regs->hw_ssp_ctrl0_clr);
|
|
|
|
writel(SSP_CTRL0_IGNORE_CRC, &ssp_regs->hw_ssp_ctrl0_set);
|
|
|
|
}
|
|
|
|
|
2012-07-09 00:48:32 +00:00
|
|
|
static int mxs_spi_xfer_pio(struct mxs_spi_slave *slave,
|
|
|
|
char *data, int length, int write, unsigned long flags)
|
2011-11-08 23:18:14 +00:00
|
|
|
{
|
2012-08-05 09:05:31 +00:00
|
|
|
struct mxs_ssp_regs *ssp_regs = slave->regs;
|
2012-07-09 00:48:31 +00:00
|
|
|
|
2011-11-08 23:18:14 +00:00
|
|
|
if (flags & SPI_XFER_BEGIN)
|
|
|
|
mxs_spi_start_xfer(ssp_regs);
|
|
|
|
|
2012-07-09 00:48:32 +00:00
|
|
|
while (length--) {
|
2011-11-08 23:18:14 +00:00
|
|
|
/* We transfer 1 byte */
|
2013-02-23 02:42:59 +00:00
|
|
|
#if defined(CONFIG_MX23)
|
|
|
|
writel(SSP_CTRL0_XFER_COUNT_MASK, &ssp_regs->hw_ssp_ctrl0_clr);
|
|
|
|
writel(1, &ssp_regs->hw_ssp_ctrl0_set);
|
|
|
|
#elif defined(CONFIG_MX28)
|
2011-11-08 23:18:14 +00:00
|
|
|
writel(1, &ssp_regs->hw_ssp_xfer_size);
|
2013-02-23 02:42:59 +00:00
|
|
|
#endif
|
2011-11-08 23:18:14 +00:00
|
|
|
|
2012-07-09 00:48:32 +00:00
|
|
|
if ((flags & SPI_XFER_END) && !length)
|
2011-11-08 23:18:14 +00:00
|
|
|
mxs_spi_end_xfer(ssp_regs);
|
|
|
|
|
2012-07-09 00:48:31 +00:00
|
|
|
if (write)
|
2011-11-08 23:18:14 +00:00
|
|
|
writel(SSP_CTRL0_READ, &ssp_regs->hw_ssp_ctrl0_clr);
|
|
|
|
else
|
|
|
|
writel(SSP_CTRL0_READ, &ssp_regs->hw_ssp_ctrl0_set);
|
|
|
|
|
|
|
|
writel(SSP_CTRL0_RUN, &ssp_regs->hw_ssp_ctrl0_set);
|
|
|
|
|
2012-08-13 09:53:12 +00:00
|
|
|
if (mxs_wait_mask_set(&ssp_regs->hw_ssp_ctrl0_reg,
|
2011-11-08 23:18:14 +00:00
|
|
|
SSP_CTRL0_RUN, MXS_SPI_MAX_TIMEOUT)) {
|
|
|
|
printf("MXS SPI: Timeout waiting for start\n");
|
2012-03-18 17:23:35 +00:00
|
|
|
return -ETIMEDOUT;
|
2011-11-08 23:18:14 +00:00
|
|
|
}
|
|
|
|
|
2012-07-09 00:48:31 +00:00
|
|
|
if (write)
|
|
|
|
writel(*data++, &ssp_regs->hw_ssp_data);
|
2011-11-08 23:18:14 +00:00
|
|
|
|
|
|
|
writel(SSP_CTRL0_DATA_XFER, &ssp_regs->hw_ssp_ctrl0_set);
|
|
|
|
|
2012-07-09 00:48:31 +00:00
|
|
|
if (!write) {
|
2012-08-13 09:53:12 +00:00
|
|
|
if (mxs_wait_mask_clr(&ssp_regs->hw_ssp_status_reg,
|
2011-11-08 23:18:14 +00:00
|
|
|
SSP_STATUS_FIFO_EMPTY, MXS_SPI_MAX_TIMEOUT)) {
|
|
|
|
printf("MXS SPI: Timeout waiting for data\n");
|
2012-03-18 17:23:35 +00:00
|
|
|
return -ETIMEDOUT;
|
2011-11-08 23:18:14 +00:00
|
|
|
}
|
|
|
|
|
2012-07-09 00:48:31 +00:00
|
|
|
*data = readl(&ssp_regs->hw_ssp_data);
|
|
|
|
data++;
|
2011-11-08 23:18:14 +00:00
|
|
|
}
|
|
|
|
|
2012-08-13 09:53:12 +00:00
|
|
|
if (mxs_wait_mask_clr(&ssp_regs->hw_ssp_ctrl0_reg,
|
2011-11-08 23:18:14 +00:00
|
|
|
SSP_CTRL0_RUN, MXS_SPI_MAX_TIMEOUT)) {
|
|
|
|
printf("MXS SPI: Timeout waiting for finish\n");
|
2012-03-18 17:23:35 +00:00
|
|
|
return -ETIMEDOUT;
|
2011-11-08 23:18:14 +00:00
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
return 0;
|
2012-07-09 00:48:32 +00:00
|
|
|
}
|
|
|
|
|
2012-07-09 00:48:33 +00:00
|
|
|
static int mxs_spi_xfer_dma(struct mxs_spi_slave *slave,
|
|
|
|
char *data, int length, int write, unsigned long flags)
|
|
|
|
{
|
2012-08-21 16:17:27 +00:00
|
|
|
const int xfer_max_sz = 0xff00;
|
|
|
|
const int desc_count = DIV_ROUND_UP(length, xfer_max_sz) + 1;
|
2012-08-05 09:05:31 +00:00
|
|
|
struct mxs_ssp_regs *ssp_regs = slave->regs;
|
2012-08-21 16:17:27 +00:00
|
|
|
struct mxs_dma_desc *dp;
|
|
|
|
uint32_t ctrl0;
|
2012-07-09 00:48:33 +00:00
|
|
|
uint32_t cache_data_count;
|
2012-08-31 16:07:59 +00:00
|
|
|
const uint32_t dstart = (uint32_t)data;
|
2012-07-09 00:48:33 +00:00
|
|
|
int dmach;
|
2012-08-21 16:17:27 +00:00
|
|
|
int tl;
|
MX28: SPI: Fix the DMA chaining
It turns out that in order for the SPI DMA to properly support
continuous transfers longer than 65280 bytes, there are some very
important parts that were left out from the documentation.
Firstly, the XFER_SIZE register is not written with the whole length
of a transfer, but is written by each and every chained descriptor
with the length of the descriptors data buffer.
Next, unlike the demo code supplied by FSL, which only writes one PIO
word per descriptor, this does not apply if the descriptors are chained,
since the XFER_SIZE register must be written. Therefore, it is essential
to use four PIO words, CTRL0, CMD0, CMD1, XFER_SIZE. CMD0 and CMD1 are
written with zero, since they don't apply. The DMA programs the PIO words
in an incrementing order, so four PIO words.
Finally, unlike the demo code supplied by FSL, the SSP_CTRL0_IGNORE_CRC
must not be set during the whole transfer, but it must be set only on the
last descriptor in the chain.
Signed-off-by: Marek Vasut <marex@denx.de>
Cc: Fabio Estevam <festevam@gmail.com>
Cc: Otavio Salvador <otavio@ossystems.com.br>
Cc: Stefano Babic <sbabic@denx.de>
2012-08-31 16:08:00 +00:00
|
|
|
int ret = 0;
|
2012-08-21 16:17:27 +00:00
|
|
|
|
2013-02-23 02:42:59 +00:00
|
|
|
#if defined(CONFIG_MX23)
|
|
|
|
const int mxs_spi_pio_words = 1;
|
|
|
|
#elif defined(CONFIG_MX28)
|
|
|
|
const int mxs_spi_pio_words = 4;
|
|
|
|
#endif
|
|
|
|
|
2012-08-21 16:17:27 +00:00
|
|
|
ALLOC_CACHE_ALIGN_BUFFER(struct mxs_dma_desc, desc, desc_count);
|
|
|
|
|
|
|
|
memset(desc, 0, sizeof(struct mxs_dma_desc) * desc_count);
|
2012-07-09 00:48:33 +00:00
|
|
|
|
2012-08-21 16:17:27 +00:00
|
|
|
ctrl0 = readl(&ssp_regs->hw_ssp_ctrl0);
|
|
|
|
ctrl0 |= SSP_CTRL0_DATA_XFER;
|
2012-07-09 00:48:33 +00:00
|
|
|
|
|
|
|
if (flags & SPI_XFER_BEGIN)
|
|
|
|
ctrl0 |= SSP_CTRL0_LOCK_CS;
|
|
|
|
if (!write)
|
|
|
|
ctrl0 |= SSP_CTRL0_READ;
|
|
|
|
|
|
|
|
if (length % ARCH_DMA_MINALIGN)
|
|
|
|
cache_data_count = roundup(length, ARCH_DMA_MINALIGN);
|
|
|
|
else
|
|
|
|
cache_data_count = length;
|
|
|
|
|
2012-08-31 16:07:59 +00:00
|
|
|
/* Flush data to DRAM so DMA can pick them up */
|
2012-08-21 16:17:27 +00:00
|
|
|
if (write)
|
2012-08-31 16:07:59 +00:00
|
|
|
flush_dcache_range(dstart, dstart + cache_data_count);
|
|
|
|
|
|
|
|
/* Invalidate the area, so no writeback into the RAM races with DMA */
|
|
|
|
invalidate_dcache_range(dstart, dstart + cache_data_count);
|
2012-07-09 00:48:33 +00:00
|
|
|
|
2012-08-21 16:17:27 +00:00
|
|
|
dmach = MXS_DMA_CHANNEL_AHB_APBH_SSP0 + slave->slave.bus;
|
|
|
|
|
|
|
|
dp = desc;
|
|
|
|
while (length) {
|
|
|
|
dp->address = (dma_addr_t)dp;
|
|
|
|
dp->cmd.address = (dma_addr_t)data;
|
|
|
|
|
|
|
|
/*
|
|
|
|
* This is correct, even though it does indeed look insane.
|
|
|
|
* I hereby have to, wholeheartedly, thank Freescale Inc.,
|
|
|
|
* for always inventing insane hardware and keeping me busy
|
|
|
|
* and employed ;-)
|
|
|
|
*/
|
|
|
|
if (write)
|
|
|
|
dp->cmd.data = MXS_DMA_DESC_COMMAND_DMA_READ;
|
|
|
|
else
|
|
|
|
dp->cmd.data = MXS_DMA_DESC_COMMAND_DMA_WRITE;
|
|
|
|
|
|
|
|
/*
|
|
|
|
* The DMA controller can transfer large chunks (64kB) at
|
|
|
|
* time by setting the transfer length to 0. Setting tl to
|
|
|
|
* 0x10000 will overflow below and make .data contain 0.
|
|
|
|
* Otherwise, 0xff00 is the transfer maximum.
|
|
|
|
*/
|
|
|
|
if (length >= 0x10000)
|
|
|
|
tl = 0x10000;
|
|
|
|
else
|
|
|
|
tl = min(length, xfer_max_sz);
|
|
|
|
|
|
|
|
dp->cmd.data |=
|
MX28: SPI: Fix the DMA chaining
It turns out that in order for the SPI DMA to properly support
continuous transfers longer than 65280 bytes, there are some very
important parts that were left out from the documentation.
Firstly, the XFER_SIZE register is not written with the whole length
of a transfer, but is written by each and every chained descriptor
with the length of the descriptors data buffer.
Next, unlike the demo code supplied by FSL, which only writes one PIO
word per descriptor, this does not apply if the descriptors are chained,
since the XFER_SIZE register must be written. Therefore, it is essential
to use four PIO words, CTRL0, CMD0, CMD1, XFER_SIZE. CMD0 and CMD1 are
written with zero, since they don't apply. The DMA programs the PIO words
in an incrementing order, so four PIO words.
Finally, unlike the demo code supplied by FSL, the SSP_CTRL0_IGNORE_CRC
must not be set during the whole transfer, but it must be set only on the
last descriptor in the chain.
Signed-off-by: Marek Vasut <marex@denx.de>
Cc: Fabio Estevam <festevam@gmail.com>
Cc: Otavio Salvador <otavio@ossystems.com.br>
Cc: Stefano Babic <sbabic@denx.de>
2012-08-31 16:08:00 +00:00
|
|
|
((tl & 0xffff) << MXS_DMA_DESC_BYTES_OFFSET) |
|
2013-02-23 02:42:59 +00:00
|
|
|
(mxs_spi_pio_words << MXS_DMA_DESC_PIO_WORDS_OFFSET) |
|
2012-08-21 16:17:27 +00:00
|
|
|
MXS_DMA_DESC_HALT_ON_TERMINATE |
|
|
|
|
MXS_DMA_DESC_TERMINATE_FLUSH;
|
2012-07-09 00:48:33 +00:00
|
|
|
|
2012-08-21 16:17:27 +00:00
|
|
|
data += tl;
|
|
|
|
length -= tl;
|
|
|
|
|
MX28: SPI: Fix the DMA chaining
It turns out that in order for the SPI DMA to properly support
continuous transfers longer than 65280 bytes, there are some very
important parts that were left out from the documentation.
Firstly, the XFER_SIZE register is not written with the whole length
of a transfer, but is written by each and every chained descriptor
with the length of the descriptors data buffer.
Next, unlike the demo code supplied by FSL, which only writes one PIO
word per descriptor, this does not apply if the descriptors are chained,
since the XFER_SIZE register must be written. Therefore, it is essential
to use four PIO words, CTRL0, CMD0, CMD1, XFER_SIZE. CMD0 and CMD1 are
written with zero, since they don't apply. The DMA programs the PIO words
in an incrementing order, so four PIO words.
Finally, unlike the demo code supplied by FSL, the SSP_CTRL0_IGNORE_CRC
must not be set during the whole transfer, but it must be set only on the
last descriptor in the chain.
Signed-off-by: Marek Vasut <marex@denx.de>
Cc: Fabio Estevam <festevam@gmail.com>
Cc: Otavio Salvador <otavio@ossystems.com.br>
Cc: Stefano Babic <sbabic@denx.de>
2012-08-31 16:08:00 +00:00
|
|
|
if (!length) {
|
|
|
|
dp->cmd.data |= MXS_DMA_DESC_IRQ | MXS_DMA_DESC_DEC_SEM;
|
|
|
|
|
|
|
|
if (flags & SPI_XFER_END) {
|
|
|
|
ctrl0 &= ~SSP_CTRL0_LOCK_CS;
|
|
|
|
ctrl0 |= SSP_CTRL0_IGNORE_CRC;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
/*
|
2013-02-23 02:42:59 +00:00
|
|
|
* Write CTRL0, CMD0, CMD1 and XFER_SIZE registers in
|
|
|
|
* case of MX28, write only CTRL0 in case of MX23 due
|
|
|
|
* to the difference in register layout. It is utterly
|
MX28: SPI: Fix the DMA chaining
It turns out that in order for the SPI DMA to properly support
continuous transfers longer than 65280 bytes, there are some very
important parts that were left out from the documentation.
Firstly, the XFER_SIZE register is not written with the whole length
of a transfer, but is written by each and every chained descriptor
with the length of the descriptors data buffer.
Next, unlike the demo code supplied by FSL, which only writes one PIO
word per descriptor, this does not apply if the descriptors are chained,
since the XFER_SIZE register must be written. Therefore, it is essential
to use four PIO words, CTRL0, CMD0, CMD1, XFER_SIZE. CMD0 and CMD1 are
written with zero, since they don't apply. The DMA programs the PIO words
in an incrementing order, so four PIO words.
Finally, unlike the demo code supplied by FSL, the SSP_CTRL0_IGNORE_CRC
must not be set during the whole transfer, but it must be set only on the
last descriptor in the chain.
Signed-off-by: Marek Vasut <marex@denx.de>
Cc: Fabio Estevam <festevam@gmail.com>
Cc: Otavio Salvador <otavio@ossystems.com.br>
Cc: Stefano Babic <sbabic@denx.de>
2012-08-31 16:08:00 +00:00
|
|
|
* essential that the XFER_SIZE register is written on
|
|
|
|
* a per-descriptor basis with the same size as is the
|
|
|
|
* descriptor!
|
|
|
|
*/
|
|
|
|
dp->cmd.pio_words[0] = ctrl0;
|
2013-02-23 02:42:59 +00:00
|
|
|
#ifdef CONFIG_MX28
|
MX28: SPI: Fix the DMA chaining
It turns out that in order for the SPI DMA to properly support
continuous transfers longer than 65280 bytes, there are some very
important parts that were left out from the documentation.
Firstly, the XFER_SIZE register is not written with the whole length
of a transfer, but is written by each and every chained descriptor
with the length of the descriptors data buffer.
Next, unlike the demo code supplied by FSL, which only writes one PIO
word per descriptor, this does not apply if the descriptors are chained,
since the XFER_SIZE register must be written. Therefore, it is essential
to use four PIO words, CTRL0, CMD0, CMD1, XFER_SIZE. CMD0 and CMD1 are
written with zero, since they don't apply. The DMA programs the PIO words
in an incrementing order, so four PIO words.
Finally, unlike the demo code supplied by FSL, the SSP_CTRL0_IGNORE_CRC
must not be set during the whole transfer, but it must be set only on the
last descriptor in the chain.
Signed-off-by: Marek Vasut <marex@denx.de>
Cc: Fabio Estevam <festevam@gmail.com>
Cc: Otavio Salvador <otavio@ossystems.com.br>
Cc: Stefano Babic <sbabic@denx.de>
2012-08-31 16:08:00 +00:00
|
|
|
dp->cmd.pio_words[1] = 0;
|
|
|
|
dp->cmd.pio_words[2] = 0;
|
|
|
|
dp->cmd.pio_words[3] = tl;
|
2013-02-23 02:42:59 +00:00
|
|
|
#endif
|
MX28: SPI: Fix the DMA chaining
It turns out that in order for the SPI DMA to properly support
continuous transfers longer than 65280 bytes, there are some very
important parts that were left out from the documentation.
Firstly, the XFER_SIZE register is not written with the whole length
of a transfer, but is written by each and every chained descriptor
with the length of the descriptors data buffer.
Next, unlike the demo code supplied by FSL, which only writes one PIO
word per descriptor, this does not apply if the descriptors are chained,
since the XFER_SIZE register must be written. Therefore, it is essential
to use four PIO words, CTRL0, CMD0, CMD1, XFER_SIZE. CMD0 and CMD1 are
written with zero, since they don't apply. The DMA programs the PIO words
in an incrementing order, so four PIO words.
Finally, unlike the demo code supplied by FSL, the SSP_CTRL0_IGNORE_CRC
must not be set during the whole transfer, but it must be set only on the
last descriptor in the chain.
Signed-off-by: Marek Vasut <marex@denx.de>
Cc: Fabio Estevam <festevam@gmail.com>
Cc: Otavio Salvador <otavio@ossystems.com.br>
Cc: Stefano Babic <sbabic@denx.de>
2012-08-31 16:08:00 +00:00
|
|
|
|
2012-08-21 16:17:27 +00:00
|
|
|
mxs_dma_desc_append(dmach, dp);
|
|
|
|
|
|
|
|
dp++;
|
|
|
|
}
|
|
|
|
|
2012-07-09 00:48:33 +00:00
|
|
|
if (mxs_dma_go(dmach))
|
MX28: SPI: Fix the DMA chaining
It turns out that in order for the SPI DMA to properly support
continuous transfers longer than 65280 bytes, there are some very
important parts that were left out from the documentation.
Firstly, the XFER_SIZE register is not written with the whole length
of a transfer, but is written by each and every chained descriptor
with the length of the descriptors data buffer.
Next, unlike the demo code supplied by FSL, which only writes one PIO
word per descriptor, this does not apply if the descriptors are chained,
since the XFER_SIZE register must be written. Therefore, it is essential
to use four PIO words, CTRL0, CMD0, CMD1, XFER_SIZE. CMD0 and CMD1 are
written with zero, since they don't apply. The DMA programs the PIO words
in an incrementing order, so four PIO words.
Finally, unlike the demo code supplied by FSL, the SSP_CTRL0_IGNORE_CRC
must not be set during the whole transfer, but it must be set only on the
last descriptor in the chain.
Signed-off-by: Marek Vasut <marex@denx.de>
Cc: Fabio Estevam <festevam@gmail.com>
Cc: Otavio Salvador <otavio@ossystems.com.br>
Cc: Stefano Babic <sbabic@denx.de>
2012-08-31 16:08:00 +00:00
|
|
|
ret = -EINVAL;
|
2012-07-09 00:48:33 +00:00
|
|
|
|
|
|
|
/* The data arrived into DRAM, invalidate cache over them */
|
2012-08-31 16:07:59 +00:00
|
|
|
if (!write)
|
|
|
|
invalidate_dcache_range(dstart, dstart + cache_data_count);
|
2012-07-09 00:48:33 +00:00
|
|
|
|
MX28: SPI: Fix the DMA chaining
It turns out that in order for the SPI DMA to properly support
continuous transfers longer than 65280 bytes, there are some very
important parts that were left out from the documentation.
Firstly, the XFER_SIZE register is not written with the whole length
of a transfer, but is written by each and every chained descriptor
with the length of the descriptors data buffer.
Next, unlike the demo code supplied by FSL, which only writes one PIO
word per descriptor, this does not apply if the descriptors are chained,
since the XFER_SIZE register must be written. Therefore, it is essential
to use four PIO words, CTRL0, CMD0, CMD1, XFER_SIZE. CMD0 and CMD1 are
written with zero, since they don't apply. The DMA programs the PIO words
in an incrementing order, so four PIO words.
Finally, unlike the demo code supplied by FSL, the SSP_CTRL0_IGNORE_CRC
must not be set during the whole transfer, but it must be set only on the
last descriptor in the chain.
Signed-off-by: Marek Vasut <marex@denx.de>
Cc: Fabio Estevam <festevam@gmail.com>
Cc: Otavio Salvador <otavio@ossystems.com.br>
Cc: Stefano Babic <sbabic@denx.de>
2012-08-31 16:08:00 +00:00
|
|
|
return ret;
|
2012-07-09 00:48:33 +00:00
|
|
|
}
|
|
|
|
|
2012-07-09 00:48:32 +00:00
|
|
|
int spi_xfer(struct spi_slave *slave, unsigned int bitlen,
|
|
|
|
const void *dout, void *din, unsigned long flags)
|
|
|
|
{
|
|
|
|
struct mxs_spi_slave *mxs_slave = to_mxs_slave(slave);
|
2012-08-05 09:05:31 +00:00
|
|
|
struct mxs_ssp_regs *ssp_regs = mxs_slave->regs;
|
2012-07-09 00:48:32 +00:00
|
|
|
int len = bitlen / 8;
|
|
|
|
char dummy;
|
|
|
|
int write = 0;
|
|
|
|
char *data = NULL;
|
2012-07-09 00:48:33 +00:00
|
|
|
int dma = 1;
|
|
|
|
|
2012-07-09 00:48:32 +00:00
|
|
|
if (bitlen == 0) {
|
|
|
|
if (flags & SPI_XFER_END) {
|
|
|
|
din = (void *)&dummy;
|
|
|
|
len = 1;
|
|
|
|
} else
|
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
|
|
|
|
/* Half-duplex only */
|
|
|
|
if (din && dout)
|
|
|
|
return -EINVAL;
|
|
|
|
/* No data */
|
|
|
|
if (!din && !dout)
|
|
|
|
return 0;
|
|
|
|
|
|
|
|
if (dout) {
|
|
|
|
data = (char *)dout;
|
|
|
|
write = 1;
|
|
|
|
} else if (din) {
|
|
|
|
data = (char *)din;
|
|
|
|
write = 0;
|
|
|
|
}
|
|
|
|
|
2012-07-09 00:48:33 +00:00
|
|
|
/*
|
|
|
|
* Check for alignment, if the buffer is aligned, do DMA transfer,
|
|
|
|
* PIO otherwise. This is a temporary workaround until proper bounce
|
|
|
|
* buffer is in place.
|
|
|
|
*/
|
|
|
|
if (dma) {
|
|
|
|
if (((uint32_t)data) & (ARCH_DMA_MINALIGN - 1))
|
|
|
|
dma = 0;
|
|
|
|
if (((uint32_t)len) & (ARCH_DMA_MINALIGN - 1))
|
|
|
|
dma = 0;
|
|
|
|
}
|
|
|
|
|
|
|
|
if (!dma || (len < MXSSSP_SMALL_TRANSFER)) {
|
|
|
|
writel(SSP_CTRL1_DMA_ENABLE, &ssp_regs->hw_ssp_ctrl1_clr);
|
|
|
|
return mxs_spi_xfer_pio(mxs_slave, data, len, write, flags);
|
|
|
|
} else {
|
|
|
|
writel(SSP_CTRL1_DMA_ENABLE, &ssp_regs->hw_ssp_ctrl1_set);
|
|
|
|
return mxs_spi_xfer_dma(mxs_slave, data, len, write, flags);
|
|
|
|
}
|
2011-11-08 23:18:14 +00:00
|
|
|
}
|