Mirrors/trufflehog
2
0
Fork 0
mirror of https://github.com/trufflesecurity/trufflehog.git synced 2024-11-10 15:14:38 +00:00
Code Issues Projects Releases Packages Wiki Activity

fix browserstack detector (#1120)

Browse source 
* fixing browserstack regex username detection

* fixing browserstack regex username detection

* fixing browserstack regex username detection

* fix patterns

* fix patterns

---------

Co-authored-by: raju-bs <raju@browserstack.com>
Co-authored-by: Dustin Decker <dustin@trufflesec.com>
This commit is contained in:
raju-kamble 2023-02-22 05:03:16 +05:30 committed by GitHub
parent 9ef9e9870d
commit d20f43b5c6
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 4 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
pkg/detectors/browserstack/browserstack.go
View file

@ -20,8 +20,8 @@ var (
client = common.SaneHttpClient() client = common.SaneHttpClient()
// Make sure that your group is surrounded in boundary characters such as below to reduce false positives. // Make sure that your group is surrounded in boundary characters such as below to reduce false positives.
keyPat = regexp.MustCompile(detectors.PrefixRegex([]string{"browserstack", "key", "automate", "local"}) + `\b([0-9a-zA-Z]{20})\b`) keyPat = regexp.MustCompile(detectors.PrefixRegex([]string{"browserstack", "key", "automate", "local"}) + `\b([0-9a-zA-Z_]{20})\b`)
userPat = regexp.MustCompile(detectors.PrefixRegex([]string{"browserstack", "user", "automate", "local"}) + `\b(^[a-zA-Z\d]+([._-]?[a-zA-Z\d]+)*[a-zA-Z\d]+$)\b`) userPat = regexp.MustCompile(detectors.PrefixRegex([]string{"browserstack", "user", "automate", "local"}) + `\b([a-zA-Z\d]{3,18}[._-]+[a-zA-Z\d]{6})\b`)
) )
// Keywords are used for efficiently pre-filtering chunks. // Keywords are used for efficiently pre-filtering chunks.

2
pkg/detectors/browserstack/browserstack_test.go
View file

@ -51,6 +51,7 @@ func TestBrowserStack_FromChunk(t *testing.T) {
{ {
DetectorType: detectorspb.DetectorType_BrowserStack, DetectorType: detectorspb.DetectorType_BrowserStack,
Verified: true, Verified: true,
RawV2: []byte(fmt.Sprintf("%s%s", secret, secretUser)),
}, },
}, },
wantErr: false, wantErr: false,
@ -67,6 +68,7 @@ func TestBrowserStack_FromChunk(t *testing.T) {
{ {
DetectorType: detectorspb.DetectorType_BrowserStack, DetectorType: detectorspb.DetectorType_BrowserStack,
Verified: false, Verified: false,
RawV2: []byte(fmt.Sprintf("%s%s", inactiveSecret, secretUser)),
}, },
}, },
wantErr: false, wantErr: false,