From 964687c5659d5bef4928e02e78f4b99b556873e4 Mon Sep 17 00:00:00 2001 From: DANEE ARQUERO Date: Tue, 18 Jan 2022 22:19:06 -0800 Subject: [PATCH] added foursquare detector --- pkg/detectors/foursquare/foursquare.go | 81 ++++++++++++++ pkg/detectors/foursquare/foursquare_test.go | 114 ++++++++++++++++++++ 2 files changed, 195 insertions(+) create mode 100644 pkg/detectors/foursquare/foursquare.go create mode 100644 pkg/detectors/foursquare/foursquare_test.go diff --git a/pkg/detectors/foursquare/foursquare.go b/pkg/detectors/foursquare/foursquare.go new file mode 100644 index 000000000..e0215756c --- /dev/null +++ b/pkg/detectors/foursquare/foursquare.go @@ -0,0 +1,81 @@ +package foursquare + +import ( + "context" + "fmt" + + // "log" + "regexp" + "strings" + + "net/http" + + "github.com/trufflesecurity/trufflehog/pkg/common" + "github.com/trufflesecurity/trufflehog/pkg/detectors" + "github.com/trufflesecurity/trufflehog/pkg/pb/detectorspb" +) + +type Scanner struct{} + +// Ensure the Scanner satisfies the interface at compile time +var _ detectors.Detector = (*Scanner)(nil) + +var ( + client = common.SaneHttpClient() + + //Make sure that your group is surrounded in boundry characters such as below to reduce false positives + keyPat = regexp.MustCompile(detectors.PrefixRegex([]string{"foursquare"}) + `\b([0-9A-Z]{48})\b`) + secretMatch = regexp.MustCompile(detectors.PrefixRegex([]string{"foursquare"}) + `\b([0-9A-Z]{48})\b`) +) + +// Keywords are used for efficiently pre-filtering chunks. +// Use identifiers in the secret preferably, or the provider name. +func (s Scanner) Keywords() []string { + return []string{"foursquare"} +} + +// FromData will find and optionally verify Foursquare secrets in a given set of bytes. +func (s Scanner) FromData(ctx context.Context, verify bool, data []byte) (results []detectors.Result, err error) { + dataStr := string(data) + + matches := keyPat.FindAllStringSubmatch(dataStr, -1) + secretMatches := secretMatch.FindAllStringSubmatch(dataStr, -1) + + for _, match := range matches { + if len(match) != 2 { + continue + } + resMatch := strings.TrimSpace(match[1]) + for _, secretMatch := range secretMatches { + if len(secretMatch) != 2 { + continue + } + resSecret := strings.TrimSpace(secretMatch[1]) + s1 := detectors.Result{ + DetectorType: detectorspb.DetectorType_FourSquare, + Raw: []byte(resMatch), + } + + if verify { + req, _ := http.NewRequest("GET", fmt.Sprintf("https://api.foursquare.com/v2/venues/trending?client_id=%s&client_secret=%s&v=20211019&near=LA", resMatch, resSecret), nil) + req.Header.Add("Content-Type", "application/json") + res, err := client.Do(req) + if err == nil { + defer res.Body.Close() + if res.StatusCode >= 200 && res.StatusCode < 300 { + s1.Verified = true + } else { + //This function will check false positives for common test words, but also it will make sure the key appears 'random' enough to be a real key + if detectors.IsKnownFalsePositive(resMatch, detectors.DefaultFalsePositives, true) { + continue + } + } + } + } + + results = append(results, s1) + } + } + + return detectors.CleanResults(results), nil +} diff --git a/pkg/detectors/foursquare/foursquare_test.go b/pkg/detectors/foursquare/foursquare_test.go new file mode 100644 index 000000000..237c18a79 --- /dev/null +++ b/pkg/detectors/foursquare/foursquare_test.go @@ -0,0 +1,114 @@ +package foursquare + +import ( + "context" + "fmt" + "testing" + "time" + + "github.com/kylelemons/godebug/pretty" + "github.com/trufflesecurity/trufflehog/pkg/detectors" + + "github.com/trufflesecurity/trufflehog/pkg/common" + "github.com/trufflesecurity/trufflehog/pkg/pb/detectorspb" +) + +func TestFoursquare_FromChunk(t *testing.T) { + ctx, cancel := context.WithTimeout(context.Background(), time.Second*5) + defer cancel() + testSecrets, err := common.GetScannersTestSecrets(ctx) + if err != nil { + t.Fatalf("could not get test secrets from GCP: %s", err) + } + id := testSecrets.MustGetField("FOURSQUARE") + secret := testSecrets.MustGetField("FOURSQUARE_SECRET") + inactiveId := testSecrets.MustGetField("FOURSQUARE_INACTIVE") + + type args struct { + ctx context.Context + data []byte + verify bool + } + tests := []struct { + name string + s Scanner + args args + want []detectors.Result + wantErr bool + }{ + { + name: "found, verified", + s: Scanner{}, + args: args{ + ctx: context.Background(), + data: []byte(fmt.Sprintf("You can find a foursquare secret %s within foursquare id %s", secret, id)), + verify: true, + }, + want: []detectors.Result{ + { + DetectorType: detectorspb.DetectorType_FourSquare, + Verified: true, + }, + }, + wantErr: false, + }, + { + name: "found, unverified", + s: Scanner{}, + args: args{ + ctx: context.Background(), + data: []byte(fmt.Sprintf("You can find a foursquare secret %s within foursquare id %s but not valid", secret, inactiveId)), // the secret would satisfy the regex but not pass validation + verify: true, + }, + want: []detectors.Result{ + { + DetectorType: detectorspb.DetectorType_FourSquare, + Verified: false, + }, + }, + wantErr: false, + }, + { + name: "not found", + s: Scanner{}, + args: args{ + ctx: context.Background(), + data: []byte("You cannot find the secret within"), + verify: true, + }, + want: nil, + wantErr: false, + }, + } + for _, tt := range tests { + t.Run(tt.name, func(t *testing.T) { + s := Scanner{} + got, err := s.FromData(tt.args.ctx, tt.args.verify, tt.args.data) + if (err != nil) != tt.wantErr { + t.Errorf("Foursquare.FromData() error = %v, wantErr %v", err, tt.wantErr) + return + } + for i := range got { + if len(got[i].Raw) == 0 { + t.Fatalf("no raw secret present: \n %+v", got[i]) + } + got[i].Raw = nil + } + if diff := pretty.Compare(got, tt.want); diff != "" { + t.Errorf("Foursquare.FromData() %s diff: (-got +want)\n%s", tt.name, diff) + } + }) + } +} + +func BenchmarkFromData(benchmark *testing.B) { + ctx := context.Background() + s := Scanner{} + for name, data := range detectors.MustGetBenchmarkData() { + benchmark.Run(name, func(b *testing.B) { + for n := 0; n < b.N; n++ { + s.FromData(ctx, false, data) + } + }) + } +}