Mirrors/trufflehog
2
0
Fork 0
mirror of https://github.com/trufflesecurity/trufflehog.git synced 2024-11-10 15:14:38 +00:00
Code Issues Projects Releases Packages Wiki Activity

Fix improper github org member pagination (#814)

Browse source 
I'm not sure I fully understand why this issue exists. But I think the
short version is this: When we attempted to paginate users, we would set
a variable's Page value. But that variable appears to not actually be a
pointer, despite being added as one. It probably has to do with how
struct embedding works. Either way, if we make the overall options
variable the whole thing, and update its embedded struct with our page
variable, everything works out.
This commit is contained in:
trufflesteeeve 2022-09-21 19:22:42 -04:00 committed by GitHub
parent 509cf8b6fa
commit 63fcf33ce6
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 6 additions and 7 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

13
pkg/sources/github/github.go
View file

@ -788,16 +788,15 @@ func (s *Source) addOrgsByUser(ctx context.Context, user string) {
}
func (s *Source) addMembersByOrg(ctx context.Context, org string) error {
opts := &github.ListOptions{
PerPage: membersAppPagination,
}
optsOrg := &github.ListMembersOptions{
PublicOnly: false,
ListOptions: *opts,
opts := &github.ListMembersOptions{
PublicOnly: false,
ListOptions: github.ListOptions{
PerPage: membersAppPagination,
},
}
for {
members, res, err := s.apiClient.Organizations.ListMembers(ctx, org, optsOrg)
members, res, err := s.apiClient.Organizations.ListMembers(ctx, org, opts)
if err == nil {
defer res.Body.Close()
}