Mirrors/trufflehog
2
0
Fork 0
mirror of https://github.com/trufflesecurity/trufflehog.git synced 2024-11-10 07:04:24 +00:00
Code Issues Projects Releases Packages Wiki Activity

Update GitHub integration tests (#3124)

Browse source 
#1816 and #2995 both updated the GitHub source without updating its integration tests. This PR updates those tests, bringing them back into success.
This commit is contained in:
Cody Rose 2024-07-31 09:28:10 -04:00 committed by GitHub
parent a3d3565248
commit 3ab975edb3
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
1 changed files with 11 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

15
pkg/sources/github/github_integration_test.go
View file

@ -92,8 +92,8 @@ func TestSource_ScanComments(t *testing.T) {
// For the personal access token test
githubToken := secret.MustGetField("GITHUB_TOKEN")
const totalPRChunks = 2
const totalIssueChunks = 1
const totalPRChunks = 3
const totalIssueChunks = 2
type init struct {
name string
@ -129,7 +129,7 @@ func TestSource_ScanComments(t *testing.T) {
SourceMetadata: &source_metadatapb.MetaData{
Data: &source_metadatapb.MetaData_Github{
Github: &source_metadatapb.Github{
Link: "https://github.com/truffle-test-integration-org/another-test-repo/issues/1#issuecomment-1603436833",
Link: "https://github.com/truffle-test-integration-org/another-test-repo/issues/1",
Username: "truffle-sandbox",
Timestamp: "2023-06-22 23:33:46 +0000 UTC",
},
@ -860,6 +860,7 @@ func TestSource_Chunks_TargetedScan(t *testing.T) {
name string
init init
wantChunks int
wantErr bool
}{
{
name: "targeted scan, one file in small commit",
@ -914,6 +915,7 @@ func TestSource_Chunks_TargetedScan(t *testing.T) {
},
},
wantChunks: 0,
wantErr: true,
},
{
name: "invalid query criteria, malformed link",
@ -932,6 +934,7 @@ func TestSource_Chunks_TargetedScan(t *testing.T) {
},
},
wantChunks: 0,
wantErr: true,
},
}
@ -949,7 +952,11 @@ func TestSource_Chunks_TargetedScan(t *testing.T) {
go func() {
defer close(chunksCh)
err = s.Chunks(ctx, chunksCh, sources.ChunkingTarget{QueryCriteria: tt.init.queryCriteria})
assert.Nil(t, err)
if tt.wantErr {
assert.Error(t, err)
} else {
assert.NoError(t, err)
}
}()
i := 0