mirror of
https://github.com/derf/travelynx
synced 2024-12-13 06:22:33 +00:00
75363c35cc
When a user changes their destination station or checks into a new train while work is updating data for their in_transit entry, values for no longer valid database entrie would be entered.
175 lines
4.6 KiB
Perl
175 lines
4.6 KiB
Perl
package Travelynx::Command::work;
|
|
use Mojo::Base 'Mojolicious::Command';
|
|
|
|
use DateTime;
|
|
use JSON;
|
|
use List::Util;
|
|
|
|
has description =>
|
|
'Perform automatic checkout when users arrive at their destination';
|
|
|
|
has usage => sub { shift->extract_usage };
|
|
|
|
sub run {
|
|
my ($self) = @_;
|
|
|
|
my $now = DateTime->now( time_zone => 'Europe/Berlin' );
|
|
my $json = JSON->new;
|
|
|
|
my $db = $self->app->pg->db;
|
|
|
|
for my $entry (
|
|
$db->select( 'in_transit_str', '*', { cancelled => 0 } )->hashes->each )
|
|
{
|
|
|
|
my $uid = $entry->{user_id};
|
|
my $dep = $entry->{dep_eva};
|
|
my $arr = $entry->{arr_eva};
|
|
my $train_id = $entry->{train_id};
|
|
|
|
# Note: IRIS data is not always updated in real-time. Both departure and
|
|
# arrival delays may take several minutes to appear, especially in case
|
|
# of large-scale disturbances. We work around this by continuing to
|
|
# update departure data for up to 15 minutes after departure and
|
|
# delaying automatic checkout by at least 10 minutes.
|
|
|
|
eval {
|
|
if ( $now->epoch - $entry->{real_dep_ts} < 900 ) {
|
|
my $status = $self->app->get_departures( $dep, 30, 30 );
|
|
if ( $status->{errstr} ) {
|
|
die("get_departures($dep): $status->{errstr}\n");
|
|
}
|
|
|
|
my ($train) = List::Util::first { $_->train_id eq $train_id }
|
|
@{ $status->{results} };
|
|
|
|
if ( not $train ) {
|
|
die("could not find train $train_id at $dep\n");
|
|
}
|
|
|
|
# selecting on user_id and train_no avoids a race condition when
|
|
# a user checks into a new train while we are fetching data for
|
|
# their previous journey. In this case, the new train would
|
|
# receive data from the previous journey.
|
|
$db->update(
|
|
'in_transit',
|
|
{
|
|
dep_platform => $train->platform,
|
|
real_departure => $train->departure,
|
|
route =>
|
|
$json->encode( [ $self->app->route_diff($train) ] ),
|
|
messages => $json->encode(
|
|
[
|
|
map { [ $_->[0]->epoch, $_->[1] ] }
|
|
$train->messages
|
|
]
|
|
),
|
|
},
|
|
{
|
|
user_id => $uid,
|
|
train_no => $train->train_no
|
|
}
|
|
);
|
|
$self->app->add_route_timestamps( $uid, $train, 1 );
|
|
}
|
|
};
|
|
if ($@) {
|
|
$self->app->log->error("work($uid)/departure: $@");
|
|
}
|
|
|
|
eval {
|
|
if (
|
|
$arr
|
|
and ( not $entry->{real_arr_ts}
|
|
or $now->epoch - $entry->{real_arr_ts} < 600 )
|
|
)
|
|
{
|
|
my $status = $self->app->get_departures( $arr, 20, 220 );
|
|
if ( $status->{errstr} ) {
|
|
die("get_departures($arr): $status->{errstr}\n");
|
|
}
|
|
|
|
# Note that a train may pass the same station several times.
|
|
# Notable example: S41 / S42 ("Ringbahn") both starts and
|
|
# terminates at Berlin Südkreuz
|
|
my ($train) = List::Util::first {
|
|
$_->train_id eq $train_id
|
|
and $_->sched_arrival
|
|
and $_->sched_arrival->epoch > $entry->{sched_dep_ts}
|
|
}
|
|
@{ $status->{results} };
|
|
|
|
$train //= List::Util::first { $_->train_id eq $train_id }
|
|
@{ $status->{results} };
|
|
|
|
if ( not $train ) {
|
|
|
|
# If we haven't seen the train yet, its arrival is probably
|
|
# too far in the future. This is not critical.
|
|
return;
|
|
}
|
|
|
|
# selecting on user_id, train_no and checkout_station_id avoids a
|
|
# race condition when a user checks into a new train or changes
|
|
# their destination station while we are fetching times based on no
|
|
# longer valid database entries.
|
|
$db->update(
|
|
'in_transit',
|
|
{
|
|
arr_platform => $train->platform,
|
|
sched_arrival => $train->sched_arrival,
|
|
real_arrival => $train->arrival,
|
|
route =>
|
|
$json->encode( [ $self->app->route_diff($train) ] ),
|
|
messages => $json->encode(
|
|
[
|
|
map { [ $_->[0]->epoch, $_->[1] ] }
|
|
$train->messages
|
|
]
|
|
),
|
|
},
|
|
{
|
|
user_id => $uid,
|
|
train_no => $train->train_no,
|
|
checkout_station_id => $arr
|
|
}
|
|
);
|
|
$self->app->add_route_timestamps( $uid, $train, 0 );
|
|
}
|
|
elsif ( $entry->{real_arr_ts} ) {
|
|
my ( undef, $error ) = $self->app->checkout( $arr, 1, $uid );
|
|
if ($error) {
|
|
die("${error}\n");
|
|
}
|
|
}
|
|
};
|
|
if ($@) {
|
|
$self->app->log->error("work($uid)/arrival: $@");
|
|
}
|
|
|
|
eval { }
|
|
}
|
|
|
|
# Computing yearly stats may take a while, but we've got all time in the
|
|
# world here. This means users won't have to wait when loading their
|
|
# own by-year journey log.
|
|
for my $user ( $db->select( 'users', 'id', { status => 1 } )->hashes->each )
|
|
{
|
|
$self->app->get_journey_stats(
|
|
uid => $user->{id},
|
|
year => $now->year
|
|
);
|
|
}
|
|
}
|
|
|
|
1;
|
|
|
|
__END__
|
|
|
|
=head1 SYNOPSIS
|
|
|
|
Usage: index.pl work
|
|
|
|
Work Work Work.
|
|
|
|
Should be called from a cronjob every three minutes or so.
|