Mirrors/travelynx
2
0
Fork 0
mirror of https://github.com/derf/travelynx synced 2024-12-04 18:29:11 +00:00
Code Issues Projects Releases Packages Wiki Activity

Fix implicit checkout when checking in from a related station

Browse source 
Previously, realtime data was missing in this case
This commit is contained in:
Daniel Friesel 2019-11-12 19:13:38 +01:00
parent 4483073539
commit ead18f1212
1 changed files with 15 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

15
lib/Travelynx.pm
View file

@ -554,6 +554,21 @@ sub startup {
my ($train) my ($train)
= first { $_->train_id eq $train_id } @{ $status->{results} }; = first { $_->train_id eq $train_id } @{ $status->{results} };
# When a checkout is triggered by a checkin, there is an edge case
# with related stations.
# Assume a user travels from A to B1, then from B2 to C. B1 and B2 are
# relatd stations (e.g. "Frankfurt Hbf" and "Frankfurt Hbf(tief)").
# Now, if they check in for the journey from B2 to C, and have not yet
# checked out of the previous train, $train is undef as B2 is not B1.
# Redo the request with with_related => 1 to avoid this case.
# While at it, we increase the lookahead to handle long journeys as
# well.
if ( not $train ) {
$status = $self->get_departures( $station, 120, 180, 1 );
($train)
= first { $_->train_id eq $train_id } @{ $status->{results} };
}
# Store the intended checkout station regardless of this operation's # Store the intended checkout station regardless of this operation's
# success. # success.
my $new_checkout_station_id = $self->get_station_id( my $new_checkout_station_id = $self->get_station_id(