Commit graph

1297 commits

Author SHA1 Message Date
Pavel Djundik
7c2422ee19
Merge pull request #1881 from thelounge/astorije/fix-join-channel-load
Fix join channel UI opening by itself
2017-12-23 23:17:21 +02:00
Jérémie Astori
32a95c4d75
Merge pull request #1327 from thelounge/xpaw/view-changelog
Changelog viewer and updater checker in the client
2017-12-23 16:13:29 -05:00
Pavel Djundik
c14c3b73d2
Merge pull request #1882 from thelounge/astorije/join-ui-message
Improve wording of join channel UI form restrictions
2017-12-23 21:10:02 +02:00
Jérémie Astori
4b34a093c9
Reduce changelog client cache to 1h since as there is also server caching now 2017-12-23 13:38:34 -05:00
Jérémie Astori
7fa30980aa
Improve wording of join channel UI form restrictions
This gives a more actionable message to the user if they do not enter a valid value.
2017-12-23 03:05:29 -05:00
Jérémie Astori
6c50fe72b9
Fix join channel UI opening by itself
Without this, `target` was matching all of the lobby link, the "Join a channel..." button, and the join form submit button. This change restricts to the first one.
2017-12-23 03:00:16 -05:00
Jérémie Astori
685951966b
Rename "Client Settings" into "Settings" in tooltip, cleanup 2017-12-22 22:53:56 -05:00
Jérémie Astori
9691df67e3
Improve UI of the About section and changelog viewer
- Keep consistent width between the Help page and Changelog (which is already different from other windows 😠)
- Add icons to the About links
- Make sure `li` elements (i.e. all the lists in changelogs) are consistent in size with rest of the client
- Display version and release notes link on the "About The Lounge" header line, smaller, pushed to the right
- Check new releases when opening the Help window in order to display it without having to open the release notes. Release notes are being fed to the Changelog page at that moment to avoid fetching twice.
- Re-check version/fetch release notes after 24h. Since The Lounge can now run 24/7, reconnect when losing the network, we have to assume an "always-on" usage.
- Change icon, animate background color when getting response from GitHub to avoid flashing.
- Combine click handlers with our wonderful window management. These were the same handler, even with similar checks (`target` exists, etc.), just in 2 different places. This is necessary for the next item.
- Combine "Open release notes" and "Go back to Help" button behaviors with window management handlers. The window management code is gross as ever, and is in desperate need of a refactor, but at least there is no duplicated code for the same behavior + history management. This fixes the "Next" history behavior (however reloading the app while viewing the notes does not load on the notes, but this is a bug for a different PR!).
- Added a rule in the history management thingy: if a link we want to add history handling to has an `id`, store that in the state
- Added a button to go back to the Help window
- Fixed links to releases
- Send user to the GitHub issues *list* instead of *new issue form* because if they do not have a GitHub account, they will be redirected to the login page, which is a rather unpleasant experience when you are already confused...
- Fixed a bug that would return data about a new release in `latest` even though it is already the `current`. It was showing the current version as "The Lounge v... is now available".
- Added https://user-images.githubusercontent.com to the CSP rule when prefetch storage is enabled, because that is where we have stored screenshots in the changelog so far. Meh (we can improve that later if we decide to have a dedicated place for screenshots).
- Fetch changelog info even in public mode because users in public mode can access the release notes. They do not see the result of the version checker however.
2017-12-22 22:46:11 -05:00
Jérémie Astori
cbe9a4e221
Support pre blocks in our style
We use this in our changelogs. Style for this is straight from Bootstrap 3 minus the border.
2017-12-22 22:04:41 -05:00
Pavel Djundik
df858a5aaf
Add changelog viewing and update checking 2017-12-22 16:26:12 -05:00
Jérémie Astori
47f95c234d
Call the openForm function specifically when clicking on the context menu instead of relying on click handler
Not defining a `toggleForm` function has the advantage of "fixing" the fact that clicking "Join a channel..." from the context menu would close it when it was already open
2017-12-22 12:18:49 -05:00
Jérémie Astori
1063d7b1d6
Mark the channel field of "Join a channel" UI as required 2017-12-22 12:18:48 -05:00
Jérémie Astori
a03f894888
Change content of tooltip and button when opening/closing join channel form 2017-12-22 12:18:48 -05:00
Jérémie Astori
d2b0385431
Add a keyboard handler to close the join form when hitting "Escape" 2017-12-22 12:18:48 -05:00
Jérémie Astori
9ea3966140
Move the join channel form to its own component 2017-12-22 12:18:47 -05:00
Jérémie Astori
522bba694b
Use an ellipsis for change nick and join channel tooltips 2017-12-22 12:18:47 -05:00
Jérémie Astori
3307ced4d8
Remove background on close/join-channel sidebar buttons 2017-12-22 12:18:47 -05:00
Max Leiter
3fde87efbc
Add join channel UI via context menu or plus button next to lobbys 2017-12-22 12:18:46 -05:00
Pavel Djundik
aad9033d06
Use notEqual helper for close button 2017-12-22 12:30:23 +02:00
Pavel Djundik
06becc798f
Merge pull request #1874 from thelounge/astorije/handlebars-notEqual
Add a `notEqual` block helper for Handlebars and tests for `equal`
2017-12-22 12:28:15 +02:00
Al McKinlay
8004e051aa
Merge pull request #1833 from Cldfire/master
Remove lobby close button
2017-12-22 10:18:29 +00:00
Jérémie Astori
371c5bcac2
Add a notEqual block helper for Handlebars 2017-12-21 22:09:08 -05:00
Jérémie Astori
6d053d65e7
Add tests for the Handlebars helper equal 2017-12-21 20:09:12 -05:00
Jérémie Astori
f975426c61
Rename the error handlers file at loading time 2017-12-21 18:23:54 -05:00
Jérémie Astori
84db8d8866
Wrap entire error loading script in anonymous function to avoid leaks 2017-12-21 18:23:52 -05:00
Jérémie Astori
0ffd4d60d9
Improve error page at loading
- Display the "Reload page" instantly and not after 5 seconds
- Remove stack trace, buggy anyway
- Wrap the error details so it does not expand beyond boundaries (scrollbar would not show up either)
- Do not show the slow-loading warning on error
- Make zeeoe details selectable instead of editable
- Label improvements
2017-12-21 18:22:53 -05:00
Jérémie Astori
da7481c23c
Merge pull request #1850 from thelounge/xpaw/whois-dl
Format whois as a definition list
2017-12-21 18:05:01 -05:00
Jérémie Astori
98cab94f9b
Add visual feedback on focused buttons, for example when tabbing to it 2017-12-21 16:38:20 -05:00
Pavel Djundik
56b5a13abc
Merge pull request #1855 from MaxLeiter/primer-npm
Update to primer on npm
2017-12-21 16:41:54 +02:00
Max Leiter
32b4349130 Update to primer on npm, set tooltipped-no-delay for all tooltips 2017-12-20 22:04:13 -08:00
Al McKinlay
5084037cdc Add banlist context menu item 2017-12-20 09:53:28 +00:00
Jérémie Astori
a5dea8caa0
Update how textcomplete gets imported per the v0.16 changes
See ab6509782a (diff-04c6e90faac2675aa89e2176d2eec7d8)
2017-12-18 23:15:08 -05:00
Pavel Djundik
2b7657a9e7 Format whois as a definition list 2017-12-18 19:40:01 +02:00
Al McKinlay
ada870e959
Merge pull request #1843 from thelounge/astorije/time-status-mobile
Add missing time (and icon) of status messages on mobile
2017-12-18 14:00:14 +00:00
Jérémie Astori
36be7565a7
Merge pull request #1691 from realies/patch-2
fix gap between #sidebar and #footer
2017-12-18 00:06:14 -05:00
Cldfire
daa45c13fd Remove lobby close button
Without cheating and doing `display: none` this time around.
2017-12-17 22:28:56 -05:00
Pavel Djundik
b5ad495c6d Insert user-configurable string when autocompleting nicks
Fixes #1176
2017-12-17 21:15:47 +02:00
Jérémie Astori
af4f322bf9
Fix UI issues with special channels
As a reminder, "special" channels right now are banlists and channel lists.

- Remove that bottom margin that was causing things to hide behind the message input. This was probably relevant before the whole UI was flexbox-based and was not removed when switching.
- Do not align to bottom on special channels
- Hide unread and date markers on special channels
- Make sure table headers in special channels are not truncated, which was for example the case with "Users" being broken up ("User" and "s" on 2 different lines)
2017-12-17 01:14:11 -05:00
Jérémie Astori
cd606b8c28
Use cross-platform modifier shortcut for Mousetrap when possible
See https://craig.is/killing/mice#api.bind.combo
2017-12-16 16:14:12 -05:00
Jérémie Astori
d9cc335351
Add missing time (and icon) of status messages on mobile 2017-12-16 16:11:10 -05:00
Jérémie Astori
ffe8f2899b
Merge pull request #1787 from thelounge/xpaw/messages-bottom
Align message container to the bottom
2017-12-15 22:27:04 -05:00
Jérémie Astori
0a333ad84d
Merge pull request #1829 from thelounge/astorije/better-icons
Use better icons for channel/query list and context menu actions
2017-12-15 19:27:19 -05:00
Jérémie Astori
861d6b6642
Use better icons for channel/query list and context menu actions 2017-12-15 19:09:15 -05:00
Al McKinlay
b9f1b9fd4d
Merge pull request #1832 from MaxLeiter/media
Rename thumbnail/image option to more general `media`
2017-12-14 09:05:40 +00:00
Max Leiter
d4ad60c11d Support video file previews 2017-12-13 17:52:07 -08:00
Max Leiter
fdd8ef3e6a
Rename thumbnail/image option to more general 'media' 2017-12-13 20:03:12 -05:00
Pavel Djundik
7dcab09516
Merge pull request #1806 from MaxLeiter/sound
Support audio file previews
2017-12-13 11:03:04 +02:00
Max Leiter
ad1114ccfe Support audio file previews 2017-12-12 11:29:13 -08:00
Pavel Djundik
ccd0a6559b Add styling for 16-98 colors 2017-12-12 20:14:05 +02:00
Erik Vosseberg
33d865501d
Add whois and conversation as action to user contextmenu
Add Op specific actions to contextMenu

Show context menu when left clicking user

Switch to using data attributes as selectors

remove ban as possible action

Move `isOpInChannel()` to utils.js

Capitalize strings

use CSS.escape for `ownNick`

use string interpolation

properly point to findCurrentNetworkChan

Move context menu item actions to command pattern

add icons for context menu actions

Make list in context menu always list.

remove empty lines in style.css

use info circle instead of question circle

change context menu labels.

change contextMenuActions.execute to more explicit method.
2017-12-11 23:04:29 -05:00
Jérémie Astori
ce2adb4b8d
Use hashtag icon for channel instead of the sad file icon :) 2017-12-11 01:20:28 -05:00
Jérémie Astori
9436ba9301
Make sure user icon matches in network list, window context menu, and nick context menu 2017-12-11 01:19:50 -05:00
Pavel Djundik
4e6a29db35
Merge pull request #1797 from grissly-man/master
#1793 - implement reverse style
2017-12-10 16:15:40 +02:00
Jérémie Astori
a8fb892873
Merge pull request #1816 from MaxLeiter/fix-network-context
Proper network icon in context menu
2017-12-09 18:17:38 -05:00
Pavel Djundik
de98c2b13a
Merge pull request #1802 from MaxLeiter/chanlist
Add 'Channel list' to network context menu
2017-12-10 01:09:35 +02:00
Max Leiter
6311176f00 Proper network icon in context menu 2017-12-09 15:03:15 -08:00
Max Leiter
fb5eb0664a Add 'Channel list' to network context menu 2017-12-09 14:34:33 -08:00
Pavel Djundik
b391b87e29 Clean monospace and strikethrough formatters 2017-12-08 21:09:23 +02:00
Logan Griswold
fb94ad4205 implement reverse formatting with tests
implement reverse formatting with tests
2017-12-07 18:27:59 +00:00
Jérémie Astori
b662764caa
Merge pull request #1800 from thelounge/xpaw/textcomplete
Update textcomplete library and rewrite tabcomplete
2017-12-06 18:29:49 -05:00
Pavel Djundik
5e48e04623 Show notices and errors inline 2017-12-06 17:58:52 +02:00
Jérémie Astori
3df1e9d731
Merge pull request #1804 from thelounge/xpaw/no-use-before-define
Enable no-use-before-define rule
2017-12-06 09:08:38 -05:00
Pavel Djundik
20af04bca0 Enable no-use-before-define rule 2017-12-06 15:57:04 +02:00
Pavel Djundik
e462ed6270 Rewrite tabcomplete 2017-12-06 15:47:30 +02:00
Pavel Djundik
1bdbb75d4c Merge condensed messages when loading more history 2017-12-06 14:07:43 +02:00
Pavel Djundik
df703dc73a Upgrade to new textcomplete library 2017-12-06 12:06:57 +02:00
Jérémie Astori
db53f13865
Merge pull request #1794 from thelounge/xpaw/handle-js-errors
Handle javascript errors while loading
2017-12-05 18:33:11 -05:00
Pavel Djundik
2afd4d7ec4 Hide error under details 2017-12-05 15:17:31 +02:00
Pavel Djundik
2d0ddfb2e8
Merge pull request #1778 from thelounge/xpaw/lazy-init
Heavily improve performance of "init" event
2017-12-05 12:03:01 +02:00
Pavel Djundik
b5d39b96b9
Handle CHGHOST cap 2017-12-04 23:33:48 -05:00
Jérémie Astori
b80710ed82
Merge pull request #1788 from PolarizedIons/PolarizedIons/actualip
Add actualip to the actualhost line in the whois output
2017-12-04 23:30:04 -05:00
Logan Griswold
f07c1bef69
#1755 - implement monospace formatting with keybinding, tests, and help section 2017-12-03 15:10:46 -05:00
Logan Griswold
0643d3b4a3
#1754 - implement strikethrough formatting, client keybinding, tests, and help section 2017-12-03 15:10:34 -05:00
Pavel Djundik
e3823803aa Handle javascript errors while loading 2017-12-03 17:16:56 +02:00
Pavel Djundik
41e121d270 Only emit a single message per channel on init 2017-12-03 16:13:18 +02:00
Pavel Djundik
6aff2657e9 Ask for notification permission on page load if setting is enabled 2017-12-01 22:27:36 +02:00
stepie22
c7f6b8409f Change whois's actual host to include the actualip aswell 2017-12-01 15:03:02 +02:00
Pavel Djundik
52b234bdfc
Merge pull request #1770 from thelounge/astorije/client-tests
Add a bunch of client tests
2017-12-01 12:51:13 +02:00
Pavel Djundik
11568d7405 Align message container to the bottom 2017-12-01 12:41:26 +02:00
Jérémie Astori
f368dcdc69
Add a bunch of client tests 2017-11-30 20:33:23 -05:00
Pavel Djundik
d770028da6 Fix duplicate user names not being found 2017-11-30 14:16:11 +02:00
Pavel Djundik
a7bd40a5b1 Fix users not being linked in /me actions 2017-11-30 14:13:11 +02:00
Pavel Djundik
104e270882
Merge pull request #1771 from thelounge/astorije/fix-user-in-msg
Clone instances of `User` in `Msg` to avoid unintentional mutations
2017-11-30 11:29:23 +02:00
Pavel Djundik
f89054784f
Merge pull request #1764 from thelounge/xpaw/fix-data-from
Fix data-from on messages
2017-11-30 11:28:00 +02:00
Jérémie Astori
4ec10b922a
Clone instances of User in Msg to avoid unintentional mutations 2017-11-30 00:41:19 -05:00
Jérémie Astori
c0d348a678
Fix default value given to Msg.from
- `{}` is not falsey so Handlebars would try to render the block (see http://handlebarsjs.com/builtin_helpers.html#conditionals), therefore with a `nick` of `undefined`, which breaks `colorClass` (doing `undefined.length)
- There does not seem to be a way to check for empty objects in Handlebars (sigh) so checking `from.nick` seems like the most reliable way to check for a non-empty value. Alternatively, we could use a helper to check `{}` but meh.
2017-11-29 18:37:17 -05:00
Pavel Djundik
68753ae3e8 Fix data-from on messages 2017-11-29 20:45:19 +02:00
Jérémie Astori
c9da29f2fc
Merge pull request #1757 from thelounge/xpaw/detached-sign-in
Do not keep sign-in and loader references in memory
2017-11-27 18:32:20 -05:00
Jérémie Astori
b53f1719eb
Merge pull request #1749 from thelounge/astorije/avoid-escape-quotes
Avoid escaping quotes whenever possible
2017-11-27 12:57:55 -05:00
Pavel Djundik
5855099d5b Do not keep sign-in and loader references in memory 2017-11-27 19:39:16 +02:00
Max Leiter
3d31fa4686 Link nicks mentioned in messages 2017-11-27 09:10:56 -08:00
Pavel Djundik
6fc812d272
Merge pull request #1748 from MaxLeiter/highlights
Fix text highlighting when clicking on condensed message toggles
2017-11-27 11:48:03 +02:00
Jérémie Astori
287c3a8223
Avoid escaping quotes whenever possible
Our `.eslintrc.yml` configuration file already allows for avoiding escape (see [ESLint doc for `avoidEscape`](https://eslint.org/docs/rules/quotes#avoidescape)) so we might as well use it. We already use this in a few places I believe.
2017-11-26 17:34:28 -05:00
Max Leiter
d9d4672d75 Fix text highlighting when clicking on condensed message toggles 2017-11-26 14:05:23 -08:00
Bonuspunkt
0e52b133af Sending channel and link together generates duplicate text 2017-11-26 21:33:27 +02:00
Jérémie Astori
d9efaef369
Merge pull request #1746 from thelounge/xpaw/fix-preview-keep-to-bottom
Trigger keep to bottom for previews correctly
2017-11-26 12:35:08 -05:00
Pavel Djundik
6862c2e6b0 Trigger keep to bottom for previews correctly 2017-11-26 15:49:31 +02:00
Pavel Djundik
e3515d2ea1 Update stylelint rules 2017-11-26 14:28:33 +02:00
Pavel Djundik
5ffeb04343
Merge pull request #1739 from thelounge/xpaw/inactive-scroll
Do not keep scroll to bottom in inactive channels
2017-11-26 11:40:50 +02:00
Pavel Djundik
eaeb3375db
Merge pull request #1738 from thelounge/xpaw/extra-msg-trims
Trim channel messages in active channel and when switching channels
2017-11-26 11:40:31 +02:00