Mirrors/thelounge
2
0
Fork 0
mirror of https://github.com/thelounge/thelounge synced 2024-11-22 20:13:07 +00:00
Code Issues Projects Releases Packages Wiki Activity

Merge pull request #2701 from adamus1red/adamus1red/iframe-localstorage

Browse source 
Add `try`/`catch` to `localStorage` methods
This commit is contained in:
Pavel Djundik 2018-09-01 11:18:55 +03:00 committed by GitHub
commit b3c282f663
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 27 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

33
client/js/localStorage.js
View file

@ -1,22 +1,43 @@
"use strict";
// This is a simple localStorage wrapper because browser can throw errors
// in different situations, including:
// - Unable to store data if storage is full
// - Local storage is blocked if "third-party cookies and site data" is disabled
//
// For more details, see:
// https://stackoverflow.com/q/14555347/1935861
// https://github.com/thelounge/thelounge/issues/2699
// https://www.chromium.org/for-testers/bug-reporting-guidelines/uncaught-securityerror-failed-to-read-the-localstorage-property-from-window-access-is-denied-for-this-document
module.exports = {
set(key, value) {
try {
window.localStorage.setItem(key, value);
} catch (e) {
// Do nothing. If we end up here, web storage quota exceeded, or user is
// in Safari's private browsing where localStorage's setItem is not
// available. See http://stackoverflow.com/q/14555347/1935861.
//
}
},
get(key) {
return window.localStorage.getItem(key);
try {
return window.localStorage.getItem(key);
} catch (e) {
// Return null as if data is not set
return null;
}
},
remove(key) {
window.localStorage.removeItem(key);
try {
window.localStorage.removeItem(key);
} catch (e) {
//
}
},
clear() {
window.localStorage.clear();
try {
window.localStorage.clear();
} catch (e) {
//
}
},
};