Mirrors/thelounge
2
0
Fork 0
mirror of https://github.com/thelounge/thelounge synced 2024-11-22 12:03:11 +00:00
Code Issues Projects Releases Packages Wiki Activity

Improve inline audio file support

Browse source 
Tested on latest Chromium / Firefox. In case of .m4a files they want audio/x-m4a and not audio/m4a, in case of .flac files they want audio/flac and not audio/x-flac. The module we useed to detect the types however detects them only as audio/x-m4a and audio/x-flac as they are not offical IANA supported mime types (not in IANA spec == "x-" prefix): https://www.iana.org/assignments/media-types/media-types.xhtml Though flac is not in the IANA spec many programs such as the file command (https://man7.org/linux/man-pages/man1/file.1.html) and Chromium (flac) / Firefox (x-flac and flac) support audio/flac only or both.
This commit is contained in:
Nachtalb 2021-05-06 02:02:23 +02:00
parent 26a38b12ab
commit 0bfcd955e3
No known key found for this signature in database
GPG key ID: E48DF13C07055D92
2 changed files with 8 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
src/plugins/irc-events/link.js
View file

@ -249,6 +249,8 @@ function parse(msg, chan, preview, res, client) {
case "audio/x-midi": case "audio/x-midi":
case "audio/x-mpeg": case "audio/x-mpeg":
case "audio/x-mpeg-3": case "audio/x-mpeg-3":
case "audio/flac":
case "audio/x-m4a":
if (!preview.link.startsWith("https://")) { if (!preview.link.startsWith("https://")) {
break; break;
} }

9
src/plugins/uploader.js
View file

@ -21,7 +21,8 @@ const inlineContentDispositionTypes = {
"audio/mpeg": "audio.mp3", "audio/mpeg": "audio.mp3",
"audio/ogg": "audio.ogg", "audio/ogg": "audio.ogg",
"audio/vnd.wave": "audio.wav", "audio/vnd.wave": "audio.wav",
"audio/flac": "audio.flac", "audio/x-flac": "audio.flac",
"audio/x-m4a": "audio.m4a",
"image/bmp": "image.bmp", "image/bmp": "image.bmp",
"image/gif": "image.gif", "image/gif": "image.gif",
"image/jpeg": "image.jpg", "image/jpeg": "image.jpg",
@ -110,10 +111,12 @@ class Uploader {
}); });
} }
if (detectedMimeType === "audio/vnd.wave") { // Send a more common mime type for audio files
// Send a more common mime type for wave audio files
// so that browsers can play them correctly // so that browsers can play them correctly
if (detectedMimeType === "audio/vnd.wave") {
detectedMimeType = "audio/wav"; detectedMimeType = "audio/wav";
} else if (detectedMimeType === "audio/x-flac") {
detectedMimeType = "audio/flac";
} }
res.setHeader("Content-Disposition", disposition); res.setHeader("Content-Disposition", disposition);