Merge pull request #2601 from JonathanBeverley/jmb/features

.gitignore

@@ -28,3 +28,5 @@ docs/api
 .electron-symbols
 sentry.properties
 sentry-symbols.js
+
+terminus-ssh/util/pagent.exe

terminus-ssh/package.json

@@ -9,10 +9,12 @@
   "typings": "typings/index.d.ts",
   "scripts": {
     "build": "webpack --progress --color",
-    "watch": "webpack --progress --color --watch"
+    "watch": "webpack --progress --color --watch",
+    "postinstall": "xcopy /i node_modules\\ssh2\\util\\pagent.exe util\\"
   },
   "files": [
-    "dist"
+    "dist",
+    "util/pagent.exe"
   ],
   "author": "Eugene Pankov",
   "license": "MIT",

terminus-ssh/src/api.ts

@@ -36,6 +36,7 @@ export interface SSHConnection {
     skipBanner?: boolean
     disableDynamicTitle?: boolean
     jumpHost?: string
+    agentForward?: boolean
 
     algorithms?: {[t: string]: string[]}
 }

terminus-ssh/src/components/editConnectionModal.component.pug

@@ -83,6 +83,11 @@
                         .title X11 forwarding
                     toggle([(ngModel)]='connection.x11')
 
+                .form-line
+                    .header
+                        .title Allow Agent Forwarding
+                    toggle([(ngModel)]='connection.agentForward')
+
                 .form-line
                     .header
                         .title Tab color

terminus-ssh/src/services/ssh.service.ts

@@ -16,10 +16,6 @@ import { PromptModalComponent } from '../components/promptModal.component'
 import { PasswordStorageService } from './passwordStorage.service'
 import { SSHTabComponent } from '../components/sshTab.component'
 
-try {
-    var windowsProcessTreeNative = require('windows-process-tree/build/Release/windows_process_tree.node') // eslint-disable-line @typescript-eslint/no-var-requires, no-var
-} catch { }
-
 @Injectable({ providedIn: 'root' })
 export class SSHService {
     private logger: Logger
@@ -187,14 +183,7 @@ export class SSHService {
 
             let agent: string|null = null
             if (this.hostApp.platform === Platform.Windows) {
-                const pageantRunning = new Promise<boolean>(resolve => {
-                    windowsProcessTreeNative.getProcessList(list => { // eslint-disable-line block-scoped-var
-                        resolve(list.some(x => x.name === 'pageant.exe'))
-                    }, 0)
-                })
-                if (await pageantRunning) {
                 agent = 'pageant'
-                }
             } else {
                 agent = process.env.SSH_AUTH_SOCK as string
             }
@@ -208,7 +197,7 @@ export class SSHService {
                     privateKey: privateKey || undefined,
                     tryKeyboard: true,
                     agent: agent || undefined,
-                    agentForward: !!agent,
+                    agentForward: session.connection.agentForward && !!agent,
                     keepaliveInterval: session.connection.keepaliveInterval,
                     keepaliveCountMax: session.connection.keepaliveCountMax,
                     readyTimeout: session.connection.readyTimeout,