Mirrors/tabby
2
0
Fork 0
mirror of https://github.com/Eugeny/tabby synced 2025-03-04 15:17:17 +00:00
Code Issues Projects Releases Packages Wiki Activity

fix(selector): avoid error Uncaught (in promise) on modal dismiss (fix Eugeny/tabby#8065)

Browse source
This commit is contained in:
Clem Fern 2023-08-15 19:53:52 +02:00
parent d21282501f
commit a9c63b5305
5 changed files with 10 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
tabby-core/src/index.ts
View file

@ -229,7 +229,7 @@ export default class AppModule { // eslint-disable-line @typescript-eslint/no-ex
})
}
await this.selector.show(this.translate.instant('Select profile'), options)
await this.selector.show(this.translate.instant('Select profile'), options).catch(() => {return})
}
static forRoot (): ModuleWithProviders<AppModule> {

2
tabby-core/src/services/commands.service.ts
View file

@ -109,6 +109,6 @@ export class CommandService {
description: c.sublabel,
icon: c.icon,
})),
)
).catch(() => {return})
}
}

5
tabby-core/src/services/fileProviders.service.ts
View file

@ -13,8 +13,9 @@ export class FileProvidersService {
) { }
async selectAndStoreFile (description: string): Promise<string> {
const p = await this.selectProvider()
return p.selectAndStoreFile(description)
return this.selectProvider().then(p => {
return p.selectAndStoreFile(description)
})
}
async retrieveFile (key: string): Promise<Buffer> {

2
tabby-core/src/services/profiles.service.ts
View file

@ -323,7 +323,7 @@ export class ProfilesService {
}
})
await this.selector.show(this.translate.instant('Select profile or enter an address'), options)
await this.selector.show(this.translate.instant('Select profile or enter an address'), options).catch(() => resolve(null))
} catch (err) {
reject(err)
}

5
tabby-settings/src/components/profilesSettingsTab.component.ts
View file

@ -65,7 +65,10 @@ export class ProfilesSettingsTabComponent extends BaseComponent {
name: p.group ? `${this.profilesService.resolveProfileGroupName(p.group)} / ${p.name}` : p.name,
result: p,
})),
)
).catch(() => undefined)
if (!base) {
return
}
}
const profile: PartialProfile<Profile> = deepClone(base)
delete profile.id