Mirrors/sqlx
2
0
Fork 0
mirror of https://github.com/launchbadge/sqlx synced 2024-11-10 22:44:17 +00:00
Code Issues Projects Releases Packages Wiki Activity

fix(macros): forbid casts to _ in bind parameters

Browse source
This commit is contained in:
Austin Bonander 2020-06-11 20:23:56 -07:00 committed by Ryan Leckey
parent 029ba24cad
commit 7b37ebde0f
1 changed files with 27 additions and 21 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

48
sqlx-macros/src/query/args.rs
View file

@ -35,28 +35,34 @@ pub fn quote_args<DB: DatabaseExt>(
let param_ty = param_ty.as_ref().unwrap();
let param_ty = match get_type_override(expr) {
// don't emit typechecking code for this binding
Some(Type::Infer(_)) => return Ok(quote!()),
Some(ty) => ty.to_token_stream(),
None => {
DB::param_type_for_id(&param_ty)
.ok_or_else(|| {
if let Some(feature_gate) = <DB as DatabaseExt>::get_feature_gate(&param_ty) {
format!(
"optional feature `{}` required for type {} of param #{}",
feature_gate,
param_ty,
i + 1,
)
} else {
format!("unsupported type {} for param #{}", param_ty, i + 1)
}
})?
.parse::<proc_macro2::TokenStream>()
.map_err(|_| format!("Rust type mapping for {} not parsable", param_ty))?
// TODO: enable this in 1.45 when we can strip `as _`
// without stripping these we get some pretty nasty type errors
Some(Type::Infer(_)) => return Err(
syn::Error::new_spanned(
expr,
"casts to `_` are not allowed in bind parameters yet"
).into()
),
Some(ty) => ty.to_token_stream(),
None => {
DB::param_type_for_id(&param_ty)
.ok_or_else(|| {
if let Some(feature_gate) = <DB as DatabaseExt>::get_feature_gate(&param_ty) {
format!(
"optional feature `{}` required for type {} of param #{}",
feature_gate,
param_ty,
i + 1,
)
} else {
format!("unsupported type {} for param #{}", param_ty, i + 1)
}
})?
.parse::<proc_macro2::TokenStream>()
.map_err(|_| format!("Rust type mapping for {} not parsable", param_ty))?
}
};
}
};
Ok(quote_spanned!(expr.span() =>
// this shouldn't actually run