mirror of
https://github.com/rust-lang/rust-clippy
synced 2024-09-20 22:51:58 +00:00
315bb10405
Instead of
```
LL | fn oom(
| __^
| | _|
| ||
LL | || ) {
| ||_-
LL | | }
| |__^
```
emit
```
LL | // fn oom(
LL | || ) {
| ||_-
LL | | }
| |__^
```
55 lines
2.2 KiB
Text
55 lines
2.2 KiB
Text
error: called `map(f)` on an `Result` value where `f` is a closure that returns the unit type `()`
|
|
--> $DIR/result_map_unit_fn_unfixable.rs:23:5
|
|
|
|
|
LL | x.field.map(|value| { do_nothing(value); do_nothing(value) });
|
|
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^-
|
|
| |
|
|
| help: try this: `if let Ok(value) = x.field { ... }`
|
|
|
|
|
= note: `-D clippy::result-map-unit-fn` implied by `-D warnings`
|
|
|
|
error: called `map(f)` on an `Result` value where `f` is a closure that returns the unit type `()`
|
|
--> $DIR/result_map_unit_fn_unfixable.rs:25:5
|
|
|
|
|
LL | x.field.map(|value| if value > 0 { do_nothing(value); do_nothing(value) });
|
|
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^-
|
|
| |
|
|
| help: try this: `if let Ok(value) = x.field { ... }`
|
|
|
|
error: called `map(f)` on an `Result` value where `f` is a closure that returns the unit type `()`
|
|
--> $DIR/result_map_unit_fn_unfixable.rs:29:5
|
|
|
|
|
LL | // x.field.map(|value| {
|
|
LL | || do_nothing(value);
|
|
LL | || do_nothing(value)
|
|
LL | || });
|
|
| ||______^- help: try this: `if let Ok(value) = x.field { ... }`
|
|
| |______|
|
|
|
|
|
|
|
error: called `map(f)` on an `Result` value where `f` is a closure that returns the unit type `()`
|
|
--> $DIR/result_map_unit_fn_unfixable.rs:33:5
|
|
|
|
|
LL | x.field.map(|value| { do_nothing(value); do_nothing(value); });
|
|
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^-
|
|
| |
|
|
| help: try this: `if let Ok(value) = x.field { ... }`
|
|
|
|
error: called `map(f)` on an `Result` value where `f` is a function that returns the unit type `()`
|
|
--> $DIR/result_map_unit_fn_unfixable.rs:37:5
|
|
|
|
|
LL | "12".parse::<i32>().map(diverge);
|
|
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^-
|
|
| |
|
|
| help: try this: `if let Ok(a) = "12".parse::<i32>() { diverge(a) }`
|
|
|
|
error: called `map(f)` on an `Result` value where `f` is a function that returns the unit type `()`
|
|
--> $DIR/result_map_unit_fn_unfixable.rs:43:5
|
|
|
|
|
LL | y.map(do_nothing);
|
|
| ^^^^^^^^^^^^^^^^^-
|
|
| |
|
|
| help: try this: `if let Ok(_y) = y { do_nothing(_y) }`
|
|
|
|
error: aborting due to 6 previous errors
|
|
|