mirror of
https://github.com/rust-lang/rust-clippy
synced 2024-11-10 23:24:24 +00:00
156 lines
4.9 KiB
Text
156 lines
4.9 KiB
Text
error: called `map(<f>).unwrap_or(<a>)` on an `Option` value. This can be done more directly by calling `map_or(<a>, <f>)` instead
|
|
--> $DIR/map_unwrap_or.rs:17:13
|
|
|
|
|
LL | let _ = opt.map(|x| x + 1)
|
|
| _____________^
|
|
LL | | // Should lint even though this call is on a separate line.
|
|
LL | | .unwrap_or(0);
|
|
| |_____________________^
|
|
|
|
|
= note: `-D clippy::map-unwrap-or` implied by `-D warnings`
|
|
help: use `map_or(<a>, <f>)` instead
|
|
|
|
|
LL - let _ = opt.map(|x| x + 1)
|
|
LL + let _ = opt.map_or(0, |x| x + 1);
|
|
|
|
|
|
|
error: called `map(<f>).unwrap_or(<a>)` on an `Option` value. This can be done more directly by calling `map_or(<a>, <f>)` instead
|
|
--> $DIR/map_unwrap_or.rs:21:13
|
|
|
|
|
LL | let _ = opt.map(|x| {
|
|
| _____________^
|
|
LL | | x + 1
|
|
LL | | }
|
|
LL | | ).unwrap_or(0);
|
|
| |__________________^
|
|
|
|
|
help: use `map_or(<a>, <f>)` instead
|
|
|
|
|
LL ~ let _ = opt.map_or(0, |x| {
|
|
LL | x + 1
|
|
LL | }
|
|
LL ~ );
|
|
|
|
|
|
|
error: called `map(<f>).unwrap_or(<a>)` on an `Option` value. This can be done more directly by calling `map_or(<a>, <f>)` instead
|
|
--> $DIR/map_unwrap_or.rs:25:13
|
|
|
|
|
LL | let _ = opt.map(|x| x + 1)
|
|
| _____________^
|
|
LL | | .unwrap_or({
|
|
LL | | 0
|
|
LL | | });
|
|
| |__________^
|
|
|
|
|
help: use `map_or(<a>, <f>)` instead
|
|
|
|
|
LL ~ let _ = opt.map_or({
|
|
LL + 0
|
|
LL ~ }, |x| x + 1);
|
|
|
|
|
|
|
error: called `map(<f>).unwrap_or(None)` on an `Option` value. This can be done more directly by calling `and_then(<f>)` instead
|
|
--> $DIR/map_unwrap_or.rs:30:13
|
|
|
|
|
LL | let _ = opt.map(|x| Some(x + 1)).unwrap_or(None);
|
|
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
|
|
|
|
help: use `and_then(<f>)` instead
|
|
|
|
|
LL - let _ = opt.map(|x| Some(x + 1)).unwrap_or(None);
|
|
LL + let _ = opt.and_then(|x| Some(x + 1));
|
|
|
|
|
|
|
error: called `map(<f>).unwrap_or(None)` on an `Option` value. This can be done more directly by calling `and_then(<f>)` instead
|
|
--> $DIR/map_unwrap_or.rs:32:13
|
|
|
|
|
LL | let _ = opt.map(|x| {
|
|
| _____________^
|
|
LL | | Some(x + 1)
|
|
LL | | }
|
|
LL | | ).unwrap_or(None);
|
|
| |_____________________^
|
|
|
|
|
help: use `and_then(<f>)` instead
|
|
|
|
|
LL ~ let _ = opt.and_then(|x| {
|
|
LL | Some(x + 1)
|
|
LL | }
|
|
LL ~ );
|
|
|
|
|
|
|
error: called `map(<f>).unwrap_or(None)` on an `Option` value. This can be done more directly by calling `and_then(<f>)` instead
|
|
--> $DIR/map_unwrap_or.rs:36:13
|
|
|
|
|
LL | let _ = opt
|
|
| _____________^
|
|
LL | | .map(|x| Some(x + 1))
|
|
LL | | .unwrap_or(None);
|
|
| |________________________^
|
|
|
|
|
help: use `and_then(<f>)` instead
|
|
|
|
|
LL - .map(|x| Some(x + 1))
|
|
LL + .and_then(|x| Some(x + 1));
|
|
|
|
|
|
|
error: called `map(<f>).unwrap_or(<a>)` on an `Option` value. This can be done more directly by calling `map_or(<a>, <f>)` instead
|
|
--> $DIR/map_unwrap_or.rs:47:13
|
|
|
|
|
LL | let _ = Some("prefix").map(|p| format!("{}.", p)).unwrap_or(id);
|
|
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
|
|
|
|
help: use `map_or(<a>, <f>)` instead
|
|
|
|
|
LL - let _ = Some("prefix").map(|p| format!("{}.", p)).unwrap_or(id);
|
|
LL + let _ = Some("prefix").map_or(id, |p| format!("{}.", p));
|
|
|
|
|
|
|
error: called `map(<f>).unwrap_or_else(<g>)` on an `Option` value. This can be done more directly by calling `map_or_else(<g>, <f>)` instead
|
|
--> $DIR/map_unwrap_or.rs:51:13
|
|
|
|
|
LL | let _ = opt.map(|x| {
|
|
| _____________^
|
|
LL | | x + 1
|
|
LL | | }
|
|
LL | | ).unwrap_or_else(|| 0);
|
|
| |__________________________^
|
|
|
|
error: called `map(<f>).unwrap_or_else(<g>)` on an `Option` value. This can be done more directly by calling `map_or_else(<g>, <f>)` instead
|
|
--> $DIR/map_unwrap_or.rs:55:13
|
|
|
|
|
LL | let _ = opt.map(|x| x + 1)
|
|
| _____________^
|
|
LL | | .unwrap_or_else(||
|
|
LL | | 0
|
|
LL | | );
|
|
| |_________^
|
|
|
|
error: called `map(<f>).unwrap_or_else(<g>)` on a `Result` value. This can be done more directly by calling `.map_or_else(<g>, <f>)` instead
|
|
--> $DIR/map_unwrap_or.rs:67:13
|
|
|
|
|
LL | let _ = res.map(|x| {
|
|
| _____________^
|
|
LL | | x + 1
|
|
LL | | }
|
|
LL | | ).unwrap_or_else(|_e| 0);
|
|
| |____________________________^
|
|
|
|
error: called `map(<f>).unwrap_or_else(<g>)` on a `Result` value. This can be done more directly by calling `.map_or_else(<g>, <f>)` instead
|
|
--> $DIR/map_unwrap_or.rs:71:13
|
|
|
|
|
LL | let _ = res.map(|x| x + 1)
|
|
| _____________^
|
|
LL | | .unwrap_or_else(|_e| {
|
|
LL | | 0
|
|
LL | | });
|
|
| |__________^
|
|
|
|
error: called `map(<f>).unwrap_or_else(<g>)` on a `Result` value. This can be done more directly by calling `.map_or_else(<g>, <f>)` instead
|
|
--> $DIR/map_unwrap_or.rs:95:13
|
|
|
|
|
LL | let _ = res.map(|x| x + 1).unwrap_or_else(|_e| 0);
|
|
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `res.map_or_else(|_e| 0, |x| x + 1)`
|
|
|
|
error: aborting due to 12 previous errors
|
|
|