mirror of
https://github.com/rust-lang/rust-clippy
synced 2024-11-10 23:24:24 +00:00
6bb6dd64d4
There was an error when trying to negate an expression like `x - 1.0`. We used to format it as `-x - 1.0` whereas a proper negation would be `-(x - 1.0)`. Therefore, we add parentheses around the expression when it is a Binary ExprKind. We also add parentheses around multiply and divide expressions, even though this is not strictly necessary.
33 lines
864 B
Rust
33 lines
864 B
Rust
// run-rustfix
|
|
#![warn(clippy::suboptimal_flops)]
|
|
#![allow(clippy::unnecessary_cast)]
|
|
|
|
fn main() {
|
|
let one = 1;
|
|
let x = 3f32;
|
|
|
|
let y = 4f32;
|
|
let _ = x.powi(2) + y;
|
|
let _ = x.powi(2) - y;
|
|
let _ = x + y.powi(2);
|
|
let _ = x - y.powi(2);
|
|
let _ = x + (y as f32).powi(2);
|
|
let _ = (x.powi(2) + y).sqrt();
|
|
let _ = (x + y.powi(2)).sqrt();
|
|
|
|
let _ = (x - 1.0).powi(2) - y;
|
|
let _ = (x - 1.0).powi(2) - y + 3.0;
|
|
let _ = (x - 1.0).powi(2) - (y + 3.0);
|
|
let _ = x - (y + 1.0).powi(2);
|
|
let _ = x - (3.0 * y).powi(2);
|
|
let _ = x - (y + 1.0 + x).powi(2);
|
|
let _ = x - (y + 1.0 + 2.0).powi(2);
|
|
|
|
// Cases where the lint shouldn't be applied
|
|
let _ = x.powi(2);
|
|
let _ = x.powi(1 + 1);
|
|
let _ = x.powi(3);
|
|
let _ = x.powi(4) + y;
|
|
let _ = x.powi(one + 1);
|
|
let _ = (x.powi(2) + y.powi(2)).sqrt();
|
|
}
|