Mirrors/rust-clippy
2
0
Fork 0
mirror of https://github.com/rust-lang/rust-clippy synced 2024-12-13 06:42:46 +00:00
Code Issues Projects Releases Packages Wiki Activity
rust-clippy/clippy_lints/src
History
bors f947644f0d Auto merge of #5680 - ebroto:3792_let_return, r=Manishearth 
let_and_return: avoid "does not live long enough" errors

EDIT: Add #3324 to the list of fixes

<details>
<summary>Description of old impl</summary>
<br>
Avoid suggesting turning the RHS expression of the last statement into the block tail expression if a temporary borrows from a local that would be destroyed before.

This is my first incursion into MIR so there's probably room for improvement!
</details>

Avoid linting if the return type of some method or function called in the last statement has a lifetime parameter.

changelog: Fix false positive in [`let_and_return`]

Fixes #3792
Fixes #3324
2020-06-08 16:47:22 +00:00
..
methods dogfood unnested_or_patterns 2020-06-07 21:16:03 +02:00
utils Auto merge of #5680 - ebroto:3792_let_return, r=Manishearth 2020-06-08 16:47:22 +00:00
approx_const.rs clean up a few lint docs 2020-03-18 02:50:39 +01:00
arithmetic.rs Disallow bit-shifting in integer_arithmetic lint 2020-04-13 13:23:59 +10:00
as_conversions.rs Add an Option<Span> argument to span_lint_and_help. 2020-04-18 18:28:29 +08:00
assertions_on_constants.rs Add an Option<Span> argument to span_lint_and_help. 2020-04-18 18:28:29 +08:00
assign_ops.rs Fix some code examples in doc 2020-06-01 10:39:52 +02:00
atomic_ordering.rs Add an Option<Span> argument to span_lint_and_help. 2020-04-18 18:28:29 +08:00
attrs.rs Merge commit '7ea7cd165ad6705603852771bf82cc2fd6560db5' into clippyup2 2020-05-28 15:45:24 +02:00
await_holding_lock.rs Fix rebase fallout 2020-06-07 21:37:55 +02:00
bit_mask.rs Cleanup: Rename 'db' variable to 'diag' 2020-04-17 08:08:00 +02:00
blacklisted_name.rs Fix fallout 2020-02-21 11:14:18 +01:00
blocks_in_if_conditions.rs Merge commit 'e214ea82ad0a751563acf67e1cd9279cf302db3a' into clippyup 2020-05-17 17:36:26 +02:00
booleans.rs Cleanup: Rename 'db' variable to 'diag' 2020-04-17 08:08:00 +02:00
bytecount.rs Merge commit 'e214ea82ad0a751563acf67e1cd9279cf302db3a' into clippyup 2020-05-17 17:36:26 +02:00
cargo_common_metadata.rs Add error info when cargo metadata fails to run 2020-06-05 22:28:58 +02:00
checked_conversions.rs Fix false negative of checked_conversion lint 2020-06-03 09:04:24 +07:00
cognitive_complexity.rs rustup https://github.com/rust-lang/rust/pull/71215/ 2020-04-24 15:29:31 +02:00
collapsible_if.rs Cleanup: Rename 'db' variable to 'diag' 2020-04-17 08:08:00 +02:00
comparison_chain.rs Merge commit 'e214ea82ad0a751563acf67e1cd9279cf302db3a' into clippyup 2020-05-17 17:36:26 +02:00
consts.rs Revert "Fix cases of match_wildcard_for_single_variants lint when it is spanned on Option" 2020-05-15 22:33:37 +03:00
copies.rs Cleanup: Use rustc's same_types instead of our same_tys 2020-06-06 11:50:59 +02:00
copy_iterator.rs Change note_span argument for span_lint_and_note. 2020-04-18 18:29:36 +08:00
dbg_macro.rs Add an Option<Span> argument to span_lint_and_help. 2020-04-18 18:28:29 +08:00
default_trait_access.rs rustup https://github.com/rust-lang/rust/pull/70536 2020-03-30 11:17:58 +02:00
deprecated_lints.rs Deprecate REPLACE_CONSTS lint 2020-03-29 12:59:35 +07:00
dereference.rs Better precedence case management + more tests 2020-04-15 17:18:12 +02:00
derive.rs rustup https://github.com/rust-lang/rust/pull/71215/ 2020-04-24 15:29:31 +02:00
doc.rs rustup https://github.com/rust-lang/rust/pull/71215/ 2020-04-24 15:29:31 +02:00
double_comparison.rs Fix fallout 2020-02-21 11:14:18 +01:00
double_parens.rs Fix some code examples in doc 2020-06-01 10:39:52 +02:00
drop_bounds.rs Corrected doc PR fixes 2020-06-01 10:49:48 +02:00
drop_forget_ref.rs Change note_span argument for span_lint_and_note. 2020-04-18 18:29:36 +08:00
duration_subsec.rs Fix some code examples in doc 2020-06-01 10:39:52 +02:00
else_if_without_else.rs Add an Option<Span> argument to span_lint_and_help. 2020-04-18 18:28:29 +08:00
empty_enum.rs Formatting and naming 2020-04-19 20:38:07 +02:00
entry.rs More diagnostic items 2020-04-26 13:44:08 +02:00
enum_clike.rs rustup https://github.com/rust-lang/rust/pull/70986 2020-04-11 10:01:23 +02:00
enum_variants.rs Fix some code examples in doc 2020-06-01 10:39:52 +02:00
eq_op.rs Fix some code examples in doc 2020-06-01 10:39:52 +02:00
erasing_op.rs Fix fallout 2020-02-21 11:14:18 +01:00
escape.rs Fix some code examples in doc 2020-06-01 10:39:52 +02:00
eta_reduction.rs Corrected doc PR fixes 2020-06-01 10:49:48 +02:00
eval_order_dependence.rs Corrected doc PR fixes 2020-06-01 10:49:48 +02:00
excessive_bools.rs Add an Option<Span> argument to span_lint_and_help. 2020-04-18 18:28:29 +08:00
exit.rs rustup https://github.com/rust-lang/rust/pull/71215/ 2020-04-24 15:29:31 +02:00
explicit_write.rs Rustup to rust-lang/rust#69592 2020-03-01 12:23:33 +09:00
fallible_impl_from.rs Corrected doc PR fixes 2020-06-01 10:49:48 +02:00
float_literal.rs Merge commit '7ea7cd165ad6705603852771bf82cc2fd6560db5' into clippyup2 2020-05-28 15:45:24 +02:00
floating_point_arithmetic.rs Fix more code examples 2020-06-01 10:39:52 +02:00
format.rs Fix more code examples 2020-06-01 10:39:52 +02:00
formatting.rs dogfood unnested_or_patterns 2020-06-07 21:16:03 +02:00
functions.rs Corrected doc PR fixes 2020-06-01 10:49:48 +02:00
future_not_send.rs Call skip_binder or no_bound_vars before self_ty 2020-06-01 12:18:57 -07:00
get_last_with_len.rs Cleanup: Use our sym! macro more 2020-04-13 08:57:34 +02:00
identity_op.rs Merge commit 'e214ea82ad0a751563acf67e1cd9279cf302db3a' into clippyup 2020-05-17 17:36:26 +02:00
if_let_mutex.rs More diagnostic items 2020-04-26 13:44:08 +02:00
if_let_some_result.rs Make use of Option/Result diagnostic items 2020-04-12 15:23:07 +02:00
if_not_else.rs Add an Option<Span> argument to span_lint_and_help. 2020-04-18 18:28:29 +08:00
implicit_return.rs Cleanup: Rename 'db' variable to 'diag' 2020-04-17 08:08:00 +02:00
implicit_saturating_sub.rs Fix more code examples 2020-06-01 10:39:52 +02:00
indexing_slicing.rs Add an Option<Span> argument to span_lint_and_help. 2020-04-18 18:28:29 +08:00
infinite_iter.rs Fix fallout 2020-02-21 11:14:18 +01:00
inherent_impl.rs Cleanup: Rename 'db' variable to 'diag' 2020-04-17 08:08:00 +02:00
inherent_to_string.rs cargo dev fmt 2020-04-26 13:44:08 +02:00
inline_fn_without_body.rs Fix clippy. 2020-05-11 21:26:39 +02:00
int_plus_one.rs Fix more code examples 2020-06-01 10:39:52 +02:00
integer_division.rs Fix more code examples 2020-06-01 10:39:52 +02:00
items_after_statements.rs Fix more code examples 2020-06-01 10:39:52 +02:00
large_const_arrays.rs Cleanup: Rename 'db' variable to 'diag' 2020-04-17 08:08:00 +02:00
large_enum_variant.rs Cleanup: Rename 'db' variable to 'diag' 2020-04-17 08:08:00 +02:00
large_stack_arrays.rs Add an Option<Span> argument to span_lint_and_help. 2020-04-18 18:28:29 +08:00
len_zero.rs len_zero: skip ranges if feature range_is_empty is not enabled 2020-05-28 00:58:48 +02:00
let_and_return.rs let_and_return: do not lint if last statement borrows 2020-06-07 20:53:38 +02:00
let_if_seq.rs Merge commit 'e214ea82ad0a751563acf67e1cd9279cf302db3a' into clippyup 2020-05-17 17:36:26 +02:00
let_underscore.rs Add an Option<Span> argument to span_lint_and_help. 2020-04-18 18:28:29 +08:00
lib.rs Auto merge of #5680 - ebroto:3792_let_return, r=Manishearth 2020-06-08 16:47:22 +00:00
lifetimes.rs don't emit lifetime lints for code inside macros. 2020-03-30 23:22:50 +02:00
literal_representation.rs Give more corrected code examples in doc 2020-06-01 10:39:52 +02:00
loops.rs Cleanup: Use rustc's same_types instead of our same_tys 2020-06-06 11:50:59 +02:00
macro_use.rs Rename macro_use_import -> macro_use_imports 2020-03-05 19:22:17 +01:00
main_recursion.rs Add an Option<Span> argument to span_lint_and_help. 2020-04-18 18:28:29 +08:00
manual_async_fn.rs Merge commit '43a1777b89cf6791f9e20878b4e5e3ae907867a5' into clippyup 2020-05-11 20:23:47 +02:00
manual_non_exhaustive.rs Merge commit '43a1777b89cf6791f9e20878b4e5e3ae907867a5' into clippyup 2020-05-11 20:23:47 +02:00
map_clone.rs Merge commit 'e214ea82ad0a751563acf67e1cd9279cf302db3a' into clippyup 2020-05-17 17:36:26 +02:00
map_unit_fn.rs Cleanup: Rename 'db' variable to 'diag' 2020-04-17 08:08:00 +02:00
match_on_vec_items.rs Merge commit '43a1777b89cf6791f9e20878b4e5e3ae907867a5' into clippyup 2020-05-11 20:23:47 +02:00
matches.rs match_wildcard_for_single_variants: remove empty line at start of lint example. 2020-06-04 03:34:22 +02:00
mem_discriminant.rs Cleanup: Rename 'db' variable to 'diag' 2020-04-17 08:08:00 +02:00
mem_forget.rs Rustup to rust-lang/rust#68045 2020-01-13 21:55:57 +09:00
mem_replace.rs Add an Option<Span> argument to span_lint_and_help. 2020-04-18 18:28:29 +08:00
minmax.rs Fix fallout 2020-02-21 11:14:18 +01:00
misc.rs dogfood unnested_or_patterns 2020-06-07 21:16:03 +02:00
misc_early.rs Give more corrected code examples in doc 2020-06-01 10:39:52 +02:00
missing_const_for_fn.rs Merge commit '7ea7cd165ad6705603852771bf82cc2fd6560db5' into clippyup2 2020-05-28 15:45:24 +02:00
missing_doc.rs rustup https://github.com/rust-lang/rust/pull/70536 2020-03-30 11:17:58 +02:00
missing_inline.rs Use OnceCell instead of Once 2020-05-22 13:31:02 -07:00
modulo_arithmetic.rs Revert "Fix cases of match_wildcard_for_single_variants lint when it is spanned on Option" 2020-05-15 22:33:37 +03:00
multiple_crate_versions.rs Add error info when cargo metadata fails to run 2020-06-05 22:28:58 +02:00
mut_key.rs rustup https://github.com/rust-lang/rust/pull/70536 2020-03-30 11:17:58 +02:00
mut_mut.rs rustup https://github.com/rust-lang/rust/pull/70536 2020-03-30 11:17:58 +02:00
mut_reference.rs Give more corrected code examples in doc 2020-06-01 10:39:52 +02:00
mutable_debug_assertion.rs Move cognitive_complexity to nursery 2020-04-08 08:37:20 -07:00
mutex_atomic.rs Give more corrected code examples in doc 2020-06-01 10:39:52 +02:00
needless_bool.rs Give more corrected code examples in doc 2020-06-01 10:39:52 +02:00
needless_borrow.rs Give more corrected code examples in doc 2020-06-01 10:39:52 +02:00
needless_borrowed_ref.rs Cleanup: Rename 'db' variable to 'diag' 2020-04-17 08:08:00 +02:00
needless_continue.rs New lint: iter_next_slice 2020-06-01 03:08:51 +07:00
needless_pass_by_value.rs Give more corrected code examples in doc 2020-06-01 10:39:52 +02:00
needless_update.rs Give more corrected code examples in doc 2020-06-01 10:39:52 +02:00
neg_cmp_op_on_partial_ord.rs Use integer assoc consts in more lint example code 2020-04-08 00:43:27 +02:00
neg_multiply.rs Fix fallout 2020-02-21 11:14:18 +01:00
new_without_default.rs Cleanup: Use rustc's same_types instead of our same_tys 2020-06-06 11:50:59 +02:00
no_effect.rs dogfood unnested_or_patterns 2020-06-07 21:16:03 +02:00
non_copy_const.rs Cleanup: Rename 'db' variable to 'diag' 2020-04-17 08:08:00 +02:00
non_expressive_names.rs Merge commit '7ea7cd165ad6705603852771bf82cc2fd6560db5' into clippyup2 2020-05-28 15:45:24 +02:00
open_options.rs Rustup to rust-lang/rust#69592 2020-03-01 12:23:33 +09:00
option_env_unwrap.rs Add an Option<Span> argument to span_lint_and_help. 2020-04-18 18:28:29 +08:00
overflow_check_conditional.rs Fix fallout 2020-02-21 11:14:18 +01:00
panic_unimplemented.rs Rustup to rust-lang/rust#69592 2020-03-01 12:23:33 +09:00
partialeq_ne_impl.rs Fix fallout 2020-02-21 11:14:18 +01:00
path_buf_push_overwrite.rs Rustup to rust-lang/rust#69592 2020-03-01 12:23:33 +09:00
precedence.rs Integrate more idiomatic rust changes. 2020-04-17 10:12:30 +02:00
ptr.rs Give more corrected code examples in doc 2020-06-01 10:39:52 +02:00
ptr_offset_with_cast.rs Clean up imports 2020-02-18 22:37:45 +09:00
question_mark.rs Give more corrected code examples in doc 2020-06-01 10:39:52 +02:00
ranges.rs Merge commit '7ea7cd165ad6705603852771bf82cc2fd6560db5' into clippyup2 2020-05-28 15:45:24 +02:00
redundant_clone.rs Update to rustc changes 2020-05-04 15:13:07 +02:00
redundant_field_names.rs Merge commit '7ea7cd165ad6705603852771bf82cc2fd6560db5' into clippyup2 2020-05-28 15:45:24 +02:00
redundant_pattern_matching.rs fix redundant_pattern_matching lint 2020-04-25 23:51:30 +03:00
redundant_pub_crate.rs rustup to https://github.com/rust-lang/rust/pull/70043 2020-04-26 10:12:14 +02:00
redundant_static_lifetimes.rs cargo dev fmt 2020-04-17 08:09:09 +02:00
reference.rs Give more corrected code examples in doc 2020-06-01 10:39:52 +02:00
regex.rs Give more corrected code examples in doc 2020-06-01 10:39:52 +02:00
returns.rs Make let_and_return a late lint pass 2020-06-07 20:53:38 +02:00
serde_api.rs Fix fallout 2020-02-21 11:14:18 +01:00
shadow.rs Give more corrected code examples in doc 2020-06-01 10:39:52 +02:00
single_component_path_imports.rs Give more corrected code examples in doc 2020-06-01 10:39:52 +02:00
slow_vector_initialization.rs Give more corrected code examples in doc 2020-06-01 10:39:52 +02:00
strings.rs Give more corrected code examples in doc 2020-06-01 10:39:52 +02:00
suspicious_trait_impl.rs dogfood unnested_or_patterns 2020-06-07 21:16:03 +02:00
swap.rs cargo dev fmt 2020-04-26 13:44:08 +02:00
tabs_in_doc_comments.rs Rustup to rust-lang/rust#69592 2020-03-01 12:23:33 +09:00
temporary_assignment.rs Clean up imports 2020-02-18 22:37:45 +09:00
to_digit_is_some.rs rustup https://github.com/rust-lang/rust/pull/70536 2020-03-30 11:17:58 +02:00
trait_bounds.rs Add an Option<Span> argument to span_lint_and_help. 2020-04-18 18:28:29 +08:00
transmute.rs dogfood unnested_or_patterns 2020-06-07 21:16:03 +02:00
transmuting_null.rs rustup https://github.com/rust-lang/rust/pull/70536 2020-03-30 11:17:58 +02:00
trivially_copy_pass_by_ref.rs Merge commit '7ea7cd165ad6705603852771bf82cc2fd6560db5' into clippyup2 2020-05-28 15:45:24 +02:00
try_err.rs rustup https://github.com/rust-lang/rust/pull/70536 2020-03-30 11:17:58 +02:00
types.rs Cleanup: Use rustc's same_types instead of our same_tys 2020-06-06 11:50:59 +02:00
unicode.rs Rustup to rust-lang/rust#69592 2020-03-01 12:23:33 +09:00
unnamed_address.rs Add an Option<Span> argument to span_lint_and_help. 2020-04-18 18:28:29 +08:00
unnecessary_sort_by.rs Implement suggestions from phansch 2020-05-31 15:09:12 -07:00
unnested_or_patterns.rs Apply self-review by Centril 2020-06-07 21:16:05 +02:00
unsafe_removed_from_name.rs Fix clippy. 2020-05-11 21:26:39 +02:00
unused_io_amount.rs Auto merge of #5027 - sinkuu:vectored_io, r=phansch 2020-01-24 06:44:09 +00:00
unused_self.rs Add an Option<Span> argument to span_lint_and_help. 2020-04-18 18:28:29 +08:00
unwrap.rs dogfood unnested_or_patterns 2020-06-07 21:16:03 +02:00
use_self.rs rustup https://github.com/rust-lang/rust/pull/70643 2020-04-14 12:25:45 +02:00
useless_conversion.rs Cleanup: Use rustc's same_types instead of our same_tys 2020-06-06 11:50:59 +02:00
vec.rs Add more corrected code for doc 2020-06-01 10:39:52 +02:00
vec_resize_to_zero.rs new lint: vec_resize_to_zero 2020-05-30 17:52:10 +02:00
verbose_file_reads.rs Add more corrected code for doc 2020-06-01 10:39:52 +02:00
wildcard_dependencies.rs Add error info when cargo metadata fails to run 2020-06-05 22:28:58 +02:00
wildcard_imports.rs Add more corrected code for doc 2020-06-01 10:39:52 +02:00
write.rs Merge remote-tracking branch 'upstream/master' into rustup 2020-06-07 02:17:49 +02:00
zero_div_zero.rs Add more corrected code for doc 2020-06-01 10:39:52 +02:00