mirror of
https://github.com/rust-lang/rust-clippy
synced 2024-11-10 15:14:29 +00:00
200 lines
7.8 KiB
Text
200 lines
7.8 KiB
Text
error: this argument is passed by value, but not consumed in the function body
|
|
--> $DIR/needless_pass_by_value.rs:24:23
|
|
|
|
|
LL | fn foo<T: Default>(v: Vec<T>, w: Vec<T>, mut x: Vec<T>, y: Vec<T>) -> Vec<T> {
|
|
| ^^^^^^ help: consider changing the type to: `&[T]`
|
|
|
|
|
= note: `-D clippy::needless-pass-by-value` implied by `-D warnings`
|
|
|
|
error: this argument is passed by value, but not consumed in the function body
|
|
--> $DIR/needless_pass_by_value.rs:38:11
|
|
|
|
|
LL | fn bar(x: String, y: Wrapper) {
|
|
| ^^^^^^ help: consider changing the type to: `&str`
|
|
|
|
error: this argument is passed by value, but not consumed in the function body
|
|
--> $DIR/needless_pass_by_value.rs:38:22
|
|
|
|
|
LL | fn bar(x: String, y: Wrapper) {
|
|
| ^^^^^^^ help: consider taking a reference instead: `&Wrapper`
|
|
|
|
error: this argument is passed by value, but not consumed in the function body
|
|
--> $DIR/needless_pass_by_value.rs:44:71
|
|
|
|
|
LL | fn test_borrow_trait<T: Borrow<str>, U: AsRef<str>, V>(t: T, u: U, v: V) {
|
|
| ^ help: consider taking a reference instead: `&V`
|
|
|
|
error: this argument is passed by value, but not consumed in the function body
|
|
--> $DIR/needless_pass_by_value.rs:56:18
|
|
|
|
|
LL | fn test_match(x: Option<Option<String>>, y: Option<Option<String>>) {
|
|
| ^^^^^^^^^^^^^^^^^^^^^^
|
|
help: consider taking a reference instead
|
|
|
|
|
LL | fn test_match(x: &Option<Option<String>>, y: Option<Option<String>>) {
|
|
LL | match *x {
|
|
|
|
|
|
|
error: this argument is passed by value, but not consumed in the function body
|
|
--> $DIR/needless_pass_by_value.rs:69:24
|
|
|
|
|
LL | fn test_destructure(x: Wrapper, y: Wrapper, z: Wrapper) {
|
|
| ^^^^^^^ help: consider taking a reference instead: `&Wrapper`
|
|
|
|
error: this argument is passed by value, but not consumed in the function body
|
|
--> $DIR/needless_pass_by_value.rs:69:36
|
|
|
|
|
LL | fn test_destructure(x: Wrapper, y: Wrapper, z: Wrapper) {
|
|
| ^^^^^^^
|
|
help: consider taking a reference instead
|
|
|
|
|
LL | fn test_destructure(x: Wrapper, y: &Wrapper, z: Wrapper) {
|
|
LL | let Wrapper(s) = z; // moved
|
|
LL | let Wrapper(ref t) = *y; // not moved
|
|
LL | let Wrapper(_) = *y; // still not moved
|
|
|
|
|
|
|
error: this argument is passed by value, but not consumed in the function body
|
|
--> $DIR/needless_pass_by_value.rs:85:49
|
|
|
|
|
LL | fn test_blanket_ref<T: Foo, S: Serialize>(_foo: T, _serializable: S) {}
|
|
| ^ help: consider taking a reference instead: `&T`
|
|
|
|
error: this argument is passed by value, but not consumed in the function body
|
|
--> $DIR/needless_pass_by_value.rs:87:18
|
|
|
|
|
LL | fn issue_2114(s: String, t: String, u: Vec<i32>, v: Vec<i32>) {
|
|
| ^^^^^^ help: consider taking a reference instead: `&String`
|
|
|
|
error: this argument is passed by value, but not consumed in the function body
|
|
--> $DIR/needless_pass_by_value.rs:87:29
|
|
|
|
|
LL | fn issue_2114(s: String, t: String, u: Vec<i32>, v: Vec<i32>) {
|
|
| ^^^^^^
|
|
help: consider changing the type to
|
|
|
|
|
LL | fn issue_2114(s: String, t: &str, u: Vec<i32>, v: Vec<i32>) {
|
|
| ^^^^
|
|
help: change `t.clone()` to
|
|
|
|
|
LL | let _ = t.to_string();
|
|
| ^^^^^^^^^^^^^
|
|
|
|
error: this argument is passed by value, but not consumed in the function body
|
|
--> $DIR/needless_pass_by_value.rs:87:40
|
|
|
|
|
LL | fn issue_2114(s: String, t: String, u: Vec<i32>, v: Vec<i32>) {
|
|
| ^^^^^^^^ help: consider taking a reference instead: `&Vec<i32>`
|
|
|
|
error: this argument is passed by value, but not consumed in the function body
|
|
--> $DIR/needless_pass_by_value.rs:87:53
|
|
|
|
|
LL | fn issue_2114(s: String, t: String, u: Vec<i32>, v: Vec<i32>) {
|
|
| ^^^^^^^^
|
|
help: consider changing the type to
|
|
|
|
|
LL | fn issue_2114(s: String, t: String, u: Vec<i32>, v: &[i32]) {
|
|
| ^^^^^^
|
|
help: change `v.clone()` to
|
|
|
|
|
LL | let _ = v.to_owned();
|
|
| ^^^^^^^^^^^^
|
|
|
|
error: this argument is passed by value, but not consumed in the function body
|
|
--> $DIR/needless_pass_by_value.rs:100:12
|
|
|
|
|
LL | s: String,
|
|
| ^^^^^^ help: consider changing the type to: `&str`
|
|
|
|
error: this argument is passed by value, but not consumed in the function body
|
|
--> $DIR/needless_pass_by_value.rs:101:12
|
|
|
|
|
LL | t: String,
|
|
| ^^^^^^ help: consider taking a reference instead: `&String`
|
|
|
|
error: this argument is passed by value, but not consumed in the function body
|
|
--> $DIR/needless_pass_by_value.rs:110:23
|
|
|
|
|
LL | fn baz(&self, _u: U, _s: Self) {}
|
|
| ^ help: consider taking a reference instead: `&U`
|
|
|
|
error: this argument is passed by value, but not consumed in the function body
|
|
--> $DIR/needless_pass_by_value.rs:110:30
|
|
|
|
|
LL | fn baz(&self, _u: U, _s: Self) {}
|
|
| ^^^^ help: consider taking a reference instead: `&Self`
|
|
|
|
error: this argument is passed by value, but not consumed in the function body
|
|
--> $DIR/needless_pass_by_value.rs:132:24
|
|
|
|
|
LL | fn bar_copy(x: u32, y: CopyWrapper) {
|
|
| ^^^^^^^^^^^ help: consider taking a reference instead: `&CopyWrapper`
|
|
|
|
|
help: consider marking this type as Copy
|
|
--> $DIR/needless_pass_by_value.rs:130:1
|
|
|
|
|
LL | struct CopyWrapper(u32);
|
|
| ^^^^^^^^^^^^^^^^^^^^^^^^
|
|
|
|
error: this argument is passed by value, but not consumed in the function body
|
|
--> $DIR/needless_pass_by_value.rs:138:29
|
|
|
|
|
LL | fn test_destructure_copy(x: CopyWrapper, y: CopyWrapper, z: CopyWrapper) {
|
|
| ^^^^^^^^^^^ help: consider taking a reference instead: `&CopyWrapper`
|
|
|
|
|
help: consider marking this type as Copy
|
|
--> $DIR/needless_pass_by_value.rs:130:1
|
|
|
|
|
LL | struct CopyWrapper(u32);
|
|
| ^^^^^^^^^^^^^^^^^^^^^^^^
|
|
|
|
error: this argument is passed by value, but not consumed in the function body
|
|
--> $DIR/needless_pass_by_value.rs:138:45
|
|
|
|
|
LL | fn test_destructure_copy(x: CopyWrapper, y: CopyWrapper, z: CopyWrapper) {
|
|
| ^^^^^^^^^^^
|
|
|
|
|
help: consider marking this type as Copy
|
|
--> $DIR/needless_pass_by_value.rs:130:1
|
|
|
|
|
LL | struct CopyWrapper(u32);
|
|
| ^^^^^^^^^^^^^^^^^^^^^^^^
|
|
help: consider taking a reference instead
|
|
|
|
|
LL | fn test_destructure_copy(x: CopyWrapper, y: &CopyWrapper, z: CopyWrapper) {
|
|
LL | let CopyWrapper(s) = z; // moved
|
|
LL | let CopyWrapper(ref t) = *y; // not moved
|
|
LL | let CopyWrapper(_) = *y; // still not moved
|
|
|
|
|
|
|
error: this argument is passed by value, but not consumed in the function body
|
|
--> $DIR/needless_pass_by_value.rs:138:61
|
|
|
|
|
LL | fn test_destructure_copy(x: CopyWrapper, y: CopyWrapper, z: CopyWrapper) {
|
|
| ^^^^^^^^^^^
|
|
|
|
|
help: consider marking this type as Copy
|
|
--> $DIR/needless_pass_by_value.rs:130:1
|
|
|
|
|
LL | struct CopyWrapper(u32);
|
|
| ^^^^^^^^^^^^^^^^^^^^^^^^
|
|
help: consider taking a reference instead
|
|
|
|
|
LL | fn test_destructure_copy(x: CopyWrapper, y: CopyWrapper, z: &CopyWrapper) {
|
|
LL | let CopyWrapper(s) = *z; // moved
|
|
|
|
|
|
|
error: this argument is passed by value, but not consumed in the function body
|
|
--> $DIR/needless_pass_by_value.rs:150:40
|
|
|
|
|
LL | fn some_fun<'b, S: Bar<'b, ()>>(_item: S) {}
|
|
| ^ help: consider taking a reference instead: `&S`
|
|
|
|
error: this argument is passed by value, but not consumed in the function body
|
|
--> $DIR/needless_pass_by_value.rs:155:20
|
|
|
|
|
LL | fn more_fun(_item: impl Club<'static, i32>) {}
|
|
| ^^^^^^^^^^^^^^^^^^^^^^^ help: consider taking a reference instead: `&impl Club<'static, i32>`
|
|
|
|
error: aborting due to 22 previous errors
|
|
|