mirror of
https://github.com/rust-lang/rust-clippy
synced 2024-12-04 02:20:04 +00:00
47 lines
2.2 KiB
Text
47 lines
2.2 KiB
Text
error: you are using an explicit closure for copying elements
|
|
--> $DIR/map_clone.rs:12:22
|
|
|
|
|
LL | let _: Vec<i8> = vec![5_i8; 6].iter().map(|x| *x).collect();
|
|
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider calling the dedicated `copied` method: `vec![5_i8; 6].iter().copied()`
|
|
|
|
|
= note: `-D clippy::map-clone` implied by `-D warnings`
|
|
= help: to override `-D warnings` add `#[allow(clippy::map_clone)]`
|
|
|
|
error: you are using an explicit closure for cloning elements
|
|
--> $DIR/map_clone.rs:13:26
|
|
|
|
|
LL | let _: Vec<String> = vec![String::new()].iter().map(|x| x.clone()).collect();
|
|
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider calling the dedicated `cloned` method: `vec![String::new()].iter().cloned()`
|
|
|
|
error: you are using an explicit closure for copying elements
|
|
--> $DIR/map_clone.rs:14:23
|
|
|
|
|
LL | let _: Vec<u32> = vec![42, 43].iter().map(|&x| x).collect();
|
|
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider calling the dedicated `copied` method: `vec![42, 43].iter().copied()`
|
|
|
|
error: you are using an explicit closure for copying elements
|
|
--> $DIR/map_clone.rs:16:26
|
|
|
|
|
LL | let _: Option<u64> = Some(&16).map(|b| *b);
|
|
| ^^^^^^^^^^^^^^^^^^^^^ help: consider calling the dedicated `copied` method: `Some(&16).copied()`
|
|
|
|
error: you are using an explicit closure for copying elements
|
|
--> $DIR/map_clone.rs:17:25
|
|
|
|
|
LL | let _: Option<u8> = Some(&1).map(|x| x.clone());
|
|
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider calling the dedicated `copied` method: `Some(&1).copied()`
|
|
|
|
error: you are needlessly cloning iterator elements
|
|
--> $DIR/map_clone.rs:28:29
|
|
|
|
|
LL | let _ = std::env::args().map(|v| v.clone());
|
|
| ^^^^^^^^^^^^^^^^^^^ help: remove the `map` call
|
|
|
|
error: you are explicitly cloning with `.map()`
|
|
--> $DIR/map_clone.rs:66:13
|
|
|
|
|
LL | let y = x.as_ref().map(|x| String::clone(x));
|
|
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider calling the dedicated `cloned` method: `x.as_ref().cloned()`
|
|
|
|
error: aborting due to 7 previous errors
|
|
|