mirror of
https://github.com/rust-lang/rust-clippy
synced 2024-12-22 19:13:29 +00:00
48bff49484
This splits up `tests/ui/checked_unwrap.rs` into: * `tests/ui/checked_unwrap/complex.rs` * `tests/ui/checked_unwrap/simple.rs` Based on the naming of the methods in the tests. cc #2038
65 lines
1.9 KiB
Rust
65 lines
1.9 KiB
Rust
#![deny(clippy::panicking_unwrap, clippy::unnecessary_unwrap)]
|
|
#![allow(clippy::if_same_then_else)]
|
|
|
|
fn test_complex_conditions() {
|
|
let x: Result<(), ()> = Ok(());
|
|
let y: Result<(), ()> = Ok(());
|
|
if x.is_ok() && y.is_err() {
|
|
x.unwrap(); // unnecessary
|
|
x.unwrap_err(); // will panic
|
|
y.unwrap(); // will panic
|
|
y.unwrap_err(); // unnecessary
|
|
} else {
|
|
// not statically determinable whether any of the following will always succeed or always fail:
|
|
x.unwrap();
|
|
x.unwrap_err();
|
|
y.unwrap();
|
|
y.unwrap_err();
|
|
}
|
|
|
|
if x.is_ok() || y.is_ok() {
|
|
// not statically determinable whether any of the following will always succeed or always fail:
|
|
x.unwrap();
|
|
y.unwrap();
|
|
} else {
|
|
x.unwrap(); // will panic
|
|
x.unwrap_err(); // unnecessary
|
|
y.unwrap(); // will panic
|
|
y.unwrap_err(); // unnecessary
|
|
}
|
|
let z: Result<(), ()> = Ok(());
|
|
if x.is_ok() && !(y.is_ok() || z.is_err()) {
|
|
x.unwrap(); // unnecessary
|
|
x.unwrap_err(); // will panic
|
|
y.unwrap(); // will panic
|
|
y.unwrap_err(); // unnecessary
|
|
z.unwrap(); // unnecessary
|
|
z.unwrap_err(); // will panic
|
|
}
|
|
if x.is_ok() || !(y.is_ok() && z.is_err()) {
|
|
// not statically determinable whether any of the following will always succeed or always fail:
|
|
x.unwrap();
|
|
y.unwrap();
|
|
z.unwrap();
|
|
} else {
|
|
x.unwrap(); // will panic
|
|
x.unwrap_err(); // unnecessary
|
|
y.unwrap(); // unnecessary
|
|
y.unwrap_err(); // will panic
|
|
z.unwrap(); // will panic
|
|
z.unwrap_err(); // unnecessary
|
|
}
|
|
}
|
|
|
|
fn test_nested() {
|
|
fn nested() {
|
|
let x = Some(());
|
|
if x.is_some() {
|
|
x.unwrap(); // unnecessary
|
|
} else {
|
|
x.unwrap(); // will panic
|
|
}
|
|
}
|
|
}
|
|
|
|
fn main() {}
|