Mirrors/rust-clippy
2
0
Fork 0
mirror of https://github.com/rust-lang/rust-clippy synced 2025-01-12 05:08:43 +00:00
Code Issues Projects Releases Packages Wiki Activity
rust-clippy/clippy_lints/src/methods
History
bors f70c73f5c4 Auto merge of #8692 - kyoto7250:fixing_unnecessary_to_owned, r=giraffate 
fix unnecessary_to_owned about msrv

This PR fixes ``[`unnecessary_owned`]``.

## What

```rust
# sample code
fn _msrv_1_35() {
    #![clippy::msrv = "1.35"]
    let _ = &["x"][..].to_vec().into_iter();
}

fn _msrv_1_36() {
    #![clippy::msrv = "1.36"]
    let _ = &["x"][..].to_vec().into_iter();
}
```

If we will check this code using clippy, ``[`unnecessary_owned`]`` will modify the code as follows.

```rust
error: unnecessary use of `to_vec`
  --> $DIR/unnecessary_to_owned.rs:219:14
   |
LL |     let _ = &["x"][..].to_vec().into_iter();
   |              ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `["x"][..].iter().copied()`

error: unnecessary use of `to_vec`
  --> $DIR/unnecessary_to_owned.rs:224:14
   |
LL |     let _ = &["x"][..].to_vec().into_iter();
   |              ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `["x"][..].iter().copied()`
```

This is incorrect. Because `Iterator::copied` was estabilished in 1.36.

## Why

This bug was caused by not separating "copied" and "clone" by reference to msrv.

89ee6aa6e3/clippy_lints/src/methods/unnecessary_to_owned.rs (L195)

So, I added a conditional branch and described the corresponding test.

Thank you in advance.

changelog: fix wrong suggestions about msrv in [`unnecessary_to_owned`]

r! `@giraffate`
2022-04-13 00:57:08 +00:00
..
bind_instead_of_map.rs Improve AdtDef interning. 2022-03-11 13:31:24 +11:00
bytes_nth.rs fix mispelling in diagnostic message of bytes_nth 2022-04-05 10:53:10 +01:00
chars_cmp.rs Merge commit '57b3c4b90f4346b3990c1be387c3b3ca7b78412c' into clippyup 2022-02-10 18:40:06 +01:00
chars_cmp_with_unwrap.rs Merge commit '57b3c4b90f4346b3990c1be387c3b3ca7b78412c' into clippyup 2022-02-10 18:40:06 +01:00
chars_last_cmp.rs Merge commit '0e87918536b9833bbc6c683d1f9d51ee2bf03ef1' into clippyup 2021-03-25 19:29:11 +01:00
chars_last_cmp_with_unwrap.rs Merge commit '0e87918536b9833bbc6c683d1f9d51ee2bf03ef1' into clippyup 2021-03-25 19:29:11 +01:00
chars_next_cmp.rs Merge commit '0e87918536b9833bbc6c683d1f9d51ee2bf03ef1' into clippyup 2021-03-25 19:29:11 +01:00
chars_next_cmp_with_unwrap.rs Merge commit '0e87918536b9833bbc6c683d1f9d51ee2bf03ef1' into clippyup 2021-03-25 19:29:11 +01:00
clone_on_copy.rs Remove a span from hir::ExprKind::MethodCall 2022-01-21 07:48:10 -06:00
clone_on_ref_ptr.rs Merge commit '0e87918536b9833bbc6c683d1f9d51ee2bf03ef1' into clippyup 2021-03-25 19:29:11 +01:00
cloned_instead_of_copied.rs Improve AdtDef interning. 2022-03-11 13:31:24 +11:00
err_expect.rs Fix mistakes in documentation : 2022-04-06 19:25:58 +02:00
expect_fun_call.rs Remember mutability in DefKind::Static. 2022-03-29 18:50:52 +02:00
expect_used.rs Make diangostic item names consistent 2021-10-02 19:38:19 -05:00
extend_with_drain.rs Remove a span from hir::ExprKind::MethodCall 2022-01-21 07:48:10 -06:00
filetype_is_file.rs Merge commit 'b40ea209e7f14c8193ddfc98143967b6a2f4f5c9' into clippyup 2021-04-08 17:50:13 +02:00
filter_map.rs Improve AdtDef interning. 2022-03-11 13:31:24 +11:00
filter_map_identity.rs Merge commit '61eb38aeda6cb54b93b872bf503d70084c4d621c' into clippyup 2021-07-01 18:17:38 +02:00
filter_map_next.rs Merge commit '7c7683c8efe447b251d6c5ca6cce51233060f6e8' into clippyup 2021-04-27 16:55:11 +02:00
filter_next.rs Merge commit '27afd6ade4bb1123a8bf82001629b69d23d62aff' into clippyup 2021-09-08 16:31:47 +02:00
flat_map_identity.rs Merge commit '61eb38aeda6cb54b93b872bf503d70084c4d621c' into clippyup 2021-07-01 18:17:38 +02:00
flat_map_option.rs Make diangostic item names consistent 2021-10-02 19:38:19 -05:00
from_iter_instead_of_collect.rs Merge commit '97a5daa65908e59744e2bc625b14849352231c75' into clippyup 2022-01-13 13:18:19 +01:00
get_unwrap.rs Make diangostic item names consistent 2021-10-02 19:38:19 -05:00
implicit_clone.rs Merge remote-tracking branch 'upstream/master' into rustup 2022-04-07 15:44:37 +01:00
inefficient_to_string.rs Improve AdtDef interning. 2022-03-11 13:31:24 +11:00
inspect_for_each.rs Merge commit '0e87918536b9833bbc6c683d1f9d51ee2bf03ef1' into clippyup 2021-03-25 19:29:11 +01:00
into_iter_on_ref.rs Merge commit '0e87918536b9833bbc6c683d1f9d51ee2bf03ef1' into clippyup 2021-03-25 19:29:11 +01:00
is_digit_ascii_radix.rs New lint is_digit_ascii_radix 2022-04-07 14:14:30 -06:00
iter_cloned_collect.rs Merge commit 'a5d597637dcb78dc73f93561ce474f23d4177c35' into clippyup 2021-12-06 12:33:31 +01:00
iter_count.rs Make diangostic item names consistent 2021-10-02 19:38:19 -05:00
iter_next_slice.rs Make diangostic item names consistent 2021-10-02 19:38:19 -05:00
iter_nth.rs Make diangostic item names consistent 2021-10-02 19:38:19 -05:00
iter_nth_zero.rs Merge commit '3ae8faff4d46ad92f194c2a4b941c3152a701b31' into clippyup 2021-06-03 08:41:37 +02:00
iter_overeager_cloned.rs Fix ICE for iter_overeager_cloned 2022-03-29 21:51:37 +09:00
iter_skip_next.rs Merge commit '0eff589afc83e21a03a168497bbab6b4dfbb4ef6' into clippyup 2021-12-30 15:10:43 +01:00
iter_with_drain.rs Don't lint iter_with_drain on references 2022-04-08 23:41:50 -04:00
iterator_step_by_zero.rs Merge commit '3ae8faff4d46ad92f194c2a4b941c3152a701b31' into clippyup 2021-06-03 08:41:37 +02:00
manual_saturating_arithmetic.rs Merge commit '57b3c4b90f4346b3990c1be387c3b3ca7b78412c' into clippyup 2022-02-10 18:40:06 +01:00
manual_str_repeat.rs Overhaul TyS and Ty. 2022-02-15 16:03:24 +11:00
map_collect_result_unit.rs Make diangostic item names consistent 2021-10-02 19:38:19 -05:00
map_flatten.rs Merge commit 'd0cf3481a84e3aa68c2f185c460e282af36ebc42' into clippyup 2022-03-24 14:50:04 +01:00
map_identity.rs map_identity checks for unneeded .map_err 2022-03-01 12:47:55 +08:00
map_unwrap_or.rs Make diangostic item names consistent 2021-10-02 19:38:19 -05:00
mod.rs Auto merge of #8692 - kyoto7250:fixing_unnecessary_to_owned, r=giraffate 2022-04-13 00:57:08 +00:00
needless_option_as_deref.rs Fix as_deref_mut false positives in needless_option_as_deref 2022-04-07 12:39:21 +01:00
ok_expect.rs Make diangostic item names consistent 2021-10-02 19:38:19 -05:00
option_as_ref_deref.rs Remove a span from hir::ExprKind::MethodCall 2022-01-21 07:48:10 -06:00
option_map_or_none.rs Merge commit 'dc5423ad448877e33cca28db2f1445c9c4473c75' into clippyup 2022-03-14 12:02:53 +01:00
option_map_unwrap_or.rs Merge commit '57b3c4b90f4346b3990c1be387c3b3ca7b78412c' into clippyup 2022-02-10 18:40:06 +01:00
or_fun_call.rs Merge commit '8d14c94b5c0a66241b4244f1c60ac5859cec1d97' into clippyup 2022-01-17 13:29:07 +01:00
or_then_unwrap.rs Merge commit 'd0cf3481a84e3aa68c2f185c460e282af36ebc42' into clippyup 2022-03-24 14:50:04 +01:00
search_is_some.rs Merge commit 'a5d597637dcb78dc73f93561ce474f23d4177c35' into clippyup 2021-12-06 12:33:31 +01:00
single_char_add_str.rs Merge commit '0e87918536b9833bbc6c683d1f9d51ee2bf03ef1' into clippyup 2021-03-25 19:29:11 +01:00
single_char_insert_string.rs Merge commit '0e87918536b9833bbc6c683d1f9d51ee2bf03ef1' into clippyup 2021-03-25 19:29:11 +01:00
single_char_pattern.rs Merge commit 'a5d597637dcb78dc73f93561ce474f23d4177c35' into clippyup 2021-12-06 12:33:31 +01:00
single_char_push_string.rs Merge commit '0e87918536b9833bbc6c683d1f9d51ee2bf03ef1' into clippyup 2021-03-25 19:29:11 +01:00
skip_while_next.rs Merge commit 'b40ea209e7f14c8193ddfc98143967b6a2f4f5c9' into clippyup 2021-04-08 17:50:13 +02:00
str_splitn.rs Remove overlap between manual_split_once and needless_splitn 2022-04-10 17:05:07 +01:00
string_extend_chars.rs Make diangostic item names consistent 2021-10-02 19:38:19 -05:00
suspicious_map.rs Merge commit 'b7f3f7f6082679da2da9a0b3faf1b5adef3afd3b' into clippyup 2021-10-07 11:21:30 +02:00
suspicious_splitn.rs get clippy to compile again 2022-03-30 11:23:58 +02:00
uninit_assumed_init.rs Merge commit 'e329249b6a3a98830d860c74c8234a8dd9407436' into clippyup 2022-02-26 14:26:21 +01:00
unnecessary_filter_map.rs Merge commit 'dc5423ad448877e33cca28db2f1445c9c4473c75' into clippyup 2022-03-14 12:02:53 +01:00
unnecessary_fold.rs Merge commit '23d11428de3e973b34a5090a78d62887f821c90e' into clippyup 2021-12-17 13:40:22 +01:00
unnecessary_iter_cloned.rs Merge commit 'dc5423ad448877e33cca28db2f1445c9c4473c75' into clippyup 2022-03-14 12:02:53 +01:00
unnecessary_join.rs Merge commit 'd0cf3481a84e3aa68c2f185c460e282af36ebc42' into clippyup 2022-03-24 14:50:04 +01:00
unnecessary_lazy_eval.rs Merge commit 'd0cf3481a84e3aa68c2f185c460e282af36ebc42' into clippyup 2022-03-24 14:50:04 +01:00
unnecessary_to_owned.rs fix unnecessary_to_owned about msrv 2022-04-12 22:59:25 +09:00
unwrap_or_else_default.rs Merge commit '0eff589afc83e21a03a168497bbab6b4dfbb4ef6' into clippyup 2021-12-30 15:10:43 +01:00
unwrap_used.rs Make diangostic item names consistent 2021-10-02 19:38:19 -05:00
useless_asref.rs Remove a span from hir::ExprKind::MethodCall 2022-01-21 07:48:10 -06:00
utils.rs Merge commit 'dc5423ad448877e33cca28db2f1445c9c4473c75' into clippyup 2022-03-14 12:02:53 +01:00
wrong_self_convention.rs Overhaul TyS and Ty. 2022-02-15 16:03:24 +11:00
zst_offset.rs Overhaul TyS and Ty. 2022-02-15 16:03:24 +11:00