mirror of
https://github.com/rust-lang/rust-clippy
synced 2024-09-20 14:41:58 +00:00
176 lines
4.8 KiB
Text
176 lines
4.8 KiB
Text
error: this pattern reimplements `Option::unwrap_or`
|
|
--> tests/ui/manual_unwrap_or.rs:11:5
|
|
|
|
|
LL | / match Some(1) {
|
|
LL | | Some(i) => i,
|
|
LL | | None => 42,
|
|
LL | | };
|
|
| |_____^ help: replace with: `Some(1).unwrap_or(42)`
|
|
|
|
|
= note: `-D clippy::manual-unwrap-or` implied by `-D warnings`
|
|
= help: to override `-D warnings` add `#[allow(clippy::manual_unwrap_or)]`
|
|
|
|
error: this pattern reimplements `Option::unwrap_or`
|
|
--> tests/ui/manual_unwrap_or.rs:17:5
|
|
|
|
|
LL | / match Some(1) {
|
|
LL | | None => 42,
|
|
LL | | Some(i) => i,
|
|
LL | | };
|
|
| |_____^ help: replace with: `Some(1).unwrap_or(42)`
|
|
|
|
error: this pattern reimplements `Option::unwrap_or`
|
|
--> tests/ui/manual_unwrap_or.rs:23:5
|
|
|
|
|
LL | / match Some(1) {
|
|
LL | | Some(i) => i,
|
|
LL | | None => 1 + 42,
|
|
LL | | };
|
|
| |_____^ help: replace with: `Some(1).unwrap_or(1 + 42)`
|
|
|
|
error: this pattern reimplements `Option::unwrap_or`
|
|
--> tests/ui/manual_unwrap_or.rs:30:5
|
|
|
|
|
LL | / match Some(1) {
|
|
LL | | Some(i) => i,
|
|
LL | | None => {
|
|
LL | | 42 + 42
|
|
... |
|
|
LL | | }
|
|
LL | | };
|
|
| |_____^
|
|
|
|
|
help: replace with
|
|
|
|
|
LL ~ Some(1).unwrap_or({
|
|
LL + 42 + 42
|
|
LL + + 42 + 42 + 42
|
|
LL + + 42 + 42 + 42
|
|
LL ~ });
|
|
|
|
|
|
|
error: this pattern reimplements `Option::unwrap_or`
|
|
--> tests/ui/manual_unwrap_or.rs:40:5
|
|
|
|
|
LL | / match Some("Bob") {
|
|
LL | | Some(i) => i,
|
|
LL | | None => "Alice",
|
|
LL | | };
|
|
| |_____^ help: replace with: `Some("Bob").unwrap_or("Alice")`
|
|
|
|
error: this pattern reimplements `Option::unwrap_or`
|
|
--> tests/ui/manual_unwrap_or.rs:87:5
|
|
|
|
|
LL | / if let Some(x) = Some(1) {
|
|
LL | | x
|
|
LL | | } else {
|
|
LL | | 42
|
|
LL | | };
|
|
| |_____^ help: replace with: `Some(1).unwrap_or(42)`
|
|
|
|
error: this pattern reimplements `Result::unwrap_or`
|
|
--> tests/ui/manual_unwrap_or.rs:120:5
|
|
|
|
|
LL | / match Ok::<i32, &str>(1) {
|
|
LL | | Ok(i) => i,
|
|
LL | | Err(_) => 42,
|
|
LL | | };
|
|
| |_____^ help: replace with: `Ok::<i32, &str>(1).unwrap_or(42)`
|
|
|
|
error: this pattern reimplements `Result::unwrap_or`
|
|
--> tests/ui/manual_unwrap_or.rs:127:5
|
|
|
|
|
LL | / match a {
|
|
LL | | Ok(i) => i,
|
|
LL | | Err(_) => 42,
|
|
LL | | };
|
|
| |_____^ help: replace with: `a.unwrap_or(42)`
|
|
|
|
error: this pattern reimplements `Result::unwrap_or`
|
|
--> tests/ui/manual_unwrap_or.rs:133:5
|
|
|
|
|
LL | / match Ok(1) as Result<i32, &str> {
|
|
LL | | Ok(i) => i,
|
|
LL | | Err(_) => 42,
|
|
LL | | };
|
|
| |_____^ help: replace with: `(Ok(1) as Result<i32, &str>).unwrap_or(42)`
|
|
|
|
error: this pattern reimplements `Option::unwrap_or`
|
|
--> tests/ui/manual_unwrap_or.rs:146:5
|
|
|
|
|
LL | / match s.method() {
|
|
LL | | Some(i) => i,
|
|
LL | | None => 42,
|
|
LL | | };
|
|
| |_____^ help: replace with: `s.method().unwrap_or(42)`
|
|
|
|
error: this pattern reimplements `Result::unwrap_or`
|
|
--> tests/ui/manual_unwrap_or.rs:152:5
|
|
|
|
|
LL | / match Ok::<i32, &str>(1) {
|
|
LL | | Err(_) => 42,
|
|
LL | | Ok(i) => i,
|
|
LL | | };
|
|
| |_____^ help: replace with: `Ok::<i32, &str>(1).unwrap_or(42)`
|
|
|
|
error: this pattern reimplements `Result::unwrap_or`
|
|
--> tests/ui/manual_unwrap_or.rs:158:5
|
|
|
|
|
LL | / match Ok::<i32, &str>(1) {
|
|
LL | | Ok(i) => i,
|
|
LL | | Err(_) => 1 + 42,
|
|
LL | | };
|
|
| |_____^ help: replace with: `Ok::<i32, &str>(1).unwrap_or(1 + 42)`
|
|
|
|
error: this pattern reimplements `Result::unwrap_or`
|
|
--> tests/ui/manual_unwrap_or.rs:165:5
|
|
|
|
|
LL | / match Ok::<i32, &str>(1) {
|
|
LL | | Ok(i) => i,
|
|
LL | | Err(_) => {
|
|
LL | | 42 + 42
|
|
... |
|
|
LL | | }
|
|
LL | | };
|
|
| |_____^
|
|
|
|
|
help: replace with
|
|
|
|
|
LL ~ Ok::<i32, &str>(1).unwrap_or({
|
|
LL + 42 + 42
|
|
LL + + 42 + 42 + 42
|
|
LL + + 42 + 42 + 42
|
|
LL ~ });
|
|
|
|
|
|
|
error: this pattern reimplements `Result::unwrap_or`
|
|
--> tests/ui/manual_unwrap_or.rs:175:5
|
|
|
|
|
LL | / match Ok::<&str, &str>("Bob") {
|
|
LL | | Ok(i) => i,
|
|
LL | | Err(_) => "Alice",
|
|
LL | | };
|
|
| |_____^ help: replace with: `Ok::<&str, &str>("Bob").unwrap_or("Alice")`
|
|
|
|
error: this pattern reimplements `Result::unwrap_or`
|
|
--> tests/ui/manual_unwrap_or.rs:211:5
|
|
|
|
|
LL | / if let Ok(x) = Ok::<i32, i32>(1) {
|
|
LL | | x
|
|
LL | | } else {
|
|
LL | | 42
|
|
LL | | };
|
|
| |_____^ help: replace with: `Ok::<i32, i32>(1).unwrap_or(42)`
|
|
|
|
error: this pattern reimplements `Option::unwrap_or`
|
|
--> tests/ui/manual_unwrap_or.rs:265:17
|
|
|
|
|
LL | let _ = match some_macro!() {
|
|
| _________________^
|
|
LL | | Some(val) => val,
|
|
LL | | None => 0,
|
|
LL | | };
|
|
| |_________^ help: replace with: `some_macro!().unwrap_or(0)`
|
|
|
|
error: aborting due to 16 previous errors
|
|
|