mirror of
https://github.com/rust-lang/rust-clippy
synced 2024-11-10 15:14:29 +00:00
8b02dac542
side effect for `enum_variants`: use .first() instead of .get(0) in enum_variants lint move to_camel_case to str_util module move module, enum and struct name repetitions check to a single file `item_name_repetitions` rename enum_variants threshold config option
138 lines
4.2 KiB
Rust
138 lines
4.2 KiB
Rust
#![allow(dead_code)]
|
|
#![warn(clippy::manual_find_map)]
|
|
#![allow(clippy::redundant_closure)] // FIXME suggestion may have redundant closure
|
|
#![allow(clippy::useless_vec)]
|
|
#![allow(clippy::struct_field_names)]
|
|
|
|
fn main() {
|
|
// is_some(), unwrap()
|
|
let _ = (0..).find(|n| to_opt(*n).is_some()).map(|a| to_opt(a).unwrap());
|
|
|
|
// ref pattern, expect()
|
|
let _ = (0..).find(|&n| to_opt(n).is_some()).map(|a| to_opt(a).expect("hi"));
|
|
|
|
// is_ok(), unwrap_or()
|
|
let _ = (0..).find(|&n| to_res(n).is_ok()).map(|a| to_res(a).unwrap_or(1));
|
|
|
|
let _ = (1..5)
|
|
.find(|&x| to_ref(to_opt(x)).is_some())
|
|
.map(|y| to_ref(to_opt(y)).unwrap());
|
|
let _ = (1..5)
|
|
.find(|x| to_ref(to_opt(*x)).is_some())
|
|
.map(|y| to_ref(to_opt(y)).unwrap());
|
|
|
|
let _ = (1..5)
|
|
.find(|&x| to_ref(to_res(x)).is_ok())
|
|
.map(|y| to_ref(to_res(y)).unwrap());
|
|
let _ = (1..5)
|
|
.find(|x| to_ref(to_res(*x)).is_ok())
|
|
.map(|y| to_ref(to_res(y)).unwrap());
|
|
}
|
|
|
|
#[rustfmt::skip]
|
|
fn simple_equal() {
|
|
iter::<Option<u8>>().find(|x| x.is_some()).map(|x| x.unwrap());
|
|
iter::<&Option<u8>>().find(|x| x.is_some()).map(|x| x.unwrap());
|
|
iter::<&&Option<u8>>().find(|x| x.is_some()).map(|x| x.unwrap());
|
|
iter::<Option<&u8>>().find(|x| x.is_some()).map(|x| x.cloned().unwrap());
|
|
iter::<&Option<&u8>>().find(|x| x.is_some()).map(|x| x.cloned().unwrap());
|
|
iter::<&Option<String>>().find(|x| x.is_some()).map(|x| x.as_deref().unwrap());
|
|
iter::<Option<&String>>().find(|&x| to_ref(x).is_some()).map(|y| to_ref(y).cloned().unwrap());
|
|
|
|
iter::<Result<u8, ()>>().find(|x| x.is_ok()).map(|x| x.unwrap());
|
|
iter::<&Result<u8, ()>>().find(|x| x.is_ok()).map(|x| x.unwrap());
|
|
iter::<&&Result<u8, ()>>().find(|x| x.is_ok()).map(|x| x.unwrap());
|
|
iter::<Result<&u8, ()>>().find(|x| x.is_ok()).map(|x| x.cloned().unwrap());
|
|
iter::<&Result<&u8, ()>>().find(|x| x.is_ok()).map(|x| x.cloned().unwrap());
|
|
iter::<&Result<String, ()>>().find(|x| x.is_ok()).map(|x| x.as_deref().unwrap());
|
|
iter::<Result<&String, ()>>().find(|&x| to_ref(x).is_ok()).map(|y| to_ref(y).cloned().unwrap());
|
|
}
|
|
|
|
fn no_lint() {
|
|
// no shared code
|
|
let _ = (0..).filter(|n| *n > 1).map(|n| n + 1);
|
|
|
|
// very close but different since filter() provides a reference
|
|
let _ = (0..).find(|n| to_opt(n).is_some()).map(|a| to_opt(a).unwrap());
|
|
|
|
// similar but different
|
|
let _ = (0..).find(|n| to_opt(n).is_some()).map(|n| to_res(n).unwrap());
|
|
let _ = (0..)
|
|
.find(|n| to_opt(n).map(|n| n + 1).is_some())
|
|
.map(|a| to_opt(a).unwrap());
|
|
}
|
|
|
|
fn iter<T>() -> impl Iterator<Item = T> {
|
|
std::iter::empty()
|
|
}
|
|
|
|
fn to_opt<T>(_: T) -> Option<T> {
|
|
unimplemented!()
|
|
}
|
|
|
|
fn to_res<T>(_: T) -> Result<T, ()> {
|
|
unimplemented!()
|
|
}
|
|
|
|
fn to_ref<'a, T>(_: T) -> &'a T {
|
|
unimplemented!()
|
|
}
|
|
|
|
struct Issue8920<'a> {
|
|
option_field: Option<String>,
|
|
result_field: Result<String, ()>,
|
|
ref_field: Option<&'a usize>,
|
|
}
|
|
|
|
fn issue_8920() {
|
|
let mut vec = vec![Issue8920 {
|
|
option_field: Some(String::from("str")),
|
|
result_field: Ok(String::from("str")),
|
|
ref_field: Some(&1),
|
|
}];
|
|
|
|
let _ = vec
|
|
.iter()
|
|
.find(|f| f.option_field.is_some())
|
|
.map(|f| f.option_field.clone().unwrap());
|
|
|
|
let _ = vec
|
|
.iter()
|
|
.find(|f| f.ref_field.is_some())
|
|
.map(|f| f.ref_field.cloned().unwrap());
|
|
|
|
let _ = vec
|
|
.iter()
|
|
.find(|f| f.ref_field.is_some())
|
|
.map(|f| f.ref_field.copied().unwrap());
|
|
|
|
let _ = vec
|
|
.iter()
|
|
.find(|f| f.result_field.is_ok())
|
|
.map(|f| f.result_field.clone().unwrap());
|
|
|
|
let _ = vec
|
|
.iter()
|
|
.find(|f| f.result_field.is_ok())
|
|
.map(|f| f.result_field.as_ref().unwrap());
|
|
|
|
let _ = vec
|
|
.iter()
|
|
.find(|f| f.result_field.is_ok())
|
|
.map(|f| f.result_field.as_deref().unwrap());
|
|
|
|
let _ = vec
|
|
.iter_mut()
|
|
.find(|f| f.result_field.is_ok())
|
|
.map(|f| f.result_field.as_mut().unwrap());
|
|
|
|
let _ = vec
|
|
.iter_mut()
|
|
.find(|f| f.result_field.is_ok())
|
|
.map(|f| f.result_field.as_deref_mut().unwrap());
|
|
|
|
let _ = vec
|
|
.iter()
|
|
.find(|f| f.result_field.is_ok())
|
|
.map(|f| f.result_field.to_owned().unwrap());
|
|
}
|