mirror of
https://github.com/rust-lang/rust-clippy
synced 2024-11-23 21:23:56 +00:00
ed43385cab
Update the test `redundant_pattern_matching`: check if `is_some` and `is_none` are suggested within const contexts.
158 lines
2.8 KiB
Rust
158 lines
2.8 KiB
Rust
// run-rustfix
|
|
|
|
#![warn(clippy::all)]
|
|
#![warn(clippy::redundant_pattern_matching)]
|
|
#![allow(
|
|
clippy::unit_arg,
|
|
unused_must_use,
|
|
clippy::needless_bool,
|
|
clippy::match_like_matches_macro,
|
|
deprecated
|
|
)]
|
|
|
|
fn main() {
|
|
let result: Result<usize, usize> = Err(5);
|
|
if result.is_ok() {}
|
|
|
|
if Ok::<i32, i32>(42).is_ok() {}
|
|
|
|
if Err::<i32, i32>(42).is_err() {}
|
|
|
|
if None::<()>.is_none() {}
|
|
|
|
if Some(42).is_some() {}
|
|
|
|
if Some(42).is_some() {
|
|
foo();
|
|
} else {
|
|
bar();
|
|
}
|
|
|
|
while Some(42).is_some() {}
|
|
|
|
while Some(42).is_none() {}
|
|
|
|
while None::<()>.is_none() {}
|
|
|
|
while Ok::<i32, i32>(10).is_ok() {}
|
|
|
|
while Ok::<i32, i32>(10).is_err() {}
|
|
|
|
let mut v = vec![1, 2, 3];
|
|
while v.pop().is_some() {
|
|
foo();
|
|
}
|
|
|
|
if Ok::<i32, i32>(42).is_ok() {}
|
|
|
|
if Err::<i32, i32>(42).is_err() {}
|
|
|
|
if None::<i32>.is_none() {}
|
|
|
|
if Some(42).is_some() {}
|
|
|
|
if let Ok(x) = Ok::<i32, i32>(42) {
|
|
println!("{}", x);
|
|
}
|
|
|
|
Ok::<i32, i32>(42).is_ok();
|
|
|
|
Ok::<i32, i32>(42).is_err();
|
|
|
|
Err::<i32, i32>(42).is_err();
|
|
|
|
Err::<i32, i32>(42).is_ok();
|
|
|
|
Some(42).is_some();
|
|
|
|
None::<()>.is_none();
|
|
|
|
let _ = None::<()>.is_none();
|
|
|
|
let _ = if Ok::<usize, ()>(4).is_ok() { true } else { false };
|
|
|
|
let opt = Some(false);
|
|
let x = if opt.is_some() { true } else { false };
|
|
takes_bool(x);
|
|
|
|
issue5504();
|
|
issue6067();
|
|
|
|
let _ = if gen_opt().is_some() {
|
|
1
|
|
} else if gen_opt().is_none() {
|
|
2
|
|
} else if gen_res().is_ok() {
|
|
3
|
|
} else if gen_res().is_err() {
|
|
4
|
|
} else {
|
|
5
|
|
};
|
|
}
|
|
|
|
fn gen_opt() -> Option<()> {
|
|
None
|
|
}
|
|
|
|
fn gen_res() -> Result<(), ()> {
|
|
Ok(())
|
|
}
|
|
|
|
fn takes_bool(_: bool) {}
|
|
|
|
fn foo() {}
|
|
|
|
fn bar() {}
|
|
|
|
macro_rules! m {
|
|
() => {
|
|
Some(42u32)
|
|
};
|
|
}
|
|
|
|
fn issue5504() {
|
|
fn result_opt() -> Result<Option<i32>, i32> {
|
|
Err(42)
|
|
}
|
|
|
|
fn try_result_opt() -> Result<i32, i32> {
|
|
while r#try!(result_opt()).is_some() {}
|
|
if r#try!(result_opt()).is_some() {}
|
|
Ok(42)
|
|
}
|
|
|
|
try_result_opt();
|
|
|
|
if m!().is_some() {}
|
|
while m!().is_some() {}
|
|
}
|
|
|
|
// Methods that are unstable const should not be suggested within a const context, see issue #5697.
|
|
// However, in Rust 1.48.0 the methods `is_ok` and `is_err` of `Result`, and `is_some` and `is_none`
|
|
// of `Option` were stabilized as const, so the following should be linted.
|
|
const fn issue6067() {
|
|
if Ok::<i32, i32>(42).is_ok() {}
|
|
|
|
if Err::<i32, i32>(42).is_err() {}
|
|
|
|
if Some(42).is_some() {}
|
|
|
|
if None::<()>.is_none() {}
|
|
|
|
while Ok::<i32, i32>(10).is_ok() {}
|
|
|
|
while Ok::<i32, i32>(10).is_err() {}
|
|
|
|
while Some(42).is_some() {}
|
|
|
|
while None::<()>.is_none() {}
|
|
|
|
Ok::<i32, i32>(42).is_ok();
|
|
|
|
Err::<i32, i32>(42).is_err();
|
|
|
|
Some(42).is_some();
|
|
|
|
None::<()>.is_none();
|
|
}
|