mirror of
https://github.com/rust-lang/rust-clippy
synced 2024-11-18 10:48:36 +00:00
ce4e668e39
When the character next to `{}` is "shifted" (when mapping a byte index
in the format string to span) we should avoid shifting the span end
index, so first map the index of `}` to span, then bump the span,
instead of first mapping the next byte index to a span (which causes
bumping the end span too much).
Regression test added.
Fixes #83344
107 lines
2.2 KiB
Text
107 lines
2.2 KiB
Text
error: literal with an empty format string
|
|
--> $DIR/write_literal_2.rs:9:28
|
|
|
|
|
LL | writeln!(&mut v, "{}", "{hello}");
|
|
| ^^^^^^^^^
|
|
|
|
|
= note: `-D clippy::write-literal` implied by `-D warnings`
|
|
help: try this
|
|
|
|
|
LL | writeln!(&mut v, "{{hello}}");
|
|
| ^^^^^^^^^--
|
|
|
|
error: literal with an empty format string
|
|
--> $DIR/write_literal_2.rs:10:29
|
|
|
|
|
LL | writeln!(&mut v, r"{}", r"{hello}");
|
|
| ^^^^^^^^^^
|
|
|
|
|
help: try this
|
|
|
|
|
LL | writeln!(&mut v, r"{{hello}}");
|
|
| ^^^^^^^^^--
|
|
|
|
error: literal with an empty format string
|
|
--> $DIR/write_literal_2.rs:11:28
|
|
|
|
|
LL | writeln!(&mut v, "{}", '/'');
|
|
| ^^^^
|
|
|
|
|
help: try this
|
|
|
|
|
LL | writeln!(&mut v, "'");
|
|
| ^--
|
|
|
|
error: literal with an empty format string
|
|
--> $DIR/write_literal_2.rs:12:28
|
|
|
|
|
LL | writeln!(&mut v, "{}", '"');
|
|
| ^^^
|
|
|
|
|
help: try this
|
|
|
|
|
LL | writeln!(&mut v, "/"");
|
|
| ^^--
|
|
|
|
error: literal with an empty format string
|
|
--> $DIR/write_literal_2.rs:14:29
|
|
|
|
|
LL | writeln!(&mut v, r"{}", '/'');
|
|
| ^^^^
|
|
|
|
|
help: try this
|
|
|
|
|
LL | writeln!(&mut v, r"'");
|
|
| ^--
|
|
|
|
error: literal with an empty format string
|
|
--> $DIR/write_literal_2.rs:18:9
|
|
|
|
|
LL | / "hello /
|
|
LL | | world!"
|
|
| |_______________^
|
|
|
|
|
help: try this
|
|
|
|
|
LL | "some hello /
|
|
LL | world!"
|
|
|
|
|
|
|
error: literal with an empty format string
|
|
--> $DIR/write_literal_2.rs:25:9
|
|
|
|
|
LL | "1", "2", "3",
|
|
| ^^^
|
|
|
|
|
help: try this
|
|
|
|
|
LL | "some 1/
|
|
LL | {} / {}", "2", "3",
|
|
|
|
|
|
|
error: literal with an empty format string
|
|
--> $DIR/write_literal_2.rs:25:14
|
|
|
|
|
LL | "1", "2", "3",
|
|
| ^^^
|
|
|
|
|
help: try this
|
|
|
|
|
LL | 2 / {}",
|
|
LL | "1", "3",
|
|
|
|
|
|
|
error: literal with an empty format string
|
|
--> $DIR/write_literal_2.rs:25:19
|
|
|
|
|
LL | "1", "2", "3",
|
|
| ^^^
|
|
|
|
|
help: try this
|
|
|
|
|
LL | {} / 3",
|
|
LL | "1", "2",
|
|
|
|
|
|
|
error: aborting due to 9 previous errors
|
|
|