mirror of
https://github.com/rust-lang/rust-clippy
synced 2024-11-30 16:39:26 +00:00
1b3e5dd0fc
This patch sets the two configuration options for `undocumented_unsafe_blocks` to `true` by default: these are `accept-comment-above-statement` and `accept-comment-above-attributes`. Having these values `false` by default prevents what many users would consider clean code, e.g. placing the `// SAFETY:` comment above a single-line functino call, rather than directly next to the argument. changelog: [`undocumented_unsafe_blocks`]: set `accept-comment-above-statement` and `accept-comment-above-attributes` to `true` by default.
396 lines
13 KiB
Text
396 lines
13 KiB
Text
error: unsafe block missing a safety comment
|
|
--> $DIR/undocumented_unsafe_blocks.rs:266:19
|
|
|
|
|
LL | /* Safety: */ unsafe {}
|
|
| ^^^^^^^^^
|
|
|
|
|
= help: consider adding a safety comment on the preceding line
|
|
= note: `-D clippy::undocumented-unsafe-blocks` implied by `-D warnings`
|
|
= help: to override `-D warnings` add `#[allow(clippy::undocumented_unsafe_blocks)]`
|
|
|
|
error: unsafe block missing a safety comment
|
|
--> $DIR/undocumented_unsafe_blocks.rs:270:5
|
|
|
|
|
LL | unsafe {}
|
|
| ^^^^^^^^^
|
|
|
|
|
= help: consider adding a safety comment on the preceding line
|
|
|
|
error: unsafe block missing a safety comment
|
|
--> $DIR/undocumented_unsafe_blocks.rs:274:14
|
|
|
|
|
LL | let _ = [unsafe { 14 }, unsafe { 15 }, 42, unsafe { 16 }];
|
|
| ^^^^^^^^^^^^^
|
|
|
|
|
= help: consider adding a safety comment on the preceding line
|
|
|
|
error: unsafe block missing a safety comment
|
|
--> $DIR/undocumented_unsafe_blocks.rs:274:29
|
|
|
|
|
LL | let _ = [unsafe { 14 }, unsafe { 15 }, 42, unsafe { 16 }];
|
|
| ^^^^^^^^^^^^^
|
|
|
|
|
= help: consider adding a safety comment on the preceding line
|
|
|
|
error: unsafe block missing a safety comment
|
|
--> $DIR/undocumented_unsafe_blocks.rs:274:48
|
|
|
|
|
LL | let _ = [unsafe { 14 }, unsafe { 15 }, 42, unsafe { 16 }];
|
|
| ^^^^^^^^^^^^^
|
|
|
|
|
= help: consider adding a safety comment on the preceding line
|
|
|
|
error: unsafe block missing a safety comment
|
|
--> $DIR/undocumented_unsafe_blocks.rs:278:18
|
|
|
|
|
LL | let _ = (42, unsafe {}, "test", unsafe {});
|
|
| ^^^^^^^^^
|
|
|
|
|
= help: consider adding a safety comment on the preceding line
|
|
|
|
error: unsafe block missing a safety comment
|
|
--> $DIR/undocumented_unsafe_blocks.rs:278:37
|
|
|
|
|
LL | let _ = (42, unsafe {}, "test", unsafe {});
|
|
| ^^^^^^^^^
|
|
|
|
|
= help: consider adding a safety comment on the preceding line
|
|
|
|
error: unsafe block missing a safety comment
|
|
--> $DIR/undocumented_unsafe_blocks.rs:282:14
|
|
|
|
|
LL | let _ = *unsafe { &42 };
|
|
| ^^^^^^^^^^^^^^
|
|
|
|
|
= help: consider adding a safety comment on the preceding line
|
|
|
|
error: unsafe block missing a safety comment
|
|
--> $DIR/undocumented_unsafe_blocks.rs:287:19
|
|
|
|
|
LL | let _ = match unsafe {} {
|
|
| ^^^^^^^^^
|
|
|
|
|
= help: consider adding a safety comment on the preceding line
|
|
|
|
error: unsafe block missing a safety comment
|
|
--> $DIR/undocumented_unsafe_blocks.rs:293:14
|
|
|
|
|
LL | let _ = &unsafe {};
|
|
| ^^^^^^^^^
|
|
|
|
|
= help: consider adding a safety comment on the preceding line
|
|
|
|
error: unsafe block missing a safety comment
|
|
--> $DIR/undocumented_unsafe_blocks.rs:297:14
|
|
|
|
|
LL | let _ = [unsafe {}; 5];
|
|
| ^^^^^^^^^
|
|
|
|
|
= help: consider adding a safety comment on the preceding line
|
|
|
|
error: unsafe block missing a safety comment
|
|
--> $DIR/undocumented_unsafe_blocks.rs:301:13
|
|
|
|
|
LL | let _ = unsafe {};
|
|
| ^^^^^^^^^
|
|
|
|
|
= help: consider adding a safety comment on the preceding line
|
|
|
|
error: unsafe block missing a safety comment
|
|
--> $DIR/undocumented_unsafe_blocks.rs:311:8
|
|
|
|
|
LL | t!(unsafe {});
|
|
| ^^^^^^^^^
|
|
|
|
|
= help: consider adding a safety comment on the preceding line
|
|
|
|
error: unsafe block missing a safety comment
|
|
--> $DIR/undocumented_unsafe_blocks.rs:317:13
|
|
|
|
|
LL | unsafe {}
|
|
| ^^^^^^^^^
|
|
...
|
|
LL | t!();
|
|
| ---- in this macro invocation
|
|
|
|
|
= help: consider adding a safety comment on the preceding line
|
|
= note: this error originates in the macro `t` (in Nightly builds, run with -Z macro-backtrace for more info)
|
|
|
|
error: unsafe block missing a safety comment
|
|
--> $DIR/undocumented_unsafe_blocks.rs:325:5
|
|
|
|
|
LL | unsafe {} // SAFETY:
|
|
| ^^^^^^^^^
|
|
|
|
|
= help: consider adding a safety comment on the preceding line
|
|
|
|
error: unsafe block missing a safety comment
|
|
--> $DIR/undocumented_unsafe_blocks.rs:329:5
|
|
|
|
|
LL | unsafe {
|
|
| ^^^^^^^^
|
|
|
|
|
= help: consider adding a safety comment on the preceding line
|
|
|
|
error: unsafe block missing a safety comment
|
|
--> $DIR/undocumented_unsafe_blocks.rs:339:5
|
|
|
|
|
LL | unsafe {};
|
|
| ^^^^^^^^^
|
|
|
|
|
= help: consider adding a safety comment on the preceding line
|
|
|
|
error: unsafe block missing a safety comment
|
|
--> $DIR/undocumented_unsafe_blocks.rs:343:20
|
|
|
|
|
LL | println!("{}", unsafe { String::from_utf8_unchecked(vec![]) });
|
|
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
|
|
|
|
= help: consider adding a safety comment on the preceding line
|
|
|
|
error: unsafe impl missing a safety comment
|
|
--> $DIR/undocumented_unsafe_blocks.rs:350:5
|
|
|
|
|
LL | unsafe impl A for () {}
|
|
| ^^^^^^^^^^^^^^^^^^^^^^^
|
|
|
|
|
= help: consider adding a safety comment on the preceding line
|
|
|
|
error: unsafe impl missing a safety comment
|
|
--> $DIR/undocumented_unsafe_blocks.rs:357:9
|
|
|
|
|
LL | unsafe impl B for (u32) {}
|
|
| ^^^^^^^^^^^^^^^^^^^^^^^^^^
|
|
|
|
|
= help: consider adding a safety comment on the preceding line
|
|
|
|
error: unsafe impl missing a safety comment
|
|
--> $DIR/undocumented_unsafe_blocks.rs:378:13
|
|
|
|
|
LL | unsafe impl T for $t {}
|
|
| ^^^^^^^^^^^^^^^^^^^^^^^
|
|
...
|
|
LL | no_safety_comment!(());
|
|
| ---------------------- in this macro invocation
|
|
|
|
|
= help: consider adding a safety comment on the preceding line
|
|
= note: this error originates in the macro `no_safety_comment` (in Nightly builds, run with -Z macro-backtrace for more info)
|
|
|
|
error: unsafe impl missing a safety comment
|
|
--> $DIR/undocumented_unsafe_blocks.rs:403:13
|
|
|
|
|
LL | unsafe impl T for $t {}
|
|
| ^^^^^^^^^^^^^^^^^^^^^^^
|
|
...
|
|
LL | no_safety_comment!(());
|
|
| ---------------------- in this macro invocation
|
|
|
|
|
= help: consider adding a safety comment on the preceding line
|
|
= note: this error originates in the macro `no_safety_comment` (in Nightly builds, run with -Z macro-backtrace for more info)
|
|
|
|
error: unsafe impl missing a safety comment
|
|
--> $DIR/undocumented_unsafe_blocks.rs:411:5
|
|
|
|
|
LL | unsafe impl T for (i32) {}
|
|
| ^^^^^^^^^^^^^^^^^^^^^^^^^^
|
|
|
|
|
= help: consider adding a safety comment on the preceding line
|
|
|
|
error: unsafe impl missing a safety comment
|
|
--> $DIR/undocumented_unsafe_blocks.rs:403:13
|
|
|
|
|
LL | unsafe impl T for $t {}
|
|
| ^^^^^^^^^^^^^^^^^^^^^^^
|
|
...
|
|
LL | no_safety_comment!(u32);
|
|
| ----------------------- in this macro invocation
|
|
|
|
|
= help: consider adding a safety comment on the preceding line
|
|
= note: this error originates in the macro `no_safety_comment` (in Nightly builds, run with -Z macro-backtrace for more info)
|
|
|
|
error: unsafe impl missing a safety comment
|
|
--> $DIR/undocumented_unsafe_blocks.rs:417:5
|
|
|
|
|
LL | unsafe impl T for (bool) {}
|
|
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
|
|
|
|
= help: consider adding a safety comment on the preceding line
|
|
|
|
error: unsafe impl missing a safety comment
|
|
--> $DIR/undocumented_unsafe_blocks.rs:463:5
|
|
|
|
|
LL | unsafe impl NoComment for () {}
|
|
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
|
|
|
|
= help: consider adding a safety comment on the preceding line
|
|
|
|
error: unsafe impl missing a safety comment
|
|
--> $DIR/undocumented_unsafe_blocks.rs:467:19
|
|
|
|
|
LL | /* SAFETY: */ unsafe impl InlineComment for () {}
|
|
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
|
|
|
|
= help: consider adding a safety comment on the preceding line
|
|
|
|
error: unsafe impl missing a safety comment
|
|
--> $DIR/undocumented_unsafe_blocks.rs:471:5
|
|
|
|
|
LL | unsafe impl TrailingComment for () {} // SAFETY:
|
|
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
|
|
|
|
= help: consider adding a safety comment on the preceding line
|
|
|
|
error: constant item has unnecessary safety comment
|
|
--> $DIR/undocumented_unsafe_blocks.rs:475:5
|
|
|
|
|
LL | const BIG_NUMBER: i32 = 1000000;
|
|
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
|
|
|
|
help: consider removing the safety comment
|
|
--> $DIR/undocumented_unsafe_blocks.rs:474:5
|
|
|
|
|
LL | // SAFETY:
|
|
| ^^^^^^^^^^
|
|
= note: `-D clippy::unnecessary-safety-comment` implied by `-D warnings`
|
|
= help: to override `-D warnings` add `#[allow(clippy::unnecessary_safety_comment)]`
|
|
|
|
error: unsafe impl missing a safety comment
|
|
--> $DIR/undocumented_unsafe_blocks.rs:476:5
|
|
|
|
|
LL | unsafe impl Interference for () {}
|
|
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
|
|
|
|
= help: consider adding a safety comment on the preceding line
|
|
|
|
error: unsafe impl missing a safety comment
|
|
--> $DIR/undocumented_unsafe_blocks.rs:483:5
|
|
|
|
|
LL | unsafe impl ImplInFn for () {}
|
|
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
|
|
|
|
= help: consider adding a safety comment on the preceding line
|
|
|
|
error: unsafe impl missing a safety comment
|
|
--> $DIR/undocumented_unsafe_blocks.rs:492:1
|
|
|
|
|
LL | unsafe impl CrateRoot for () {}
|
|
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
|
|
|
|
= help: consider adding a safety comment on the preceding line
|
|
|
|
error: unsafe block missing a safety comment
|
|
--> $DIR/undocumented_unsafe_blocks.rs:502:9
|
|
|
|
|
LL | unsafe {};
|
|
| ^^^^^^^^^
|
|
|
|
|
= help: consider adding a safety comment on the preceding line
|
|
|
|
error: statement has unnecessary safety comment
|
|
--> $DIR/undocumented_unsafe_blocks.rs:505:5
|
|
|
|
|
LL | / let _ = {
|
|
LL | | if unsafe { true } {
|
|
LL | | todo!();
|
|
LL | | } else {
|
|
... |
|
|
LL | | }
|
|
LL | | };
|
|
| |______^
|
|
|
|
|
help: consider removing the safety comment
|
|
--> $DIR/undocumented_unsafe_blocks.rs:504:5
|
|
|
|
|
LL | // SAFETY: this is more than one level away, so it should warn
|
|
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
|
|
|
error: unsafe block missing a safety comment
|
|
--> $DIR/undocumented_unsafe_blocks.rs:506:12
|
|
|
|
|
LL | if unsafe { true } {
|
|
| ^^^^^^^^^^^^^^^
|
|
|
|
|
= help: consider adding a safety comment on the preceding line
|
|
|
|
error: unsafe block missing a safety comment
|
|
--> $DIR/undocumented_unsafe_blocks.rs:509:23
|
|
|
|
|
LL | let bar = unsafe {};
|
|
| ^^^^^^^^^
|
|
|
|
|
= help: consider adding a safety comment on the preceding line
|
|
|
|
error: unsafe block missing a safety comment
|
|
--> $DIR/undocumented_unsafe_blocks.rs:527:9
|
|
|
|
|
LL | unsafe { a_function_with_a_very_long_name_to_break_the_line() };
|
|
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
|
|
|
|
= help: consider adding a safety comment on the preceding line
|
|
|
|
error: unsafe block missing a safety comment
|
|
--> $DIR/undocumented_unsafe_blocks.rs:531:9
|
|
|
|
|
LL | unsafe { a_const_function_with_a_very_long_name_to_break_the_line() };
|
|
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
|
|
|
|
= help: consider adding a safety comment on the preceding line
|
|
|
|
error: unsafe block missing a safety comment
|
|
--> $DIR/undocumented_unsafe_blocks.rs:535:9
|
|
|
|
|
LL | unsafe { a_const_function_with_a_very_long_name_to_break_the_line() };
|
|
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
|
|
|
|
= help: consider adding a safety comment on the preceding line
|
|
|
|
error: unsafe block missing a safety comment
|
|
--> $DIR/undocumented_unsafe_blocks.rs:541:5
|
|
|
|
|
LL | unsafe {}
|
|
| ^^^^^^^^^
|
|
|
|
|
= help: consider adding a safety comment on the preceding line
|
|
|
|
error: unsafe block missing a safety comment
|
|
--> $DIR/undocumented_unsafe_blocks.rs:545:5
|
|
|
|
|
LL | unsafe {
|
|
| ^^^^^^^^
|
|
|
|
|
= help: consider adding a safety comment on the preceding line
|
|
|
|
error: unsafe block missing a safety comment
|
|
--> $DIR/undocumented_unsafe_blocks.rs:552:9
|
|
|
|
|
LL | unsafe { a_function_with_a_very_long_name_to_break_the_line() };
|
|
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
|
|
|
|
= help: consider adding a safety comment on the preceding line
|
|
|
|
error: unsafe block missing a safety comment
|
|
--> $DIR/undocumented_unsafe_blocks.rs:557:9
|
|
|
|
|
LL | unsafe { a_const_function_with_a_very_long_name_to_break_the_line() };
|
|
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
|
|
|
|
= help: consider adding a safety comment on the preceding line
|
|
|
|
error: unsafe block missing a safety comment
|
|
--> $DIR/undocumented_unsafe_blocks.rs:563:9
|
|
|
|
|
LL | unsafe { a_const_function_with_a_very_long_name_to_break_the_line() };
|
|
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
|
|
|
|
= help: consider adding a safety comment on the preceding line
|
|
|
|
error: unsafe block missing a safety comment
|
|
--> $DIR/undocumented_unsafe_blocks.rs:568:5
|
|
|
|
|
LL | unsafe {}
|
|
| ^^^^^^^^^
|
|
|
|
|
= help: consider adding a safety comment on the preceding line
|
|
|
|
error: aborting due to 45 previous errors
|
|
|