mirror of
https://github.com/rust-lang/rust-clippy
synced 2024-11-28 07:30:57 +00:00
eb3970285b
In order to switch `clippy::uninlined_format_args` from pedantic to style, all existing tests must not raise a warning. I did not want to change the actual tests, so this is a relatively minor change that: * add `#![allow(clippy::uninlined_format_args)]` where needed * normalizes all allow/deny/warn attributes * all allow attributes are grouped together * sorted alphabetically * the `clippy::*` attributes are listed separate from the other ones. * deny and warn attributes are listed before the allowed ones changelog: none
196 lines
5.7 KiB
Text
196 lines
5.7 KiB
Text
error: this match arm has an identical body to the `_` wildcard arm
|
|
--> $DIR/match_same_arms2.rs:15:9
|
|
|
|
|
LL | / 42 => {
|
|
LL | | foo();
|
|
LL | | let mut a = 42 + [23].len() as i32;
|
|
LL | | if true {
|
|
... |
|
|
LL | | a
|
|
LL | | },
|
|
| |_________^ help: try removing the arm
|
|
|
|
|
= note: `-D clippy::match-same-arms` implied by `-D warnings`
|
|
= help: or try changing either arm body
|
|
note: `_` wildcard arm here
|
|
--> $DIR/match_same_arms2.rs:24:9
|
|
|
|
|
LL | / _ => {
|
|
LL | | //~ ERROR match arms have same body
|
|
LL | | foo();
|
|
LL | | let mut a = 42 + [23].len() as i32;
|
|
... |
|
|
LL | | a
|
|
LL | | },
|
|
| |_________^
|
|
|
|
error: this match arm has an identical body to another arm
|
|
--> $DIR/match_same_arms2.rs:38:9
|
|
|
|
|
LL | 51 => foo(), //~ ERROR match arms have same body
|
|
| --^^^^^^^^^
|
|
| |
|
|
| help: try merging the arm patterns: `51 | 42`
|
|
|
|
|
= help: or try changing either arm body
|
|
note: other arm here
|
|
--> $DIR/match_same_arms2.rs:37:9
|
|
|
|
|
LL | 42 => foo(),
|
|
| ^^^^^^^^^^^
|
|
|
|
error: this match arm has an identical body to another arm
|
|
--> $DIR/match_same_arms2.rs:44:9
|
|
|
|
|
LL | None => 24, //~ ERROR match arms have same body
|
|
| ----^^^^^^
|
|
| |
|
|
| help: try merging the arm patterns: `None | Some(_)`
|
|
|
|
|
= help: or try changing either arm body
|
|
note: other arm here
|
|
--> $DIR/match_same_arms2.rs:43:9
|
|
|
|
|
LL | Some(_) => 24,
|
|
| ^^^^^^^^^^^^^
|
|
|
|
error: this match arm has an identical body to another arm
|
|
--> $DIR/match_same_arms2.rs:66:9
|
|
|
|
|
LL | (None, Some(a)) => bar(a), //~ ERROR match arms have same body
|
|
| ---------------^^^^^^^^^^
|
|
| |
|
|
| help: try merging the arm patterns: `(None, Some(a)) | (Some(a), None)`
|
|
|
|
|
= help: or try changing either arm body
|
|
note: other arm here
|
|
--> $DIR/match_same_arms2.rs:65:9
|
|
|
|
|
LL | (Some(a), None) => bar(a),
|
|
| ^^^^^^^^^^^^^^^^^^^^^^^^^
|
|
|
|
error: this match arm has an identical body to another arm
|
|
--> $DIR/match_same_arms2.rs:71:9
|
|
|
|
|
LL | (Some(a), ..) => bar(a),
|
|
| -------------^^^^^^^^^^
|
|
| |
|
|
| help: try merging the arm patterns: `(Some(a), ..) | (.., Some(a))`
|
|
|
|
|
= help: or try changing either arm body
|
|
note: other arm here
|
|
--> $DIR/match_same_arms2.rs:72:9
|
|
|
|
|
LL | (.., Some(a)) => bar(a), //~ ERROR match arms have same body
|
|
| ^^^^^^^^^^^^^^^^^^^^^^^
|
|
|
|
error: this match arm has an identical body to another arm
|
|
--> $DIR/match_same_arms2.rs:105:9
|
|
|
|
|
LL | (Ok(x), Some(_)) => println!("ok {}", x),
|
|
| ----------------^^^^^^^^^^^^^^^^^^^^^^^^
|
|
| |
|
|
| help: try merging the arm patterns: `(Ok(x), Some(_)) | (Ok(_), Some(x))`
|
|
|
|
|
= help: or try changing either arm body
|
|
note: other arm here
|
|
--> $DIR/match_same_arms2.rs:106:9
|
|
|
|
|
LL | (Ok(_), Some(x)) => println!("ok {}", x),
|
|
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
|
|
|
error: this match arm has an identical body to another arm
|
|
--> $DIR/match_same_arms2.rs:121:9
|
|
|
|
|
LL | Ok(_) => println!("ok"),
|
|
| -----^^^^^^^^^^^^^^^^^^
|
|
| |
|
|
| help: try merging the arm patterns: `Ok(_) | Ok(3)`
|
|
|
|
|
= help: or try changing either arm body
|
|
note: other arm here
|
|
--> $DIR/match_same_arms2.rs:120:9
|
|
|
|
|
LL | Ok(3) => println!("ok"),
|
|
| ^^^^^^^^^^^^^^^^^^^^^^^
|
|
|
|
error: this match arm has an identical body to another arm
|
|
--> $DIR/match_same_arms2.rs:148:9
|
|
|
|
|
LL | 1 => {
|
|
| ^ help: try merging the arm patterns: `1 | 0`
|
|
| _________|
|
|
| |
|
|
LL | | empty!(0);
|
|
LL | | },
|
|
| |_________^
|
|
|
|
|
= help: or try changing either arm body
|
|
note: other arm here
|
|
--> $DIR/match_same_arms2.rs:145:9
|
|
|
|
|
LL | / 0 => {
|
|
LL | | empty!(0);
|
|
LL | | },
|
|
| |_________^
|
|
|
|
error: match expression looks like `matches!` macro
|
|
--> $DIR/match_same_arms2.rs:166:16
|
|
|
|
|
LL | let _ans = match x {
|
|
| ________________^
|
|
LL | | E::A => false,
|
|
LL | | E::B => false,
|
|
LL | | _ => true,
|
|
LL | | };
|
|
| |_____^ help: try this: `!matches!(x, E::A | E::B)`
|
|
|
|
|
= note: `-D clippy::match-like-matches-macro` implied by `-D warnings`
|
|
|
|
error: this match arm has an identical body to another arm
|
|
--> $DIR/match_same_arms2.rs:198:9
|
|
|
|
|
LL | Foo::X(0) => 1,
|
|
| ---------^^^^^
|
|
| |
|
|
| help: try merging the arm patterns: `Foo::X(0) | Foo::Z(_)`
|
|
|
|
|
= help: or try changing either arm body
|
|
note: other arm here
|
|
--> $DIR/match_same_arms2.rs:200:9
|
|
|
|
|
LL | Foo::Z(_) => 1,
|
|
| ^^^^^^^^^^^^^^
|
|
|
|
error: this match arm has an identical body to another arm
|
|
--> $DIR/match_same_arms2.rs:208:9
|
|
|
|
|
LL | Foo::Z(_) => 1,
|
|
| ---------^^^^^
|
|
| |
|
|
| help: try merging the arm patterns: `Foo::Z(_) | Foo::X(0)`
|
|
|
|
|
= help: or try changing either arm body
|
|
note: other arm here
|
|
--> $DIR/match_same_arms2.rs:206:9
|
|
|
|
|
LL | Foo::X(0) => 1,
|
|
| ^^^^^^^^^^^^^^
|
|
|
|
error: this match arm has an identical body to another arm
|
|
--> $DIR/match_same_arms2.rs:231:9
|
|
|
|
|
LL | Some(Bar { y: 0, x: 5, .. }) => 1,
|
|
| ----------------------------^^^^^
|
|
| |
|
|
| help: try merging the arm patterns: `Some(Bar { y: 0, x: 5, .. }) | Some(Bar { x: 0, y: 5, .. })`
|
|
|
|
|
= help: or try changing either arm body
|
|
note: other arm here
|
|
--> $DIR/match_same_arms2.rs:228:9
|
|
|
|
|
LL | Some(Bar { x: 0, y: 5, .. }) => 1,
|
|
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
|
|
|
error: aborting due to 12 previous errors
|
|
|