mirror of
https://github.com/rust-lang/rust-clippy
synced 2024-11-15 17:28:07 +00:00
eb3970285b
In order to switch `clippy::uninlined_format_args` from pedantic to style, all existing tests must not raise a warning. I did not want to change the actual tests, so this is a relatively minor change that: * add `#![allow(clippy::uninlined_format_args)]` where needed * normalizes all allow/deny/warn attributes * all allow attributes are grouped together * sorted alphabetically * the `clippy::*` attributes are listed separate from the other ones. * deny and warn attributes are listed before the allowed ones changelog: none
123 lines
3 KiB
Rust
123 lines
3 KiB
Rust
// aux-build:proc_macro_derive.rs
|
|
#![feature(rustc_private)]
|
|
#![warn(clippy::all)]
|
|
#![warn(clippy::used_underscore_binding)]
|
|
#![allow(clippy::disallowed_names, clippy::eq_op, clippy::uninlined_format_args)]
|
|
|
|
#[macro_use]
|
|
extern crate proc_macro_derive;
|
|
|
|
// This should not trigger the lint. There's underscore binding inside the external derive that
|
|
// would trigger the `used_underscore_binding` lint.
|
|
#[derive(DeriveSomething)]
|
|
struct Baz;
|
|
|
|
macro_rules! test_macro {
|
|
() => {{
|
|
let _foo = 42;
|
|
_foo + 1
|
|
}};
|
|
}
|
|
|
|
/// Tests that we lint if we use a binding with a single leading underscore
|
|
fn prefix_underscore(_foo: u32) -> u32 {
|
|
_foo + 1
|
|
}
|
|
|
|
/// Tests that we lint if we use a `_`-variable defined outside within a macro expansion
|
|
fn in_macro_or_desugar(_foo: u32) {
|
|
println!("{}", _foo);
|
|
assert_eq!(_foo, _foo);
|
|
|
|
test_macro!() + 1;
|
|
}
|
|
|
|
// Struct for testing use of fields prefixed with an underscore
|
|
struct StructFieldTest {
|
|
_underscore_field: u32,
|
|
}
|
|
|
|
/// Tests that we lint the use of a struct field which is prefixed with an underscore
|
|
fn in_struct_field() {
|
|
let mut s = StructFieldTest { _underscore_field: 0 };
|
|
s._underscore_field += 1;
|
|
}
|
|
|
|
/// Tests that we do not lint if the struct field is used in code created with derive.
|
|
#[derive(Clone, Debug)]
|
|
pub struct UnderscoreInStruct {
|
|
_foo: u32,
|
|
}
|
|
|
|
/// Tests that we do not lint if the underscore is not a prefix
|
|
fn non_prefix_underscore(some_foo: u32) -> u32 {
|
|
some_foo + 1
|
|
}
|
|
|
|
/// Tests that we do not lint if we do not use the binding (simple case)
|
|
fn unused_underscore_simple(_foo: u32) -> u32 {
|
|
1
|
|
}
|
|
|
|
/// Tests that we do not lint if we do not use the binding (complex case). This checks for
|
|
/// compatibility with the built-in `unused_variables` lint.
|
|
fn unused_underscore_complex(mut _foo: u32) -> u32 {
|
|
_foo += 1;
|
|
_foo = 2;
|
|
1
|
|
}
|
|
|
|
/// Test that we do not lint for multiple underscores
|
|
fn multiple_underscores(__foo: u32) -> u32 {
|
|
__foo + 1
|
|
}
|
|
|
|
// Non-variable bindings with preceding underscore
|
|
fn _fn_test() {}
|
|
struct _StructTest;
|
|
enum _EnumTest {
|
|
_Empty,
|
|
_Value(_StructTest),
|
|
}
|
|
|
|
/// Tests that we do not lint for non-variable bindings
|
|
fn non_variables() {
|
|
_fn_test();
|
|
let _s = _StructTest;
|
|
let _e = match _EnumTest::_Value(_StructTest) {
|
|
_EnumTest::_Empty => 0,
|
|
_EnumTest::_Value(_st) => 1,
|
|
};
|
|
let f = _fn_test;
|
|
f();
|
|
}
|
|
|
|
// Tests that we do not lint if the binding comes from await desugaring,
|
|
// but we do lint the awaited expression. See issue 5360.
|
|
async fn await_desugaring() {
|
|
async fn foo() {}
|
|
fn uses_i(_i: i32) {}
|
|
|
|
foo().await;
|
|
({
|
|
let _i = 5;
|
|
uses_i(_i);
|
|
foo()
|
|
})
|
|
.await
|
|
}
|
|
|
|
fn main() {
|
|
let foo = 0u32;
|
|
// tests of unused_underscore lint
|
|
let _ = prefix_underscore(foo);
|
|
in_macro_or_desugar(foo);
|
|
in_struct_field();
|
|
// possible false positives
|
|
let _ = non_prefix_underscore(foo);
|
|
let _ = unused_underscore_simple(foo);
|
|
let _ = unused_underscore_complex(foo);
|
|
let _ = multiple_underscores(foo);
|
|
non_variables();
|
|
await_desugaring();
|
|
}
|