mirror of
https://github.com/rust-lang/rust-clippy
synced 2024-12-23 19:43:20 +00:00
69 lines
1.6 KiB
Rust
69 lines
1.6 KiB
Rust
#![warn(clippy::unnecessary_result_map_or_else)]
|
|
#![allow(clippy::unnecessary_literal_unwrap, clippy::let_and_return, clippy::let_unit_value)]
|
|
|
|
fn main() {
|
|
let x: Result<(), ()> = Ok(());
|
|
x.map_or_else(|err| err, |n| n); //~ ERROR: unused "map closure" when calling
|
|
|
|
// Type ascribtion.
|
|
let x: Result<(), ()> = Ok(());
|
|
x.map_or_else(|err: ()| err, |n: ()| n); //~ ERROR: unused "map closure" when calling
|
|
|
|
// Auto-deref.
|
|
let y = String::new();
|
|
let x: Result<&String, &String> = Ok(&y);
|
|
let y: &str = x.map_or_else(|err| err, |n| n); //~ ERROR: unused "map closure" when calling
|
|
|
|
// Temporary variable.
|
|
let x: Result<(), ()> = Ok(());
|
|
x.map_or_else(
|
|
//~^ ERROR: unused "map closure" when calling
|
|
|err| err,
|
|
|n| {
|
|
let tmp = n;
|
|
let tmp2 = tmp;
|
|
tmp2
|
|
},
|
|
);
|
|
|
|
// Should not warn.
|
|
let x: Result<usize, usize> = Ok(0);
|
|
x.map_or_else(|err| err, |n| n + 1);
|
|
|
|
// Should not warn.
|
|
let y = ();
|
|
let x: Result<(), ()> = Ok(());
|
|
x.map_or_else(|err| err, |_| y);
|
|
|
|
// Should not warn.
|
|
let y = ();
|
|
let x: Result<(), ()> = Ok(());
|
|
x.map_or_else(
|
|
|err| err,
|
|
|_| {
|
|
let tmp = y;
|
|
tmp
|
|
},
|
|
);
|
|
|
|
// Should not warn.
|
|
let x: Result<usize, usize> = Ok(1);
|
|
x.map_or_else(
|
|
|err| err,
|
|
|n| {
|
|
let tmp = n + 1;
|
|
tmp
|
|
},
|
|
);
|
|
|
|
// Should not warn.
|
|
let y = 0;
|
|
let x: Result<usize, usize> = Ok(1);
|
|
x.map_or_else(
|
|
|err| err,
|
|
|n| {
|
|
let tmp = n;
|
|
y
|
|
},
|
|
);
|
|
}
|