mirror of
https://github.com/rust-lang/rust-clippy
synced 2024-11-18 02:38:28 +00:00
5344236715
Remove overlap between `manual_split_once` and `needless_splitn`
changelog: Remove overlap between [`manual_split_once`] and [`needless_splitn`]. Fixes some incorrect `rsplitn` suggestions for [`manual_split_once`]
Things that can trigger `needless_splitn` no longer trigger `manual_split_once`, e.g.
```rust
s.[r]splitn(2, '=').next();
s.[r]splitn(2, '=').nth(0);
s.[r]splitn(3, '=').next_tuple();
```
Fixes some suggestions:
```rust
let s = "should not match";
s.rsplitn(2, '.').nth(1);
// old -> Some("should not match")
Some(s.rsplit_once('.').map_or(s, |x| x.0));
// new -> None
s.rsplit_once('.').map(|x| x.0);
s.rsplitn(2, '.').nth(1)?;
// old -> "should not match"
s.rsplit_once('.').map_or(s, |x| x.0);
// new -> early returns
s.rsplit_once('.')?.0;
```
53 lines
1.6 KiB
Rust
53 lines
1.6 KiB
Rust
// run-rustfix
|
|
|
|
#![feature(custom_inner_attributes)]
|
|
#![warn(clippy::manual_split_once)]
|
|
#![allow(clippy::iter_skip_next, clippy::iter_nth_zero)]
|
|
|
|
extern crate itertools;
|
|
|
|
#[allow(unused_imports)]
|
|
use itertools::Itertools;
|
|
|
|
fn main() {
|
|
let _ = "key=value".splitn(2, '=').nth(2);
|
|
let _ = "key=value".splitn(2, '=').nth(1).unwrap();
|
|
let _ = "key=value".splitn(2, '=').skip(1).next().unwrap();
|
|
let (_, _) = "key=value".splitn(2, '=').next_tuple().unwrap();
|
|
|
|
let s = String::from("key=value");
|
|
let _ = s.splitn(2, '=').nth(1).unwrap();
|
|
|
|
let s = Box::<str>::from("key=value");
|
|
let _ = s.splitn(2, '=').nth(1).unwrap();
|
|
|
|
let s = &"key=value";
|
|
let _ = s.splitn(2, '=').skip(1).next().unwrap();
|
|
|
|
fn _f(s: &str) -> Option<&str> {
|
|
let _ = s.splitn(2, '=').nth(1)?;
|
|
let _ = s.splitn(2, '=').skip(1).next()?;
|
|
let _ = s.rsplitn(2, '=').nth(1)?;
|
|
let _ = s.rsplitn(2, '=').skip(1).next()?;
|
|
None
|
|
}
|
|
|
|
// Don't lint, slices don't have `split_once`
|
|
let _ = [0, 1, 2].splitn(2, |&x| x == 1).nth(1).unwrap();
|
|
|
|
// `rsplitn` gives the results in the reverse order of `rsplit_once`
|
|
let _ = "key=value".rsplitn(2, '=').nth(1).unwrap();
|
|
let (_, _) = "key=value".rsplitn(2, '=').next_tuple().unwrap();
|
|
let _ = s.rsplitn(2, '=').nth(1);
|
|
}
|
|
|
|
fn _msrv_1_51() {
|
|
#![clippy::msrv = "1.51"]
|
|
// `str::split_once` was stabilized in 1.52. Do not lint this
|
|
let _ = "key=value".splitn(2, '=').nth(1).unwrap();
|
|
}
|
|
|
|
fn _msrv_1_52() {
|
|
#![clippy::msrv = "1.52"]
|
|
let _ = "key=value".splitn(2, '=').nth(1).unwrap();
|
|
}
|