2
0
Fork 0
mirror of https://github.com/rust-lang/rust-clippy synced 2024-12-18 09:03:18 +00:00
rust-clippy/tests/compile-fail/block_in_if_condition.rs
2016-03-29 10:45:18 +02:00

94 lines
2.1 KiB
Rust

#![feature(plugin)]
#![plugin(clippy)]
#![deny(block_in_if_condition_expr)]
#![deny(block_in_if_condition_stmt)]
#![allow(unused, let_and_return)]
#![warn(nonminimal_bool)]
macro_rules! blocky {
() => {{true}}
}
macro_rules! blocky_too {
() => {{
let r = true;
r
}}
}
fn macro_if() {
if blocky!() {
}
if blocky_too!() {
}
}
fn condition_has_block() -> i32 {
if { //~ERROR in an 'if' condition, avoid complex blocks or closures with blocks; instead, move the block or closure higher and bind it with a 'let'
let x = 3;
x == 3
} {
6
} else {
10
}
}
fn condition_has_block_with_single_expression() -> i32 {
if { true } { //~ERROR omit braces around single expression condition
6
} else {
10
}
}
fn predicate<F: FnOnce(T) -> bool, T>(pfn: F, val:T) -> bool {
pfn(val)
}
fn pred_test() {
let v = 3;
let sky = "blue";
// this is a sneaky case, where the block isn't directly in the condition, but is actually
// inside a closure that the condition is using. same principle applies. add some extra
// expressions to make sure linter isn't confused by them.
if v == 3 && sky == "blue" && predicate(|x| { let target = 3; x == target }, v) { //~ERROR in an 'if' condition, avoid complex blocks or closures with blocks; instead, move the block or closure higher and bind it with a 'let'
}
if predicate(|x| { let target = 3; x == target }, v) { //~ERROR in an 'if' condition, avoid complex blocks or closures with blocks; instead, move the block or closure higher and bind it with a 'let'
}
}
fn condition_is_normal() -> i32 {
let x = 3;
if true && x == 3 { //~ WARN this boolean expression can be simplified
6
} else {
10
}
}
fn closure_without_block() {
if predicate(|x| x == 3, 6) {
}
}
fn condition_is_unsafe_block() {
let a: i32 = 1;
// this should not warn because the condition is an unsafe block
if unsafe { 1u32 == std::mem::transmute(a) } {
println!("1u32 == a");
}
}
fn main() {
}