mirror of
https://github.com/rust-lang/rust-clippy
synced 2024-09-21 15:11:56 +00:00
99 lines
4 KiB
Text
99 lines
4 KiB
Text
error: methods called `new` usually return `Self`
|
|
--> $DIR/methods.rs:105:5
|
|
|
|
|
LL | / fn new() -> i32 {
|
|
LL | | 0
|
|
LL | | }
|
|
| |_____^
|
|
|
|
|
= note: `-D clippy::new-ret-no-self` implied by `-D warnings`
|
|
|
|
error: called `filter(p).next()` on an `Iterator`. This is more succinctly expressed by calling `.find(p)` instead.
|
|
--> $DIR/methods.rs:126:13
|
|
|
|
|
LL | let _ = v.iter().filter(|&x| *x < 0).next();
|
|
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
|
|
|
|
= note: `-D clippy::filter-next` implied by `-D warnings`
|
|
= note: replace `filter(|&x| *x < 0).next()` with `find(|&x| *x < 0)`
|
|
|
|
error: called `filter(p).next()` on an `Iterator`. This is more succinctly expressed by calling `.find(p)` instead.
|
|
--> $DIR/methods.rs:129:13
|
|
|
|
|
LL | let _ = v.iter().filter(|&x| {
|
|
| _____________^
|
|
LL | | *x < 0
|
|
LL | | }
|
|
LL | | ).next();
|
|
| |___________________________^
|
|
|
|
error: called `is_some()` after searching an `Iterator` with find. This is more succinctly expressed by calling `any()`.
|
|
--> $DIR/methods.rs:146:22
|
|
|
|
|
LL | let _ = v.iter().find(|&x| *x < 0).is_some();
|
|
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `any(|x| *x < 0)`
|
|
|
|
|
= note: `-D clippy::search-is-some` implied by `-D warnings`
|
|
|
|
error: called `is_some()` after searching an `Iterator` with find. This is more succinctly expressed by calling `any()`.
|
|
--> $DIR/methods.rs:147:20
|
|
|
|
|
LL | let _ = (0..1).find(|x| **y == *x).is_some(); // one dereference less
|
|
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `any(|x| **y == x)`
|
|
|
|
error: called `is_some()` after searching an `Iterator` with find. This is more succinctly expressed by calling `any()`.
|
|
--> $DIR/methods.rs:148:20
|
|
|
|
|
LL | let _ = (0..1).find(|x| *x == 0).is_some();
|
|
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `any(|x| x == 0)`
|
|
|
|
error: called `is_some()` after searching an `Iterator` with find. This is more succinctly expressed by calling `any()`.
|
|
--> $DIR/methods.rs:149:22
|
|
|
|
|
LL | let _ = v.iter().find(|x| **x == 0).is_some();
|
|
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `any(|x| *x == 0)`
|
|
|
|
error: called `is_some()` after searching an `Iterator` with find. This is more succinctly expressed by calling `any()`.
|
|
--> $DIR/methods.rs:152:13
|
|
|
|
|
LL | let _ = v.iter().find(|&x| {
|
|
| _____________^
|
|
LL | | *x < 0
|
|
LL | | }
|
|
LL | | ).is_some();
|
|
| |______________________________^
|
|
|
|
error: called `is_some()` after searching an `Iterator` with position. This is more succinctly expressed by calling `any()`.
|
|
--> $DIR/methods.rs:158:22
|
|
|
|
|
LL | let _ = v.iter().position(|&x| x < 0).is_some();
|
|
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `any(|&x| x < 0)`
|
|
|
|
error: called `is_some()` after searching an `Iterator` with position. This is more succinctly expressed by calling `any()`.
|
|
--> $DIR/methods.rs:161:13
|
|
|
|
|
LL | let _ = v.iter().position(|&x| {
|
|
| _____________^
|
|
LL | | x < 0
|
|
LL | | }
|
|
LL | | ).is_some();
|
|
| |______________________________^
|
|
|
|
error: called `is_some()` after searching an `Iterator` with rposition. This is more succinctly expressed by calling `any()`.
|
|
--> $DIR/methods.rs:167:22
|
|
|
|
|
LL | let _ = v.iter().rposition(|&x| x < 0).is_some();
|
|
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `any(|&x| x < 0)`
|
|
|
|
error: called `is_some()` after searching an `Iterator` with rposition. This is more succinctly expressed by calling `any()`.
|
|
--> $DIR/methods.rs:170:13
|
|
|
|
|
LL | let _ = v.iter().rposition(|&x| {
|
|
| _____________^
|
|
LL | | x < 0
|
|
LL | | }
|
|
LL | | ).is_some();
|
|
| |______________________________^
|
|
|
|
error: aborting due to 12 previous errors
|
|
|