mirror of
https://github.com/rust-lang/rust-clippy
synced 2024-11-10 23:24:24 +00:00
0ef5dee3b8
Update the "borrow box" lint to avoid recommending the following
conversion:
```
// Old
pub fn f(&mut Box<T>) {...}
// New
pub fn f(&mut T) {...}
```
Given a mutable reference to a box, functions may want to change
"which" object the Box is pointing at.
This change avoids recommending removing the "Box" parameter
for mutable references.
26 lines
757 B
Text
26 lines
757 B
Text
error: you seem to be trying to use `&Box<T>`. Consider using just `&T`
|
|
--> $DIR/borrow_box.rs:19:14
|
|
|
|
|
LL | let foo: &Box<bool>;
|
|
| ^^^^^^^^^^ help: try: `&bool`
|
|
|
|
|
note: the lint level is defined here
|
|
--> $DIR/borrow_box.rs:1:9
|
|
|
|
|
LL | #![deny(clippy::borrowed_box)]
|
|
| ^^^^^^^^^^^^^^^^^^^^
|
|
|
|
error: you seem to be trying to use `&Box<T>`. Consider using just `&T`
|
|
--> $DIR/borrow_box.rs:23:10
|
|
|
|
|
LL | foo: &'a Box<bool>,
|
|
| ^^^^^^^^^^^^^ help: try: `&'a bool`
|
|
|
|
error: you seem to be trying to use `&Box<T>`. Consider using just `&T`
|
|
--> $DIR/borrow_box.rs:27:17
|
|
|
|
|
LL | fn test4(a: &Box<bool>);
|
|
| ^^^^^^^^^^ help: try: `&bool`
|
|
|
|
error: aborting due to 3 previous errors
|
|
|