mirror of
https://github.com/rust-lang/rust-clippy
synced 2024-12-20 18:13:36 +00:00
d647696c1f
So, some context for this, well, more a story. I'm not used to scripting, I've never really scripted anything, even if it's a valuable skill. I just never really needed it. Now, `@flip1995` correctly suggested using a script for this in `rust-clippy#7813`...
And I decided to write a script using nushell because why not? This was a mistake... I spend way more time on this than I would like to admit. It has definitely been more than 4 hours. It shouldn't take that long, but me being new to scripting and nushell just wasn't a good mixture... Anyway, here is the script that creates another script which adds the versions. Fun...
Just execute this on the `gh-pages` branch and the resulting `replacer.sh` in `clippy_lints` and it should all work.
```nu
mv v0.0.212 rust-1.00.0;
mv beta rust-1.57.0;
mv master rust-1.58.0;
let paths = (open ./rust-1.58.0/lints.json | select id id_span | flatten | select id path);
let versions = (
ls | where name =~ "rust-" | select name | format {name}/lints.json |
each { open $it | select id | insert version $it | str substring "5,11" version} |
group-by id | rotate counter-clockwise id version |
update version {get version | first 1} | flatten | select id version);
$paths | each { |row|
let version = ($versions | where id == ($row.id) | format {version})
let idu = ($row.id | str upcase)
$"sed -i '0,/($idu),/{s/pub ($idu),/#[clippy::version = "($version)"]\n pub ($idu),/}' ($row.path)"
} | str collect ";" | str find-replace --all '1.00.0' 'pre 1.29.0' | save "replacer.sh";
```
And this still has some problems, but at this point I just want to be done -.-
77 lines
2.1 KiB
Rust
77 lines
2.1 KiB
Rust
use clippy_utils::diagnostics::span_lint;
|
|
use rustc_ast::ast::{Expr, ExprKind};
|
|
use rustc_lint::{EarlyContext, EarlyLintPass};
|
|
use rustc_session::{declare_lint_pass, declare_tool_lint};
|
|
|
|
declare_clippy_lint! {
|
|
/// ### What it does
|
|
/// Checks for unnecessary double parentheses.
|
|
///
|
|
/// ### Why is this bad?
|
|
/// This makes code harder to read and might indicate a
|
|
/// mistake.
|
|
///
|
|
/// ### Example
|
|
/// ```rust
|
|
/// // Bad
|
|
/// fn simple_double_parens() -> i32 {
|
|
/// ((0))
|
|
/// }
|
|
///
|
|
/// // Good
|
|
/// fn simple_no_parens() -> i32 {
|
|
/// 0
|
|
/// }
|
|
///
|
|
/// // or
|
|
///
|
|
/// # fn foo(bar: usize) {}
|
|
/// // Bad
|
|
/// foo((0));
|
|
///
|
|
/// // Good
|
|
/// foo(0);
|
|
/// ```
|
|
#[clippy::version = "pre 1.29.0"]
|
|
pub DOUBLE_PARENS,
|
|
complexity,
|
|
"Warn on unnecessary double parentheses"
|
|
}
|
|
|
|
declare_lint_pass!(DoubleParens => [DOUBLE_PARENS]);
|
|
|
|
impl EarlyLintPass for DoubleParens {
|
|
fn check_expr(&mut self, cx: &EarlyContext<'_>, expr: &Expr) {
|
|
if expr.span.from_expansion() {
|
|
return;
|
|
}
|
|
|
|
let msg: &str = "consider removing unnecessary double parentheses";
|
|
|
|
match expr.kind {
|
|
ExprKind::Paren(ref in_paren) => match in_paren.kind {
|
|
ExprKind::Paren(_) | ExprKind::Tup(_) => {
|
|
span_lint(cx, DOUBLE_PARENS, expr.span, msg);
|
|
},
|
|
_ => {},
|
|
},
|
|
ExprKind::Call(_, ref params) => {
|
|
if params.len() == 1 {
|
|
let param = ¶ms[0];
|
|
if let ExprKind::Paren(_) = param.kind {
|
|
span_lint(cx, DOUBLE_PARENS, param.span, msg);
|
|
}
|
|
}
|
|
},
|
|
ExprKind::MethodCall(_, ref params, _) => {
|
|
if params.len() == 2 {
|
|
let param = ¶ms[1];
|
|
if let ExprKind::Paren(_) = param.kind {
|
|
span_lint(cx, DOUBLE_PARENS, param.span, msg);
|
|
}
|
|
}
|
|
},
|
|
_ => {},
|
|
}
|
|
}
|
|
}
|