mirror of
https://github.com/rust-lang/rust-clippy
synced 2024-11-24 13:43:17 +00:00
a6d8afd958
Fixes #9431. The current `range_plus_one` and `range_minus_one` suggestions are completely incorrect when macros are involved. This commit resolves this by disabling the lints for any range expression that is expanded from a macro. The reasons for this are that it is very difficult to create a correct suggestion in this case and that false negatives are less important for pedantic lints.
60 lines
1.7 KiB
Text
60 lines
1.7 KiB
Text
error: an inclusive range would be more readable
|
|
--> $DIR/range_plus_minus_one.rs:31:14
|
|
|
|
|
LL | for _ in 0..3 + 1 {}
|
|
| ^^^^^^^^ help: use: `0..=3`
|
|
|
|
|
= note: `-D clippy::range-plus-one` implied by `-D warnings`
|
|
|
|
error: an inclusive range would be more readable
|
|
--> $DIR/range_plus_minus_one.rs:34:14
|
|
|
|
|
LL | for _ in 0..1 + 5 {}
|
|
| ^^^^^^^^ help: use: `0..=5`
|
|
|
|
error: an inclusive range would be more readable
|
|
--> $DIR/range_plus_minus_one.rs:37:14
|
|
|
|
|
LL | for _ in 1..1 + 1 {}
|
|
| ^^^^^^^^ help: use: `1..=1`
|
|
|
|
error: an inclusive range would be more readable
|
|
--> $DIR/range_plus_minus_one.rs:43:14
|
|
|
|
|
LL | for _ in 0..(1 + f()) {}
|
|
| ^^^^^^^^^^^^ help: use: `0..=f()`
|
|
|
|
error: an exclusive range would be more readable
|
|
--> $DIR/range_plus_minus_one.rs:47:13
|
|
|
|
|
LL | let _ = ..=11 - 1;
|
|
| ^^^^^^^^^ help: use: `..11`
|
|
|
|
|
= note: `-D clippy::range-minus-one` implied by `-D warnings`
|
|
|
|
error: an exclusive range would be more readable
|
|
--> $DIR/range_plus_minus_one.rs:48:13
|
|
|
|
|
LL | let _ = ..=(11 - 1);
|
|
| ^^^^^^^^^^^ help: use: `..11`
|
|
|
|
error: an inclusive range would be more readable
|
|
--> $DIR/range_plus_minus_one.rs:49:13
|
|
|
|
|
LL | let _ = (1..11 + 1);
|
|
| ^^^^^^^^^^^ help: use: `(1..=11)`
|
|
|
|
error: an inclusive range would be more readable
|
|
--> $DIR/range_plus_minus_one.rs:50:13
|
|
|
|
|
LL | let _ = (f() + 1)..(f() + 1);
|
|
| ^^^^^^^^^^^^^^^^^^^^ help: use: `((f() + 1)..=f())`
|
|
|
|
error: an inclusive range would be more readable
|
|
--> $DIR/range_plus_minus_one.rs:54:14
|
|
|
|
|
LL | for _ in 1..ONE + ONE {}
|
|
| ^^^^^^^^^^^^ help: use: `1..=ONE`
|
|
|
|
error: aborting due to 9 previous errors
|
|
|