mirror of
https://github.com/rust-lang/rust-clippy
synced 2024-11-30 16:39:26 +00:00
f743fec6b0
Clippy had a false positive for with `ifs_same_cond` when two
if-let expressions have an `option_env!` macro. The fix is similar to the
`env!` macro fix.
The following example had a clippy error:
```rust
if let Some(env1) = option_env!("ENV1") {
// ...
} else if let Some(env2) = option_env!("ENV2") {
// ...
}
```
See https://play.rust-lang.org/?version=stable&mode=debug&edition=2021&gist=01b85c61b56ddd900117fb247af04824
changelog: Fix [`ifs_same_cond`] false positive when using `option_env!` in if-let expressions.
82 lines
1.7 KiB
Rust
82 lines
1.7 KiB
Rust
#![warn(clippy::ifs_same_cond)]
|
|
#![allow(
|
|
clippy::if_same_then_else,
|
|
clippy::comparison_chain,
|
|
clippy::needless_if,
|
|
clippy::needless_else
|
|
)] // all empty blocks
|
|
|
|
fn ifs_same_cond() {
|
|
let a = 0;
|
|
let b = false;
|
|
|
|
if b {
|
|
} else if b {
|
|
//~^ ERROR: this `if` has the same condition as a previous `if`
|
|
}
|
|
|
|
if a == 1 {
|
|
} else if a == 1 {
|
|
//~^ ERROR: this `if` has the same condition as a previous `if`
|
|
}
|
|
|
|
if 2 * a == 1 {
|
|
} else if 2 * a == 2 {
|
|
} else if 2 * a == 1 {
|
|
//~^ ERROR: this `if` has the same condition as a previous `if`
|
|
} else if a == 1 {
|
|
}
|
|
|
|
// See #659
|
|
if cfg!(feature = "feature1-659") {
|
|
1
|
|
} else if cfg!(feature = "feature2-659") {
|
|
2
|
|
} else {
|
|
3
|
|
};
|
|
|
|
let mut v = vec![1];
|
|
if v.pop().is_none() {
|
|
// ok, functions
|
|
} else if v.pop().is_none() {
|
|
}
|
|
|
|
if v.len() == 42 {
|
|
// ok, functions
|
|
} else if v.len() == 42 {
|
|
}
|
|
|
|
if let Some(env1) = option_env!("ENV1") {
|
|
} else if let Some(env2) = option_env!("ENV2") {
|
|
}
|
|
}
|
|
|
|
fn issue10272() {
|
|
let a = String::from("ha");
|
|
if a.contains("ah") {
|
|
} else if a.contains("ah") {
|
|
//~^ ERROR: this `if` has the same condition as a previous `if`
|
|
// Trigger this lint
|
|
} else if a.contains("ha") {
|
|
} else if a == "wow" {
|
|
}
|
|
|
|
let p: *mut i8 = std::ptr::null_mut();
|
|
if p.is_null() {
|
|
} else if p.align_offset(0) == 0 {
|
|
} else if p.is_null() {
|
|
// ok, p is mutable pointer
|
|
} else {
|
|
}
|
|
|
|
let x = std::cell::Cell::new(true);
|
|
if x.get() {
|
|
} else if !x.take() {
|
|
} else if x.get() {
|
|
// ok, x is interior mutable type
|
|
} else {
|
|
}
|
|
}
|
|
|
|
fn main() {}
|