mirror of
https://github.com/rust-lang/rust-clippy
synced 2024-11-14 00:47:16 +00:00
5572476a36
This lint will complain when you put a mutable function/method call inside a `debug_assert` macro, because it will not be executed in release mode, therefore it will change the execution flow, which is not wanted.
124 lines
3.4 KiB
Rust
124 lines
3.4 KiB
Rust
#![feature(custom_inner_attributes)]
|
|
#![rustfmt::skip]
|
|
#![allow(clippy::trivially_copy_pass_by_ref, clippy::cognitive_complexity, clippy::redundant_closure_call)]
|
|
|
|
struct S;
|
|
|
|
impl S {
|
|
fn bool_self_ref(&self) -> bool { false }
|
|
fn bool_self_mut(&mut self) -> bool { false }
|
|
fn bool_self_ref_arg_ref(&self, _: &u32) -> bool { false }
|
|
fn bool_self_ref_arg_mut(&self, _: &mut u32) -> bool { false }
|
|
fn bool_self_mut_arg_ref(&mut self, _: &u32) -> bool { false }
|
|
fn bool_self_mut_arg_mut(&mut self, _: &mut u32) -> bool { false }
|
|
|
|
fn u32_self_ref(&self) -> u32 { 0 }
|
|
fn u32_self_mut(&mut self) -> u32 { 0 }
|
|
fn u32_self_ref_arg_ref(&self, _: &u32) -> u32 { 0 }
|
|
fn u32_self_ref_arg_mut(&self, _: &mut u32) -> u32 { 0 }
|
|
fn u32_self_mut_arg_ref(&mut self, _: &u32) -> u32 { 0 }
|
|
fn u32_self_mut_arg_mut(&mut self, _: &mut u32) -> u32 { 0 }
|
|
}
|
|
|
|
fn bool_ref(_: &u32) -> bool { false }
|
|
fn bool_mut(_: &mut u32) -> bool { false }
|
|
fn u32_ref(_: &u32) -> u32 { 0 }
|
|
fn u32_mut(_: &mut u32) -> u32 { 0 }
|
|
|
|
fn func_non_mutable() {
|
|
debug_assert!(bool_ref(&3));
|
|
debug_assert!(!bool_ref(&3));
|
|
|
|
debug_assert_eq!(0, u32_ref(&3));
|
|
debug_assert_eq!(u32_ref(&3), 0);
|
|
|
|
debug_assert_ne!(1, u32_ref(&3));
|
|
debug_assert_ne!(u32_ref(&3), 1);
|
|
}
|
|
|
|
fn func_mutable() {
|
|
debug_assert!(bool_mut(&mut 3));
|
|
debug_assert!(!bool_mut(&mut 3));
|
|
|
|
debug_assert_eq!(0, u32_mut(&mut 3));
|
|
debug_assert_eq!(u32_mut(&mut 3), 0);
|
|
|
|
debug_assert_ne!(1, u32_mut(&mut 3));
|
|
debug_assert_ne!(u32_mut(&mut 3), 1);
|
|
}
|
|
|
|
fn method_non_mutable() {
|
|
debug_assert!(S.bool_self_ref());
|
|
debug_assert!(S.bool_self_ref_arg_ref(&3));
|
|
|
|
debug_assert_eq!(S.u32_self_ref(), 0);
|
|
debug_assert_eq!(S.u32_self_ref_arg_ref(&3), 0);
|
|
|
|
debug_assert_ne!(S.u32_self_ref(), 1);
|
|
debug_assert_ne!(S.u32_self_ref_arg_ref(&3), 1);
|
|
}
|
|
|
|
fn method_mutable() {
|
|
debug_assert!(S.bool_self_mut());
|
|
debug_assert!(!S.bool_self_mut());
|
|
debug_assert!(S.bool_self_ref_arg_mut(&mut 3));
|
|
debug_assert!(S.bool_self_mut_arg_ref(&3));
|
|
debug_assert!(S.bool_self_mut_arg_mut(&mut 3));
|
|
|
|
debug_assert_eq!(S.u32_self_mut(), 0);
|
|
debug_assert_eq!(S.u32_self_mut_arg_ref(&3), 0);
|
|
debug_assert_eq!(S.u32_self_ref_arg_mut(&mut 3), 0);
|
|
debug_assert_eq!(S.u32_self_mut_arg_mut(&mut 3), 0);
|
|
|
|
debug_assert_ne!(S.u32_self_mut(), 1);
|
|
debug_assert_ne!(S.u32_self_mut_arg_ref(&3), 1);
|
|
debug_assert_ne!(S.u32_self_ref_arg_mut(&mut 3), 1);
|
|
debug_assert_ne!(S.u32_self_mut_arg_mut(&mut 3), 1);
|
|
}
|
|
|
|
fn misc() {
|
|
// with variable
|
|
let mut v: Vec<u32> = vec![1, 2, 3, 4];
|
|
debug_assert_eq!(v.get(0), Some(&1));
|
|
debug_assert_ne!(v[0], 2);
|
|
debug_assert_eq!(v.pop(), Some(1));
|
|
debug_assert_ne!(Some(3), v.pop());
|
|
|
|
let a = &mut 3;
|
|
debug_assert!(bool_mut(a));
|
|
|
|
// nested
|
|
debug_assert!(!(bool_ref(&u32_mut(&mut 3))));
|
|
|
|
// chained
|
|
debug_assert_eq!(v.pop().unwrap(), 3);
|
|
|
|
// format args
|
|
debug_assert!(bool_ref(&3), "w/o format");
|
|
debug_assert!(bool_mut(&mut 3), "w/o format");
|
|
debug_assert!(bool_ref(&3), "{} format", "w/");
|
|
debug_assert!(bool_mut(&mut 3), "{} format", "w/");
|
|
|
|
// sub block
|
|
let mut x = 42_u32;
|
|
debug_assert!({
|
|
bool_mut(&mut x);
|
|
x > 10
|
|
});
|
|
|
|
// closures
|
|
debug_assert!((|| {
|
|
let mut x = 42;
|
|
bool_mut(&mut x);
|
|
x > 10
|
|
})());
|
|
}
|
|
|
|
fn main() {
|
|
func_non_mutable();
|
|
func_mutable();
|
|
method_non_mutable();
|
|
method_mutable();
|
|
|
|
misc();
|
|
}
|