mirror of
https://github.com/rust-lang/rust-clippy
synced 2024-11-14 00:47:16 +00:00
ac9dd36856
The only reason to use `abort_if_errors` is when the program is so broken that either: 1. later passes get confused and ICE 2. any diagnostics from later passes would be noise This is never the case for lints, because the compiler has to be able to deal with `allow`-ed lints. So it can continue to lint and compile even if there are lint errors.
131 lines
4.4 KiB
Text
131 lines
4.4 KiB
Text
error: this `else` block is redundant
|
|
--> $DIR/needless_continue.rs:29:16
|
|
|
|
|
LL | } else {
|
|
| ________________^
|
|
LL | | continue;
|
|
LL | | }
|
|
| |_________^
|
|
|
|
|
= note: `-D clippy::needless-continue` implied by `-D warnings`
|
|
= help: consider dropping the `else` clause and merging the code that follows (in the loop) with the `if` block
|
|
if i % 2 == 0 && i % 3 == 0 {
|
|
println!("{}", i);
|
|
println!("{}", i + 1);
|
|
if i % 5 == 0 {
|
|
println!("{}", i + 2);
|
|
}
|
|
let i = 0;
|
|
println!("bar {} ", i);
|
|
// merged code follows:
|
|
println!("bleh");
|
|
{
|
|
println!("blah");
|
|
}
|
|
if !(!(i == 2) || !(i == 5)) {
|
|
println!("lama");
|
|
}
|
|
if (zero!(i % 2) || nonzero!(i % 5)) && i % 3 != 0 {
|
|
continue;
|
|
} else {
|
|
println!("Blabber");
|
|
println!("Jabber");
|
|
}
|
|
println!("bleh");
|
|
}
|
|
|
|
error: there is no need for an explicit `else` block for this `if` expression
|
|
--> $DIR/needless_continue.rs:44:9
|
|
|
|
|
LL | / if (zero!(i % 2) || nonzero!(i % 5)) && i % 3 != 0 {
|
|
LL | | continue;
|
|
LL | | } else {
|
|
LL | | println!("Blabber");
|
|
LL | | println!("Jabber");
|
|
LL | | }
|
|
| |_________^
|
|
|
|
|
= help: consider dropping the `else` clause
|
|
if (zero!(i % 2) || nonzero!(i % 5)) && i % 3 != 0 {
|
|
continue;
|
|
}
|
|
{
|
|
println!("Blabber");
|
|
println!("Jabber");
|
|
}
|
|
|
|
error: this `continue` expression is redundant
|
|
--> $DIR/needless_continue.rs:57:9
|
|
|
|
|
LL | continue; // should lint here
|
|
| ^^^^^^^^^
|
|
|
|
|
= help: consider dropping the `continue` expression
|
|
|
|
error: this `continue` expression is redundant
|
|
--> $DIR/needless_continue.rs:64:9
|
|
|
|
|
LL | continue; // should lint here
|
|
| ^^^^^^^^^
|
|
|
|
|
= help: consider dropping the `continue` expression
|
|
|
|
error: this `continue` expression is redundant
|
|
--> $DIR/needless_continue.rs:71:9
|
|
|
|
|
LL | continue // should lint here
|
|
| ^^^^^^^^
|
|
|
|
|
= help: consider dropping the `continue` expression
|
|
|
|
error: this `continue` expression is redundant
|
|
--> $DIR/needless_continue.rs:79:9
|
|
|
|
|
LL | continue // should lint here
|
|
| ^^^^^^^^
|
|
|
|
|
= help: consider dropping the `continue` expression
|
|
|
|
error: this `else` block is redundant
|
|
--> $DIR/needless_continue.rs:129:24
|
|
|
|
|
LL | } else {
|
|
| ________________________^
|
|
LL | | continue 'inner; // should lint here
|
|
LL | | }
|
|
| |_________________^
|
|
|
|
|
= help: consider dropping the `else` clause and merging the code that follows (in the loop) with the `if` block
|
|
if condition() {
|
|
println!("bar-3");
|
|
// merged code follows:
|
|
println!("bar-4");
|
|
update_condition();
|
|
if condition() {
|
|
continue; // should lint here
|
|
} else {
|
|
println!("bar-5");
|
|
}
|
|
println!("bar-6");
|
|
}
|
|
|
|
error: there is no need for an explicit `else` block for this `if` expression
|
|
--> $DIR/needless_continue.rs:135:17
|
|
|
|
|
LL | / if condition() {
|
|
LL | | continue; // should lint here
|
|
LL | | } else {
|
|
LL | | println!("bar-5");
|
|
LL | | }
|
|
| |_________________^
|
|
|
|
|
= help: consider dropping the `else` clause
|
|
if condition() {
|
|
continue; // should lint here
|
|
}
|
|
{
|
|
println!("bar-5");
|
|
}
|
|
|
|
error: aborting due to 8 previous errors
|
|
|