mirror of
https://github.com/rust-lang/rust-clippy
synced 2024-11-24 05:33:27 +00:00
73 lines
2.5 KiB
Text
73 lines
2.5 KiB
Text
error: calling `Mutex::lock` inside the scope of another `Mutex::lock` causes a deadlock
|
|
--> tests/ui/if_let_mutex.rs:11:5
|
|
|
|
|
LL | if let Err(locked) = m.lock() {
|
|
| ^ - this Mutex will remain locked for the entire `if let`-block...
|
|
| _____|
|
|
| |
|
|
LL | |
|
|
LL | | do_stuff(locked);
|
|
LL | | } else {
|
|
LL | | let lock = m.lock().unwrap();
|
|
| | - ... and is tried to lock again here, which will always deadlock.
|
|
LL | | do_stuff(lock);
|
|
LL | | };
|
|
| |_____^
|
|
|
|
|
= help: move the lock call outside of the `if let ...` expression
|
|
= note: `-D clippy::if-let-mutex` implied by `-D warnings`
|
|
= help: to override `-D warnings` add `#[allow(clippy::if_let_mutex)]`
|
|
|
|
error: calling `Mutex::lock` inside the scope of another `Mutex::lock` causes a deadlock
|
|
--> tests/ui/if_let_mutex.rs:24:5
|
|
|
|
|
LL | if let Some(locked) = m.lock().unwrap().deref() {
|
|
| ^ - this Mutex will remain locked for the entire `if let`-block...
|
|
| _____|
|
|
| |
|
|
LL | |
|
|
LL | | do_stuff(locked);
|
|
LL | | } else {
|
|
LL | | let lock = m.lock().unwrap();
|
|
| | - ... and is tried to lock again here, which will always deadlock.
|
|
LL | | do_stuff(lock);
|
|
LL | | };
|
|
| |_____^
|
|
|
|
|
= help: move the lock call outside of the `if let ...` expression
|
|
|
|
error: calling `Mutex::lock` inside the scope of another `Mutex::lock` causes a deadlock
|
|
--> tests/ui/if_let_mutex.rs:46:5
|
|
|
|
|
LL | if let Ok(i) = mutex.lock() {
|
|
| ^ ----- this Mutex will remain locked for the entire `if let`-block...
|
|
| _____|
|
|
| |
|
|
LL | |
|
|
LL | | do_stuff(i);
|
|
LL | | } else {
|
|
LL | | let _x = mutex.lock();
|
|
| | ----- ... and is tried to lock again here, which will always deadlock.
|
|
LL | | };
|
|
| |_____^
|
|
|
|
|
= help: move the lock call outside of the `if let ...` expression
|
|
|
|
error: calling `Mutex::lock` inside the scope of another `Mutex::lock` causes a deadlock
|
|
--> tests/ui/if_let_mutex.rs:55:5
|
|
|
|
|
LL | if let Ok(_) = m1.lock() {
|
|
| ^ -- this Mutex will remain locked for the entire `if let`-block...
|
|
| _____|
|
|
| |
|
|
LL | | m2.lock();
|
|
LL | | } else {
|
|
LL | | m1.lock();
|
|
| | -- ... and is tried to lock again here, which will always deadlock.
|
|
LL | | }
|
|
| |_____^
|
|
|
|
|
= help: move the lock call outside of the `if let ...` expression
|
|
|
|
error: aborting due to 4 previous errors
|
|
|