mirror of
https://github.com/rust-lang/rust-clippy
synced 2025-01-26 03:45:00 +00:00
42 lines
1.3 KiB
Rust
42 lines
1.3 KiB
Rust
use super::TRANSMUTE_INT_TO_BOOL;
|
|
use clippy_utils::diagnostics::span_lint_and_then;
|
|
use clippy_utils::sugg;
|
|
use rustc_ast as ast;
|
|
use rustc_errors::Applicability;
|
|
use rustc_hir::Expr;
|
|
use rustc_lint::LateContext;
|
|
use rustc_middle::ty::{self, Ty};
|
|
use std::borrow::Cow;
|
|
|
|
/// Checks for `transmute_int_to_bool` lint.
|
|
/// Returns `true` if it's triggered, otherwise returns `false`.
|
|
pub(super) fn check<'tcx>(
|
|
cx: &LateContext<'tcx>,
|
|
e: &'tcx Expr<'_>,
|
|
from_ty: Ty<'tcx>,
|
|
to_ty: Ty<'tcx>,
|
|
arg: &'tcx Expr<'_>,
|
|
) -> bool {
|
|
match (&from_ty.kind(), &to_ty.kind()) {
|
|
(ty::Int(ty::IntTy::I8) | ty::Uint(ty::UintTy::U8), ty::Bool) => {
|
|
span_lint_and_then(
|
|
cx,
|
|
TRANSMUTE_INT_TO_BOOL,
|
|
e.span,
|
|
&format!("transmute from a `{}` to a `bool`", from_ty),
|
|
|diag| {
|
|
let arg = sugg::Sugg::hir(cx, arg, "..");
|
|
let zero = sugg::Sugg::NonParen(Cow::from("0"));
|
|
diag.span_suggestion(
|
|
e.span,
|
|
"consider using",
|
|
sugg::make_binop(ast::BinOpKind::Ne, &arg, &zero).to_string(),
|
|
Applicability::Unspecified,
|
|
);
|
|
},
|
|
);
|
|
true
|
|
},
|
|
_ => false,
|
|
}
|
|
}
|