mirror of
https://github.com/rust-lang/rust-clippy
synced 2025-01-01 15:59:05 +00:00
d647696c1f
So, some context for this, well, more a story. I'm not used to scripting, I've never really scripted anything, even if it's a valuable skill. I just never really needed it. Now, `@flip1995` correctly suggested using a script for this in `rust-clippy#7813`...
And I decided to write a script using nushell because why not? This was a mistake... I spend way more time on this than I would like to admit. It has definitely been more than 4 hours. It shouldn't take that long, but me being new to scripting and nushell just wasn't a good mixture... Anyway, here is the script that creates another script which adds the versions. Fun...
Just execute this on the `gh-pages` branch and the resulting `replacer.sh` in `clippy_lints` and it should all work.
```nu
mv v0.0.212 rust-1.00.0;
mv beta rust-1.57.0;
mv master rust-1.58.0;
let paths = (open ./rust-1.58.0/lints.json | select id id_span | flatten | select id path);
let versions = (
ls | where name =~ "rust-" | select name | format {name}/lints.json |
each { open $it | select id | insert version $it | str substring "5,11" version} |
group-by id | rotate counter-clockwise id version |
update version {get version | first 1} | flatten | select id version);
$paths | each { |row|
let version = ($versions | where id == ($row.id) | format {version})
let idu = ($row.id | str upcase)
$"sed -i '0,/($idu),/{s/pub ($idu),/#[clippy::version = "($version)"]\n pub ($idu),/}' ($row.path)"
} | str collect ";" | str find-replace --all '1.00.0' 'pre 1.29.0' | save "replacer.sh";
```
And this still has some problems, but at this point I just want to be done -.-
56 lines
1.6 KiB
Rust
56 lines
1.6 KiB
Rust
use clippy_utils::diagnostics::span_lint;
|
|
use clippy_utils::eq_expr_value;
|
|
use clippy_utils::source::snippet;
|
|
use rustc_hir::{Expr, ExprKind};
|
|
use rustc_lint::{LateContext, LateLintPass};
|
|
use rustc_session::{declare_lint_pass, declare_tool_lint};
|
|
|
|
declare_clippy_lint! {
|
|
/// ### What it does
|
|
/// Checks for explicit self-assignments.
|
|
///
|
|
/// ### Why is this bad?
|
|
/// Self-assignments are redundant and unlikely to be
|
|
/// intentional.
|
|
///
|
|
/// ### Known problems
|
|
/// If expression contains any deref coercions or
|
|
/// indexing operations they are assumed not to have any side effects.
|
|
///
|
|
/// ### Example
|
|
/// ```rust
|
|
/// struct Event {
|
|
/// id: usize,
|
|
/// x: i32,
|
|
/// y: i32,
|
|
/// }
|
|
///
|
|
/// fn copy_position(a: &mut Event, b: &Event) {
|
|
/// a.x = b.x;
|
|
/// a.y = a.y;
|
|
/// }
|
|
/// ```
|
|
#[clippy::version = "1.48.0"]
|
|
pub SELF_ASSIGNMENT,
|
|
correctness,
|
|
"explicit self-assignment"
|
|
}
|
|
|
|
declare_lint_pass!(SelfAssignment => [SELF_ASSIGNMENT]);
|
|
|
|
impl<'tcx> LateLintPass<'tcx> for SelfAssignment {
|
|
fn check_expr(&mut self, cx: &LateContext<'tcx>, expr: &'tcx Expr<'_>) {
|
|
if let ExprKind::Assign(lhs, rhs, _) = &expr.kind {
|
|
if eq_expr_value(cx, lhs, rhs) {
|
|
let lhs = snippet(cx, lhs.span, "<lhs>");
|
|
let rhs = snippet(cx, rhs.span, "<rhs>");
|
|
span_lint(
|
|
cx,
|
|
SELF_ASSIGNMENT,
|
|
expr.span,
|
|
&format!("self-assignment of `{}` to `{}`", rhs, lhs),
|
|
);
|
|
}
|
|
}
|
|
}
|
|
}
|