mirror of
https://github.com/rust-lang/rust-clippy
synced 2024-11-30 16:39:26 +00:00
215 lines
8.2 KiB
Text
215 lines
8.2 KiB
Text
error: defining a method called `add` on this type; consider implementing the `std::ops::Add` trait or choosing a less ambiguous name
|
|
--> $DIR/methods.rs:35:5
|
|
|
|
|
LL | / pub fn add(self, other: T) -> T {
|
|
LL | | self
|
|
LL | | }
|
|
| |_____^
|
|
|
|
|
= note: `-D clippy::should-implement-trait` implied by `-D warnings`
|
|
|
|
error: methods called `into_*` usually take self by value; consider choosing a less ambiguous name
|
|
--> $DIR/methods.rs:70:17
|
|
|
|
|
LL | fn into_u16(&self) -> u16 {
|
|
| ^^^^^
|
|
|
|
|
= note: `-D clippy::wrong-self-convention` implied by `-D warnings`
|
|
|
|
error: methods called `to_*` usually take self by reference; consider choosing a less ambiguous name
|
|
--> $DIR/methods.rs:74:21
|
|
|
|
|
LL | fn to_something(self) -> u32 {
|
|
| ^^^^
|
|
|
|
error: methods called `new` usually take no self; consider choosing a less ambiguous name
|
|
--> $DIR/methods.rs:78:12
|
|
|
|
|
LL | fn new(self) -> Self {
|
|
| ^^^^
|
|
|
|
error: called `map(f).unwrap_or(a)` on an Option value. This can be done more directly by calling `map_or(a, f)` instead
|
|
--> $DIR/methods.rs:157:13
|
|
|
|
|
LL | let _ = opt.map(|x| x + 1)
|
|
| _____________^
|
|
LL | | // Should lint even though this call is on a separate line.
|
|
LL | | .unwrap_or(0);
|
|
| |____________________________^
|
|
|
|
|
= note: `-D clippy::option-map-unwrap-or` implied by `-D warnings`
|
|
= note: replace `map(|x| x + 1).unwrap_or(0)` with `map_or(0, |x| x + 1)`
|
|
|
|
error: called `map(f).unwrap_or(a)` on an Option value. This can be done more directly by calling `map_or(a, f)` instead
|
|
--> $DIR/methods.rs:161:13
|
|
|
|
|
LL | let _ = opt.map(|x| {
|
|
| _____________^
|
|
LL | | x + 1
|
|
LL | | }
|
|
LL | | ).unwrap_or(0);
|
|
| |____________________________^
|
|
|
|
error: called `map(f).unwrap_or(a)` on an Option value. This can be done more directly by calling `map_or(a, f)` instead
|
|
--> $DIR/methods.rs:165:13
|
|
|
|
|
LL | let _ = opt.map(|x| x + 1)
|
|
| _____________^
|
|
LL | | .unwrap_or({
|
|
LL | | 0
|
|
LL | | });
|
|
| |__________________^
|
|
|
|
error: called `map(f).unwrap_or(None)` on an Option value. This can be done more directly by calling `and_then(f)` instead
|
|
--> $DIR/methods.rs:170:13
|
|
|
|
|
LL | let _ = opt.map(|x| Some(x + 1)).unwrap_or(None);
|
|
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
|
|
|
|
= note: replace `map(|x| Some(x + 1)).unwrap_or(None)` with `and_then(|x| Some(x + 1))`
|
|
|
|
error: called `map(f).unwrap_or(None)` on an Option value. This can be done more directly by calling `and_then(f)` instead
|
|
--> $DIR/methods.rs:172:13
|
|
|
|
|
LL | let _ = opt.map(|x| {
|
|
| _____________^
|
|
LL | | Some(x + 1)
|
|
LL | | }
|
|
LL | | ).unwrap_or(None);
|
|
| |_____________________^
|
|
|
|
error: called `map(f).unwrap_or(None)` on an Option value. This can be done more directly by calling `and_then(f)` instead
|
|
--> $DIR/methods.rs:176:13
|
|
|
|
|
LL | let _ = opt
|
|
| _____________^
|
|
LL | | .map(|x| Some(x + 1))
|
|
LL | | .unwrap_or(None);
|
|
| |________________________^
|
|
|
|
|
= note: replace `map(|x| Some(x + 1)).unwrap_or(None)` with `and_then(|x| Some(x + 1))`
|
|
|
|
error: called `map(f).unwrap_or(a)` on an Option value. This can be done more directly by calling `map_or(a, f)` instead
|
|
--> $DIR/methods.rs:187:13
|
|
|
|
|
LL | let _ = Some("prefix").map(|p| format!("{}.", p)).unwrap_or(id);
|
|
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
|
|
|
|
= note: replace `map(|p| format!("{}.", p)).unwrap_or(id)` with `map_or(id, |p| format!("{}.", p))`
|
|
|
|
error: called `map(f).unwrap_or_else(g)` on an Option value. This can be done more directly by calling `map_or_else(g, f)` instead
|
|
--> $DIR/methods.rs:191:13
|
|
|
|
|
LL | let _ = opt.map(|x| x + 1)
|
|
| _____________^
|
|
LL | | // Should lint even though this call is on a separate line.
|
|
LL | | .unwrap_or_else(|| 0);
|
|
| |____________________________________^
|
|
|
|
|
= note: `-D clippy::option-map-unwrap-or-else` implied by `-D warnings`
|
|
= note: replace `map(|x| x + 1).unwrap_or_else(|| 0)` with `map_or_else(|| 0, |x| x + 1)`
|
|
|
|
error: called `map(f).unwrap_or_else(g)` on an Option value. This can be done more directly by calling `map_or_else(g, f)` instead
|
|
--> $DIR/methods.rs:195:13
|
|
|
|
|
LL | let _ = opt.map(|x| {
|
|
| _____________^
|
|
LL | | x + 1
|
|
LL | | }
|
|
LL | | ).unwrap_or_else(|| 0);
|
|
| |____________________________________^
|
|
|
|
error: called `map(f).unwrap_or_else(g)` on an Option value. This can be done more directly by calling `map_or_else(g, f)` instead
|
|
--> $DIR/methods.rs:199:13
|
|
|
|
|
LL | let _ = opt.map(|x| x + 1)
|
|
| _____________^
|
|
LL | | .unwrap_or_else(||
|
|
LL | | 0
|
|
LL | | );
|
|
| |_________________^
|
|
|
|
error: called `filter(p).next()` on an `Iterator`. This is more succinctly expressed by calling `.find(p)` instead.
|
|
--> $DIR/methods.rs:229:13
|
|
|
|
|
LL | let _ = v.iter().filter(|&x| *x < 0).next();
|
|
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
|
|
|
|
= note: `-D clippy::filter-next` implied by `-D warnings`
|
|
= note: replace `filter(|&x| *x < 0).next()` with `find(|&x| *x < 0)`
|
|
|
|
error: called `filter(p).next()` on an `Iterator`. This is more succinctly expressed by calling `.find(p)` instead.
|
|
--> $DIR/methods.rs:232:13
|
|
|
|
|
LL | let _ = v.iter().filter(|&x| {
|
|
| _____________^
|
|
LL | | *x < 0
|
|
LL | | }
|
|
LL | | ).next();
|
|
| |___________________________^
|
|
|
|
error: called `is_some()` after searching an `Iterator` with find. This is more succinctly expressed by calling `any()`.
|
|
--> $DIR/methods.rs:248:13
|
|
|
|
|
LL | let _ = v.iter().find(|&x| *x < 0).is_some();
|
|
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
|
|
|
|
= note: `-D clippy::search-is-some` implied by `-D warnings`
|
|
= note: replace `find(|&x| *x < 0).is_some()` with `any(|x| *x < 0)`
|
|
|
|
error: called `is_some()` after searching an `Iterator` with find. This is more succinctly expressed by calling `any()`.
|
|
--> $DIR/methods.rs:251:13
|
|
|
|
|
LL | let _ = v.iter().find(|&x| {
|
|
| _____________^
|
|
LL | | *x < 0
|
|
LL | | }
|
|
LL | | ).is_some();
|
|
| |______________________________^
|
|
|
|
error: called `is_some()` after searching an `Iterator` with position. This is more succinctly expressed by calling `any()`.
|
|
--> $DIR/methods.rs:257:13
|
|
|
|
|
LL | let _ = v.iter().position(|&x| x < 0).is_some();
|
|
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
|
|
|
|
= note: replace `position(|&x| x < 0).is_some()` with `any(|&x| x < 0)`
|
|
|
|
error: called `is_some()` after searching an `Iterator` with position. This is more succinctly expressed by calling `any()`.
|
|
--> $DIR/methods.rs:260:13
|
|
|
|
|
LL | let _ = v.iter().position(|&x| {
|
|
| _____________^
|
|
LL | | x < 0
|
|
LL | | }
|
|
LL | | ).is_some();
|
|
| |______________________________^
|
|
|
|
error: called `is_some()` after searching an `Iterator` with rposition. This is more succinctly expressed by calling `any()`.
|
|
--> $DIR/methods.rs:266:13
|
|
|
|
|
LL | let _ = v.iter().rposition(|&x| x < 0).is_some();
|
|
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
|
|
|
|
= note: replace `rposition(|&x| x < 0).is_some()` with `any(|&x| x < 0)`
|
|
|
|
error: called `is_some()` after searching an `Iterator` with rposition. This is more succinctly expressed by calling `any()`.
|
|
--> $DIR/methods.rs:269:13
|
|
|
|
|
LL | let _ = v.iter().rposition(|&x| {
|
|
| _____________^
|
|
LL | | x < 0
|
|
LL | | }
|
|
LL | | ).is_some();
|
|
| |______________________________^
|
|
|
|
error: used unwrap() on an Option value. If you don't want to handle the None case gracefully, consider using expect() to provide a better panic message
|
|
--> $DIR/methods.rs:284:13
|
|
|
|
|
LL | let _ = opt.unwrap();
|
|
| ^^^^^^^^^^^^
|
|
|
|
|
= note: `-D clippy::option-unwrap-used` implied by `-D warnings`
|
|
|
|
error: aborting due to 23 previous errors
|
|
|