mirror of
https://github.com/rust-lang/rust-clippy
synced 2024-11-30 16:39:26 +00:00
38d4ac7cea
Discussion previously happened in https://github.com/rust-lang/rust/pull/43498
138 lines
3.2 KiB
Text
138 lines
3.2 KiB
Text
error: variable appears on both sides of an assignment operation
|
|
--> $DIR/assign_ops2.rs:5:5
|
|
|
|
|
LL | a += a + 1;
|
|
| ^^^^^^^^^^
|
|
|
|
|
= note: `-D clippy::misrefactored-assign-op` implied by `-D warnings`
|
|
help: Did you mean a = a + 1 or a = a + a + 1? Consider replacing it with
|
|
|
|
|
LL | a += 1;
|
|
| ^^^^^^
|
|
help: or
|
|
|
|
|
LL | a = a + a + 1;
|
|
| ^^^^^^^^^^^^^
|
|
|
|
error: variable appears on both sides of an assignment operation
|
|
--> $DIR/assign_ops2.rs:6:5
|
|
|
|
|
LL | a += 1 + a;
|
|
| ^^^^^^^^^^
|
|
help: Did you mean a = a + 1 or a = a + 1 + a? Consider replacing it with
|
|
|
|
|
LL | a += 1;
|
|
| ^^^^^^
|
|
help: or
|
|
|
|
|
LL | a = a + 1 + a;
|
|
| ^^^^^^^^^^^^^
|
|
|
|
error: variable appears on both sides of an assignment operation
|
|
--> $DIR/assign_ops2.rs:7:5
|
|
|
|
|
LL | a -= a - 1;
|
|
| ^^^^^^^^^^
|
|
help: Did you mean a = a - 1 or a = a - (a - 1)? Consider replacing it with
|
|
|
|
|
LL | a -= 1;
|
|
| ^^^^^^
|
|
help: or
|
|
|
|
|
LL | a = a - (a - 1);
|
|
| ^^^^^^^^^^^^^^^
|
|
|
|
error: variable appears on both sides of an assignment operation
|
|
--> $DIR/assign_ops2.rs:8:5
|
|
|
|
|
LL | a *= a * 99;
|
|
| ^^^^^^^^^^^
|
|
help: Did you mean a = a * 99 or a = a * a * 99? Consider replacing it with
|
|
|
|
|
LL | a *= 99;
|
|
| ^^^^^^^
|
|
help: or
|
|
|
|
|
LL | a = a * a * 99;
|
|
| ^^^^^^^^^^^^^^
|
|
|
|
error: variable appears on both sides of an assignment operation
|
|
--> $DIR/assign_ops2.rs:9:5
|
|
|
|
|
LL | a *= 42 * a;
|
|
| ^^^^^^^^^^^
|
|
help: Did you mean a = a * 42 or a = a * 42 * a? Consider replacing it with
|
|
|
|
|
LL | a *= 42;
|
|
| ^^^^^^^
|
|
help: or
|
|
|
|
|
LL | a = a * 42 * a;
|
|
| ^^^^^^^^^^^^^^
|
|
|
|
error: variable appears on both sides of an assignment operation
|
|
--> $DIR/assign_ops2.rs:10:5
|
|
|
|
|
LL | a /= a / 2;
|
|
| ^^^^^^^^^^
|
|
help: Did you mean a = a / 2 or a = a / (a / 2)? Consider replacing it with
|
|
|
|
|
LL | a /= 2;
|
|
| ^^^^^^
|
|
help: or
|
|
|
|
|
LL | a = a / (a / 2);
|
|
| ^^^^^^^^^^^^^^^
|
|
|
|
error: variable appears on both sides of an assignment operation
|
|
--> $DIR/assign_ops2.rs:11:5
|
|
|
|
|
LL | a %= a % 5;
|
|
| ^^^^^^^^^^
|
|
help: Did you mean a = a % 5 or a = a % (a % 5)? Consider replacing it with
|
|
|
|
|
LL | a %= 5;
|
|
| ^^^^^^
|
|
help: or
|
|
|
|
|
LL | a = a % (a % 5);
|
|
| ^^^^^^^^^^^^^^^
|
|
|
|
error: variable appears on both sides of an assignment operation
|
|
--> $DIR/assign_ops2.rs:12:5
|
|
|
|
|
LL | a &= a & 1;
|
|
| ^^^^^^^^^^
|
|
help: Did you mean a = a & 1 or a = a & a & 1? Consider replacing it with
|
|
|
|
|
LL | a &= 1;
|
|
| ^^^^^^
|
|
help: or
|
|
|
|
|
LL | a = a & a & 1;
|
|
| ^^^^^^^^^^^^^
|
|
|
|
error: variable appears on both sides of an assignment operation
|
|
--> $DIR/assign_ops2.rs:13:5
|
|
|
|
|
LL | a *= a * a;
|
|
| ^^^^^^^^^^
|
|
help: Did you mean a = a * a or a = a * a * a? Consider replacing it with
|
|
|
|
|
LL | a *= a;
|
|
| ^^^^^^
|
|
help: or
|
|
|
|
|
LL | a = a * a * a;
|
|
| ^^^^^^^^^^^^^
|
|
|
|
error: manual implementation of an assign operation
|
|
--> $DIR/assign_ops2.rs:50:5
|
|
|
|
|
LL | buf = buf + cows.clone();
|
|
| ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `buf += cows.clone()`
|
|
|
|
|
= note: `-D clippy::assign-op-pattern` implied by `-D warnings`
|
|
|
|
error: aborting due to 10 previous errors
|
|
|