mirror of
https://github.com/rust-lang/rust-clippy
synced 2024-11-24 05:33:27 +00:00
168 lines
6.1 KiB
Text
168 lines
6.1 KiB
Text
error: redundant closure
|
|
--> $DIR/eta.rs:28:27
|
|
|
|
|
LL | let a = Some(1u8).map(|a| foo(a));
|
|
| ^^^^^^^^^^ help: replace the closure with the function itself: `foo`
|
|
|
|
|
= note: `-D clippy::redundant-closure` implied by `-D warnings`
|
|
|
|
error: redundant closure
|
|
--> $DIR/eta.rs:32:40
|
|
|
|
|
LL | let _: Option<Vec<u8>> = true.then(|| vec![]); // special case vec!
|
|
| ^^^^^^^^^ help: replace the closure with `Vec::new`: `std::vec::Vec::new`
|
|
|
|
error: redundant closure
|
|
--> $DIR/eta.rs:33:35
|
|
|
|
|
LL | let d = Some(1u8).map(|a| foo((|b| foo2(b))(a))); //is adjusted?
|
|
| ^^^^^^^^^^^^^ help: replace the closure with the function itself: `foo2`
|
|
|
|
error: redundant closure
|
|
--> $DIR/eta.rs:34:26
|
|
|
|
|
LL | all(&[1, 2, 3], &&2, |x, y| below(x, y)); //is adjusted
|
|
| ^^^^^^^^^^^^^^^^^^ help: replace the closure with the function itself: `below`
|
|
|
|
error: redundant closure
|
|
--> $DIR/eta.rs:41:27
|
|
|
|
|
LL | let e = Some(1u8).map(|a| generic(a));
|
|
| ^^^^^^^^^^^^^^ help: replace the closure with the function itself: `generic`
|
|
|
|
error: redundant closure
|
|
--> $DIR/eta.rs:93:51
|
|
|
|
|
LL | let e = Some(TestStruct { some_ref: &i }).map(|a| a.foo());
|
|
| ^^^^^^^^^^^ help: replace the closure with the method itself: `TestStruct::foo`
|
|
|
|
|
= note: `-D clippy::redundant-closure-for-method-calls` implied by `-D warnings`
|
|
|
|
error: redundant closure
|
|
--> $DIR/eta.rs:94:51
|
|
|
|
|
LL | let e = Some(TestStruct { some_ref: &i }).map(|a| a.trait_foo());
|
|
| ^^^^^^^^^^^^^^^^^ help: replace the closure with the method itself: `TestTrait::trait_foo`
|
|
|
|
error: redundant closure
|
|
--> $DIR/eta.rs:96:42
|
|
|
|
|
LL | let e = Some(&mut vec![1, 2, 3]).map(|v| v.clear());
|
|
| ^^^^^^^^^^^^^ help: replace the closure with the method itself: `std::vec::Vec::clear`
|
|
|
|
error: redundant closure
|
|
--> $DIR/eta.rs:100:29
|
|
|
|
|
LL | let e = Some("str").map(|s| s.to_string());
|
|
| ^^^^^^^^^^^^^^^^^ help: replace the closure with the method itself: `std::string::ToString::to_string`
|
|
|
|
error: redundant closure
|
|
--> $DIR/eta.rs:101:27
|
|
|
|
|
LL | let e = Some('a').map(|s| s.to_uppercase());
|
|
| ^^^^^^^^^^^^^^^^^^^^ help: replace the closure with the method itself: `char::to_uppercase`
|
|
|
|
error: redundant closure
|
|
--> $DIR/eta.rs:103:65
|
|
|
|
|
LL | let e: std::vec::Vec<char> = vec!['a', 'b', 'c'].iter().map(|c| c.to_ascii_uppercase()).collect();
|
|
| ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace the closure with the method itself: `char::to_ascii_uppercase`
|
|
|
|
error: redundant closure
|
|
--> $DIR/eta.rs:166:22
|
|
|
|
|
LL | requires_fn_once(|| x());
|
|
| ^^^^^^ help: replace the closure with the function itself: `x`
|
|
|
|
error: redundant closure
|
|
--> $DIR/eta.rs:173:27
|
|
|
|
|
LL | let a = Some(1u8).map(|a| foo_ptr(a));
|
|
| ^^^^^^^^^^^^^^ help: replace the closure with the function itself: `foo_ptr`
|
|
|
|
error: redundant closure
|
|
--> $DIR/eta.rs:178:27
|
|
|
|
|
LL | let a = Some(1u8).map(|a| closure(a));
|
|
| ^^^^^^^^^^^^^^ help: replace the closure with the function itself: `closure`
|
|
|
|
error: redundant closure
|
|
--> $DIR/eta.rs:210:28
|
|
|
|
|
LL | x.into_iter().for_each(|x| add_to_res(x));
|
|
| ^^^^^^^^^^^^^^^^^ help: replace the closure with the function itself: `&mut add_to_res`
|
|
|
|
error: redundant closure
|
|
--> $DIR/eta.rs:211:28
|
|
|
|
|
LL | y.into_iter().for_each(|x| add_to_res(x));
|
|
| ^^^^^^^^^^^^^^^^^ help: replace the closure with the function itself: `&mut add_to_res`
|
|
|
|
error: redundant closure
|
|
--> $DIR/eta.rs:212:28
|
|
|
|
|
LL | z.into_iter().for_each(|x| add_to_res(x));
|
|
| ^^^^^^^^^^^^^^^^^ help: replace the closure with the function itself: `add_to_res`
|
|
|
|
error: redundant closure
|
|
--> $DIR/eta.rs:219:21
|
|
|
|
|
LL | Some(1).map(|n| closure(n));
|
|
| ^^^^^^^^^^^^^^ help: replace the closure with the function itself: `&mut closure`
|
|
|
|
error: redundant closure
|
|
--> $DIR/eta.rs:223:21
|
|
|
|
|
LL | Some(1).map(|n| in_loop(n));
|
|
| ^^^^^^^^^^^^^^ help: replace the closure with the function itself: `in_loop`
|
|
|
|
error: redundant closure
|
|
--> $DIR/eta.rs:316:18
|
|
|
|
|
LL | takes_fn_mut(|| f());
|
|
| ^^^^^^ help: replace the closure with the function itself: `&mut f`
|
|
|
|
error: redundant closure
|
|
--> $DIR/eta.rs:319:19
|
|
|
|
|
LL | takes_fn_once(|| f());
|
|
| ^^^^^^ help: replace the closure with the function itself: `&mut f`
|
|
|
|
error: redundant closure
|
|
--> $DIR/eta.rs:323:26
|
|
|
|
|
LL | move || takes_fn_mut(|| f_used_once())
|
|
| ^^^^^^^^^^^^^^^^ help: replace the closure with the function itself: `&mut f_used_once`
|
|
|
|
error: redundant closure
|
|
--> $DIR/eta.rs:335:19
|
|
|
|
|
LL | array_opt.map(|a| a.as_slice());
|
|
| ^^^^^^^^^^^^^^^^ help: replace the closure with the method itself: `<[u8; 3]>::as_slice`
|
|
|
|
error: redundant closure
|
|
--> $DIR/eta.rs:338:19
|
|
|
|
|
LL | slice_opt.map(|s| s.len());
|
|
| ^^^^^^^^^^^ help: replace the closure with the method itself: `<[u8]>::len`
|
|
|
|
error: redundant closure
|
|
--> $DIR/eta.rs:341:17
|
|
|
|
|
LL | ptr_opt.map(|p| p.is_null());
|
|
| ^^^^^^^^^^^^^^^ help: replace the closure with the method itself: `<*const usize>::is_null`
|
|
|
|
error: redundant closure
|
|
--> $DIR/eta.rs:345:17
|
|
|
|
|
LL | dyn_opt.map(|d| d.method_on_dyn());
|
|
| ^^^^^^^^^^^^^^^^^^^^^ help: replace the closure with the method itself: `<dyn TestTrait>::method_on_dyn`
|
|
|
|
error: redundant closure
|
|
--> $DIR/eta.rs:388:19
|
|
|
|
|
LL | let _ = f(&0, |x, y| f2(x, y));
|
|
| ^^^^^^^^^^^^^^^ help: replace the closure with the function itself: `f2`
|
|
|
|
error: aborting due to 27 previous errors
|
|
|