mirror of
https://github.com/rust-lang/rust-clippy
synced 2024-11-24 05:33:27 +00:00
148 lines
3.5 KiB
Text
148 lines
3.5 KiB
Text
error: variable appears on both sides of an assignment operation
|
|
--> tests/ui/assign_ops2.rs:10:5
|
|
|
|
|
LL | a += a + 1;
|
|
| ^^^^^^^^^^
|
|
|
|
|
= note: `-D clippy::misrefactored-assign-op` implied by `-D warnings`
|
|
= help: to override `-D warnings` add `#[allow(clippy::misrefactored_assign_op)]`
|
|
help: did you mean `a = a + 1` or `a = a + a + 1`? Consider replacing it with
|
|
|
|
|
LL | a += 1;
|
|
| ~~~~~~
|
|
help: or
|
|
|
|
|
LL | a = a + a + 1;
|
|
| ~~~~~~~~~~~~~
|
|
|
|
error: variable appears on both sides of an assignment operation
|
|
--> tests/ui/assign_ops2.rs:13:5
|
|
|
|
|
LL | a += 1 + a;
|
|
| ^^^^^^^^^^
|
|
|
|
|
help: did you mean `a = a + 1` or `a = a + 1 + a`? Consider replacing it with
|
|
|
|
|
LL | a += 1;
|
|
| ~~~~~~
|
|
help: or
|
|
|
|
|
LL | a = a + 1 + a;
|
|
| ~~~~~~~~~~~~~
|
|
|
|
error: variable appears on both sides of an assignment operation
|
|
--> tests/ui/assign_ops2.rs:15:5
|
|
|
|
|
LL | a -= a - 1;
|
|
| ^^^^^^^^^^
|
|
|
|
|
help: did you mean `a = a - 1` or `a = a - (a - 1)`? Consider replacing it with
|
|
|
|
|
LL | a -= 1;
|
|
| ~~~~~~
|
|
help: or
|
|
|
|
|
LL | a = a - (a - 1);
|
|
| ~~~~~~~~~~~~~~~
|
|
|
|
error: variable appears on both sides of an assignment operation
|
|
--> tests/ui/assign_ops2.rs:17:5
|
|
|
|
|
LL | a *= a * 99;
|
|
| ^^^^^^^^^^^
|
|
|
|
|
help: did you mean `a = a * 99` or `a = a * a * 99`? Consider replacing it with
|
|
|
|
|
LL | a *= 99;
|
|
| ~~~~~~~
|
|
help: or
|
|
|
|
|
LL | a = a * a * 99;
|
|
| ~~~~~~~~~~~~~~
|
|
|
|
error: variable appears on both sides of an assignment operation
|
|
--> tests/ui/assign_ops2.rs:19:5
|
|
|
|
|
LL | a *= 42 * a;
|
|
| ^^^^^^^^^^^
|
|
|
|
|
help: did you mean `a = a * 42` or `a = a * 42 * a`? Consider replacing it with
|
|
|
|
|
LL | a *= 42;
|
|
| ~~~~~~~
|
|
help: or
|
|
|
|
|
LL | a = a * 42 * a;
|
|
| ~~~~~~~~~~~~~~
|
|
|
|
error: variable appears on both sides of an assignment operation
|
|
--> tests/ui/assign_ops2.rs:21:5
|
|
|
|
|
LL | a /= a / 2;
|
|
| ^^^^^^^^^^
|
|
|
|
|
help: did you mean `a = a / 2` or `a = a / (a / 2)`? Consider replacing it with
|
|
|
|
|
LL | a /= 2;
|
|
| ~~~~~~
|
|
help: or
|
|
|
|
|
LL | a = a / (a / 2);
|
|
| ~~~~~~~~~~~~~~~
|
|
|
|
error: variable appears on both sides of an assignment operation
|
|
--> tests/ui/assign_ops2.rs:23:5
|
|
|
|
|
LL | a %= a % 5;
|
|
| ^^^^^^^^^^
|
|
|
|
|
help: did you mean `a = a % 5` or `a = a % (a % 5)`? Consider replacing it with
|
|
|
|
|
LL | a %= 5;
|
|
| ~~~~~~
|
|
help: or
|
|
|
|
|
LL | a = a % (a % 5);
|
|
| ~~~~~~~~~~~~~~~
|
|
|
|
error: variable appears on both sides of an assignment operation
|
|
--> tests/ui/assign_ops2.rs:25:5
|
|
|
|
|
LL | a &= a & 1;
|
|
| ^^^^^^^^^^
|
|
|
|
|
help: did you mean `a = a & 1` or `a = a & a & 1`? Consider replacing it with
|
|
|
|
|
LL | a &= 1;
|
|
| ~~~~~~
|
|
help: or
|
|
|
|
|
LL | a = a & a & 1;
|
|
| ~~~~~~~~~~~~~
|
|
|
|
error: variable appears on both sides of an assignment operation
|
|
--> tests/ui/assign_ops2.rs:27:5
|
|
|
|
|
LL | a *= a * a;
|
|
| ^^^^^^^^^^
|
|
|
|
|
help: did you mean `a = a * a` or `a = a * a * a`? Consider replacing it with
|
|
|
|
|
LL | a *= a;
|
|
| ~~~~~~
|
|
help: or
|
|
|
|
|
LL | a = a * a * a;
|
|
| ~~~~~~~~~~~~~
|
|
|
|
error: manual implementation of an assign operation
|
|
--> tests/ui/assign_ops2.rs:65:5
|
|
|
|
|
LL | buf = buf + cows.clone();
|
|
| ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `buf += cows.clone()`
|
|
|
|
|
= note: `-D clippy::assign-op-pattern` implied by `-D warnings`
|
|
= help: to override `-D warnings` add `#[allow(clippy::assign_op_pattern)]`
|
|
|
|
error: aborting due to 10 previous errors
|
|
|