mirror of
https://github.com/rust-lang/rust-clippy
synced 2024-09-21 23:21:57 +00:00
be14ea8c37
It should be of the form `(a - b).abs() > error` whereas it was `(a - b).abs() < error` that is instead what should be used for equality.
87 lines
2.6 KiB
Text
87 lines
2.6 KiB
Text
error: strict comparison of f32 or f64 constant
|
|
--> $DIR/float_cmp_const.rs:18:5
|
|
|
|
|
LL | 1f32 == ONE;
|
|
| ^^^^^^^^^^^ help: consider comparing them within some error: `(1f32 - ONE).abs() < error`
|
|
|
|
|
= note: `-D clippy::float-cmp-const` implied by `-D warnings`
|
|
note: std::f32::EPSILON and std::f64::EPSILON are available.
|
|
--> $DIR/float_cmp_const.rs:18:5
|
|
|
|
|
LL | 1f32 == ONE;
|
|
| ^^^^^^^^^^^
|
|
|
|
error: strict comparison of f32 or f64 constant
|
|
--> $DIR/float_cmp_const.rs:19:5
|
|
|
|
|
LL | TWO == ONE;
|
|
| ^^^^^^^^^^ help: consider comparing them within some error: `(TWO - ONE).abs() < error`
|
|
|
|
|
note: std::f32::EPSILON and std::f64::EPSILON are available.
|
|
--> $DIR/float_cmp_const.rs:19:5
|
|
|
|
|
LL | TWO == ONE;
|
|
| ^^^^^^^^^^
|
|
|
|
error: strict comparison of f32 or f64 constant
|
|
--> $DIR/float_cmp_const.rs:20:5
|
|
|
|
|
LL | TWO != ONE;
|
|
| ^^^^^^^^^^ help: consider comparing them within some error: `(TWO - ONE).abs() > error`
|
|
|
|
|
note: std::f32::EPSILON and std::f64::EPSILON are available.
|
|
--> $DIR/float_cmp_const.rs:20:5
|
|
|
|
|
LL | TWO != ONE;
|
|
| ^^^^^^^^^^
|
|
|
|
error: strict comparison of f32 or f64 constant
|
|
--> $DIR/float_cmp_const.rs:21:5
|
|
|
|
|
LL | ONE + ONE == TWO;
|
|
| ^^^^^^^^^^^^^^^^ help: consider comparing them within some error: `(ONE + ONE - TWO).abs() < error`
|
|
|
|
|
note: std::f32::EPSILON and std::f64::EPSILON are available.
|
|
--> $DIR/float_cmp_const.rs:21:5
|
|
|
|
|
LL | ONE + ONE == TWO;
|
|
| ^^^^^^^^^^^^^^^^
|
|
|
|
error: strict comparison of f32 or f64 constant
|
|
--> $DIR/float_cmp_const.rs:23:5
|
|
|
|
|
LL | x as f32 == ONE;
|
|
| ^^^^^^^^^^^^^^^ help: consider comparing them within some error: `(x as f32 - ONE).abs() < error`
|
|
|
|
|
note: std::f32::EPSILON and std::f64::EPSILON are available.
|
|
--> $DIR/float_cmp_const.rs:23:5
|
|
|
|
|
LL | x as f32 == ONE;
|
|
| ^^^^^^^^^^^^^^^
|
|
|
|
error: strict comparison of f32 or f64 constant
|
|
--> $DIR/float_cmp_const.rs:26:5
|
|
|
|
|
LL | v == ONE;
|
|
| ^^^^^^^^ help: consider comparing them within some error: `(v - ONE).abs() < error`
|
|
|
|
|
note: std::f32::EPSILON and std::f64::EPSILON are available.
|
|
--> $DIR/float_cmp_const.rs:26:5
|
|
|
|
|
LL | v == ONE;
|
|
| ^^^^^^^^
|
|
|
|
error: strict comparison of f32 or f64 constant
|
|
--> $DIR/float_cmp_const.rs:27:5
|
|
|
|
|
LL | v != ONE;
|
|
| ^^^^^^^^ help: consider comparing them within some error: `(v - ONE).abs() > error`
|
|
|
|
|
note: std::f32::EPSILON and std::f64::EPSILON are available.
|
|
--> $DIR/float_cmp_const.rs:27:5
|
|
|
|
|
LL | v != ONE;
|
|
| ^^^^^^^^
|
|
|
|
error: aborting due to 7 previous errors
|
|
|